From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 084613D810D for ; Tue, 21 Apr 2026 13:49:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779397; cv=none; b=Yh+N9rYKAWobwlxeFEWwrBU3SHtPIOJWKxI9PIwLUnOOerVfJs2KvypnNSwY1Xt9a6qg/7nKXG8y5GsOpljLZsSuJZlQzNVGTmXlJjbvt+H6zx1McGseqCECWBSZNNPh9RXmkAuyhnGr1PzXIAowF02lBPEUUDAyfgnUTG81Rx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776779397; c=relaxed/simple; bh=kKZ2eoQ5zExPxPUVDm9+Bjv946REbBveK4BG4RekTwk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T1CqWmdtiyAWhF5YAH92vEMjrBV8zQyfJAJLfpkvaL+teYV6Se3xA0vJ9xsveAE3d7uLY0ZV9m34LIkCt6n9tj2ORYqhmgsCsUNTD3QIVWYFOnIEXW86pQElDbE+DNA5RO6GRHmygEoi/WyAEeq1EHogzkjxBO3MRKDneXP3RQg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=El27gZ9O; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="El27gZ9O" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-43d64313c39so3367094f8f.3 for ; Tue, 21 Apr 2026 06:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776779394; x=1777384194; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2zHXMr6dY7lbD0aEaxS9wFDwdUTKjF7ef2KbAfXUkPE=; b=El27gZ9OlwnaitqqZOs+yfShEU0YqlH+Nq72sniySrJjn1Nmp02Nryq6+8KeqPppVF tyDv2KXc0J0quwxpy+hQsXU+e86UoQQk9CoCCs64+6a2SGBd+kTfL3DQzX/q7qjHHCrB jyjRLvTyAdmVqk0uRpkFcyG/STmNhHbgjMp+aHTFN8knuiiH7HL7eDKke2sv3XHTLU/z uy/hMsYFbkf88ost5mr79tGklRf8h103xAyDLe/QEQMPFi3sumN3eXj4uhP4B5LxDtLr Xh25+Xqs8VPoYLfEEaRh8XH3TNyl/WsW7i0/57eqD1qay7ouS8PQ+farRHEwj3R9XGYs /gjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776779394; x=1777384194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2zHXMr6dY7lbD0aEaxS9wFDwdUTKjF7ef2KbAfXUkPE=; b=fQoLHZ5Fr9rdn3m9wLd5fE4FBMZBeQpxdaCGBYnHnlSj7qdBJ4YQY66J6YL2J/FZgZ DlbCpmegrwE0id4BqxiTFOc1q0hpnoY45ah+FusITClWgvPml7ujGH8J/vO2XBlnDCdM I3+af0fzcQPkVk8TnCs1zMMTj9FdKD0rHFMXKo0K+lKIxNRiqpsTD2A6Spjg2GZvvEBL fA0qn9PhRHqAMZlETUZ6OsNxG20ECk+ObjmGr5p9IW62/sUxCnxxn+ZcK5HUejExDBS6 3E95bstDaBYriPcMcaqXUuDEx/YL1bGvoI+aV4hHYKc/NIoBz8Sxf0NjM+IK2XoTl7GM mZcg== X-Forwarded-Encrypted: i=1; AFNElJ8Q6lvfOdXOesNDkPwg5BGnPRLlCLPRmhRGY8nbT5CRQkDp1UDkKHWYUnpKD8aZjTz4wH+XG7RpPFYRh3U=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl7rm5nBaSN3CyAPCEOtS5/emQIFOtCOTuqRHCpNwpEYQYW2xU 0rgChBDu0Jt943hLZuQ5Mgr8dpzjVpJklvQZe6kGexeXek3bdT6mOc+jYIwW X-Gm-Gg: AeBDievU1ihwEv6bnv6R0fSGhabDE8gLnwVWS/NLVg9MMXdCdia9EaQ75JQRDeK5HAs MKPSQR3gOF1DnG0BIWaCArR0pQ50x2My4Uft3KzJmUmLY9PWVFT91NKflRahdDHWFtx9UAoHjzU SUlqmMP1oY/43sOzRVV6okoEKabJWCxxF4D01ubRkDfcZTpxnAMQuDE3306f9+iQPw/chPG30Vy fFUnvzRWazD3TmmGDEeUtZ6H0WhdPPT5FRNnJeD/r9ISf/F8nPuTjjm7pC+uvdJRd60W9R85mxr B0pNDr7UFcu0CkmDXfWtZJqCMhkFCxIlaU4E60YGadNbHftKkAX41vtaFUz/RFGdZUafjgadoYC M7gAcaZLHF2OpWJEhyKN1UBUsnX5KYBkw2DbgBcE1nEYz51FBdmWPixEjQVYktWs/nxFjHUHVXx 9pvtE= X-Received: by 2002:a05:6000:250e:b0:43d:7ef:552f with SMTP id ffacd0b85a97d-43fe3dfbd9fmr29529388f8f.25.1776779394294; Tue, 21 Apr 2026 06:49:54 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cb13a0sm37671480f8f.8.2026.04.21.06.49.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 06:49:53 -0700 (PDT) From: Tristan Madani To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani Subject: [PATCH v3 1/3] wifi: wl18xx: fix OOB read from firmware rx_ba_link_id in BA event handler Date: Tue, 21 Apr 2026 13:49:49 +0000 Message-ID: <20260421134952.338301-2-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260421134952.338301-1-tristmd@gmail.com> References: <20260421134952.338301-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani The firmware-controlled rx_ba_link_id (u8) is used to index the 16-entry wl->links[] array without bounds checking in the BA window size change event handler. An out-of-range value causes OOB reads and an immediate pointer dereference of the OOB wlvif field. Add bounds validation consistent with all other HLID consumers in the driver. Fixes: d4392269f7ce ("wlcore: Add RX_BA_WIN_SIZE_CHANGE_EVENT event") Signed-off-by: Tristan Madani --- Changes in v3: - Regenerated from wireless-next with proper git format-patch to produce valid index hashes (v2 had post-processed index lines). Changes in v2: - No code changes from v1. drivers/net/wireless/ti/wl18xx/event.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/ti/wl18xx/event.c b/drivers/net/wireless/ti/wl18xx/event.c index a9f090e15cbbe..fac12a8590355 100644 --- a/drivers/net/wireless/ti/wl18xx/event.c +++ b/drivers/net/wireless/ti/wl18xx/event.c @@ -212,6 +212,12 @@ int wl18xx_process_mailbox_events(struct wl1271 *wl) u8 win_size = mbox->rx_ba_win_size; const u8 *addr; + if (link_id >= WLCORE_MAX_LINKS) { + wl1271_error("BA event: invalid link_id %u\n", + link_id); + goto out; + } + wlvif = wl->links[link_id].wlvif; vif = wl12xx_wlvif_to_vif(wlvif); -- 2.47.3