From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FD6613DDAE for ; Tue, 21 Apr 2026 13:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776778612; cv=none; b=Wsi4tM6JziXgLRcpZ0rabq+Vl3+LiezSp3rAal8lwXC3wkYAAWRBYnorqluZOoSMdsm3For12QGZwvFtIVmBpFVzQkN3XkSDzbbB/kSwmHv3pf+Q+qXFOfpAAJ1ZzbEsjm6KBGezScFUnV6lcnchA+CfD4PWdJckjKEME1XYDlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776778612; c=relaxed/simple; bh=HfC2rcAHx3L49DKzGd14vHAZZy0fNUJCCBnyc+rOkLE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZKJ7j6nUdr2e0cArhzA2l5XNnr2hlBVPa2qkOOcz/uyNOSgV50Db4C0xX6S4UcfePFPSQtoGAUwlJdwz6xeTWHvrdGHbIk5Hv8/TXdMxrKV3YhiUVhvOF47nFN6GTIyRlRCeOn/whJ3G/nH6FXh0jKcGpxkCmDDmQjpKRWTTS+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lMYIGMII; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lMYIGMII" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-36146ae9dd4so3235098a91.3 for ; Tue, 21 Apr 2026 06:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776778611; x=1777383411; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cICu5OuDgaUihDORDEXfRm9USuXHUFKG9LJ148MNZfc=; b=lMYIGMII5DlAOJQitdFYXG2KirvXSphet3DjqNanHfh2T0+yw6pGsX6ey7al4nK9HP aLHoZqokt75WopsgXPeU1EUcYa4TtleVFyGk5Ex2nUhhONkEbx6AuKCiwXxMiCrRPhs7 AiTbQSkAuJgTYYL2ZLa8sRUHuiiOPne1ZkocptX5q2juxltw7/Ob+jiGWdfem9On8b2W 9efM3zHODMEGtKhsRpZMFdBJc5mr1EEqD2zdcdoOe/LVUwKKpxr5SlCP8s30umylOBYr V/V5JXFBcaF6KU0Ocd4Ion+lNQgccKjb/V1eqlqLiP98dJx6b75K9mYgEgU8Hv71czf7 N/ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776778611; x=1777383411; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cICu5OuDgaUihDORDEXfRm9USuXHUFKG9LJ148MNZfc=; b=GFfXZIiq+KiLOl6DKk4YA0y7+HNxBUT2kzjlb/6VRSrh5b5FLgDeHJ+wrHqeXeifVB ENA9do0Ek1PMlkWvZxAHKVVwSIZ197tXID7zPesuLUDKhij43i24u5Xbf9xQl6XG/6rO yqIk1sHC8d7msFi9/9qF8KeIlA7za8iJ3NaHO8jhFwR7IYvnigp61Eg++5tFYuTzIT8o 6z/M0ZE+aNLAU4Fnj0wfJcbB1WtkUu52ET5L3NCWOAA3++0kjUDWcsy34rs0FHIX6prg NkX1iAE0WNhKMc7NV27KS0CmnbsU16yPHvNZtga68XLe8EKX7tLCJzmcBJ8XGVJA9FeB xgkw== X-Forwarded-Encrypted: i=1; AFNElJ/8fp9qGxbVve2syJd+FpYPtux7PgpB6eE7Xrm6ay1m/faoRPU1t51g9OqltcxqYh8nyqe9qbIXvpC75zE=@vger.kernel.org X-Gm-Message-State: AOJu0YyTk96PythQ+P43M90pFjcZ56fqeLkrdtfZnl0j2XOoZ4GSwG4a qbiYt73RM84SyhHAkTo0YXneuUYEcQO9ZOXGaxiFHPmNdH/MJkGZa4yJNTE2a/K6 X-Gm-Gg: AeBDiesmT9Qxewbsom4Qg61ZJxOziW6mci0SD/Ii1pxeIrnzSJu0gw+6KdUqdRDcqOD HeY3zl7FEeGiMadYumzN0eP+6TZvdMTTy5KiBU8WJypJ6i9AMmDa1hPUzcGPU+PKeTdl9VPCIFU eP6fx79t45hCUjwyEzX4ZkOybJsI9Aj3DdMG/TkGyfmlbLDxU87K6ne7erP8EIoVVRFxzEhMqUe bTbV5mwwXHCy5EvS+MkNh8EVo6GET3fc7MG2vvr5rGNvyDt1y3UshHKbcULTUjesi6kFIAhdHnB Gb4TdIFLy1fdlem92EE7Xn0O8Ri5hC7Nd+N1lxUm5vb4C6eJ6964SXOfIU+rzev6CG6JABO7xOy DG5xh92IXCE/Cw3cnvNcP/r+1gyRhls+VoSzjUToXFl2RXLeOW8jGKih5LXUj1dUioXw/gd+Qbt LTezgRqr9FKRCeWOrtiyTfs6I5In5CTet2+CYd0Y1k5WirKguSNtVECMx1my95pT6SngnNPMW/M NSqonuat0GtFAe4 X-Received: by 2002:a17:90b:1642:b0:35f:b107:f1ae with SMTP id 98e67ed59e1d1-361403adbcfmr18302652a91.4.1776778610624; Tue, 21 Apr 2026 06:36:50 -0700 (PDT) Received: from cchengyang.duckdns.org (36-225-97-241.dynamic-ip.hinet.net. [36.225.97.241]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c79770587c1sm10602734a12.32.2026.04.21.06.36.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 06:36:50 -0700 (PDT) Date: Tue, 21 Apr 2026 21:36:47 +0800 From: Cheng-Yang Chou To: Tejun Heo Cc: void@manifault.com, arighi@nvidia.com, changwoo@igalia.com, sched-ext@lists.linux.dev, emil@etsalapatis.com, linux-kernel@vger.kernel.org, Ching-Chun Huang , Chia-Ping Tsai Subject: Re: [PATCH 02/16] sched_ext: Move scx_exit(), scx_error() and friends to ext_internal.h Message-ID: <20260421213118.Gdc56@cchengyang.duckdns.org> References: <20260421071945.3110084-1-tj@kernel.org> <20260421071945.3110084-3-tj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260421071945.3110084-3-tj@kernel.org> Hi Tejun, On Mon, Apr 20, 2026 at 09:19:31PM -1000, Tejun Heo wrote: > Things shared across multiple .c files belong in a header. scx_exit() / > scx_error() (and their scx_vexit() / scx_verror() siblings) are already > called from ext_idle.c and the upcoming ext_cid.c, and it was only > build_policy.c's textual inclusion of ext.c that made the references > resolve. Move the whole family to ext_internal.h. > > Pure visibility change. > > Signed-off-by: Tejun Heo Reviewed-by: Cheng-Yang Chou -- Cheers, Cheng-Yang