From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A189F3CF043 for ; Wed, 22 Apr 2026 11:17:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856623; cv=none; b=KHGPyqiemBX5iwkv3pOpBQ2pT6fGCLzoag18ibskCwZ0UEEXXW0oFr+Cw3E3LzdEO/SVOiXLGtfd28r6i3fDyN6/AztFwEIj7TnzIv9QDY0vtCmXrfw4Yp0lxY5SlX3MJiqtiYcVX/k0f5ik2dfJMXmkI7MC46aqt909z/FXH7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856623; c=relaxed/simple; bh=nikLaA78L13NJnXz60ZFuoAdhal5Om5tpindurSqR+A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cHb176gGR6noVxN1N+dhs39Fuxh/p8Nt/LMTganpsM7oUWyxyNcnIFoFdDQ28Y19SbbVYYPqe5kRl0jUdj6g8tSKovmXT6x9wO6s8p5pmjbx0arFKF1axKHu0x4Jdkm7Pt6yJ8uPFqDQKN0CRPy3HEfi19on1pLdRr6FC++If8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kmRNr1R9; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kmRNr1R9" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so45033205ad.2 for ; Wed, 22 Apr 2026 04:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776856622; x=1777461422; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+2n2qVtDxXB1QkZ7SDG3S4ms/93RE7PN+H3Oc8MJU/I=; b=kmRNr1R9nk0XDGxByqrWRuolaTTnIpX5jVILr/xtjbPTa4Lv5KqTYML3xOsxbcHKW5 ZI0YIcmA3MNfAMBlI4QC3g1CeXxgIW/s+tVSKLM90NkUekKRu1Zb2dXIL+1SaIrWXdxF vouIf0LTB2Czyg61yYg/hZKfDWkCiAGwkAiJwZzQ6+sqYP2zDpdPgzql8aevNYsyae1b g5hes8DqKh4z8IB/WZE/w86Srqp1Tc7fgi/whtqwdYCPHifxCCMIgSwzCEz4AkmT4B5r erX+7InsF9G3bIiCnWBLgf5Hhnk317v1nEaP+DfCSIWtHwhw88IxOXPMNnMbNSJG/N2p f3ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776856622; x=1777461422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+2n2qVtDxXB1QkZ7SDG3S4ms/93RE7PN+H3Oc8MJU/I=; b=k1GzZM0kEV39NHQZG4PE9z9L5j6+8JcanAzoVdgAgGaQvvS6iw8pG6KrPCiC6pACyS bcGj2LJKXiwX9MErHXf0Z1M895xY67+CP+X1DQ3/jzrKzEXrbxUBHfPBJvpV2fe5t+yt Ah+67KR+PPbYeMnseRhzzcAprvdjY09FgfZOo9hxHmIQ4HlW6yCDp6/MWajYalxRvOBR ZDF3Umd9seGyEmCCS42k/l8vs13sKS2z8MJYXZh4k64T/HM1wmr99J0K1VZ+Sxgd6ENZ NhdoRLPTexh5DqjwJG3T+IoF58a6OfJlgQVqFiecjIhnI4gi0RF38FbQlE3JhWmqowTr HGFQ== X-Forwarded-Encrypted: i=1; AFNElJ/FbISpHUA52U9Nr1PuGjt7xpVbdyoEibCKt3j0uYklW6Eszvo/Bz/L5EwBgz4A04z1BmF6AglI3otyn5s=@vger.kernel.org X-Gm-Message-State: AOJu0YwGx9tNT6/0188St2k2gTg/4Oqja+9LMX6rTjowT08LsytUsnAD ClhjtlsCKe0rNgTfhb6vLxxTvk4h7IR7wdP+pNA6k4Orr7/dSK5iLZSa X-Gm-Gg: AeBDieviF5VVLInVyoVKNM8hGaBmmHjlWGbaN+2MoNGF9zKJhBPht9FDPZV1MeBE3Mv eTzaD8NusrxO3yVMXnLqv3RaLp/FlSAFGJBzpYtGlQHBySAT/bh3H02o5WPj6hcJN0GbzyXNBIS LPxazl2rL2n8kaAuQCEIyM6CPl7JrICyBM9L+MW++hD0v8OoZKz6iQBFS7SRzCdUXJWVwcMxy9u eixRJMcTWmC3Rlc4a6BXZSTIyCS+8bPsYfKr/1zZj9lVYaFIHfinTS2/Q+NOIEcUAmvUPkWiETm 9q8BdJ+PDa/lpddiYZoq8XqQ9dwGuhLsbCz1IM3t33/aQ1IRQn6IcqCSdyFIKlEpNR0mMvoWn6w ZkRuw/nanEjEvI3ZBzrahom+S1PDjCyRrb6yAXlGGt4GrEHfEQdAKZERsw+wClvjZxfAI2bRzqA yCe2+qINehNVSioJThDEypqsCKPZiTaQ0aYOlEs1o29evmQ8iGw+2P X-Received: by 2002:a17:903:3905:b0:2b2:5840:80c5 with SMTP id d9443c01a7336-2b5fa007e8dmr230079155ad.37.1776856621760; Wed, 22 Apr 2026 04:17:01 -0700 (PDT) Received: from arch.localdomain ([103.182.132.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cddfsm232798835ad.49.2026.04.22.04.16.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 04:17:01 -0700 (PDT) From: Debjeet Banerjee To: sakari.ailus@linux.intel.com Cc: andy.shevchenko@gmail.com, andy@kernel.org, debjeetbanerjee48@gmail.com, gregkh@linuxfoundation.org, hansg@kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, mchehab@kernel.org Subject: Re: [PATCH v3] media: atomisp: csi2: Fix DPCM decompression for source pad format Date: Wed, 22 Apr 2026 16:46:49 +0530 Message-ID: <20260422111649.9604-1-debjeetbanerjee48@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, Apr 22, 2026 at 01:46:33PM +0300, Sakari Ailus wrote: > It may well be but the rest of the driver doesn't appear to support DPCM > uncompression. Rather than trying to pretend it does, I'd instead just > remove any references to it. Thanks for the feedback Sakari. So if I understand correctly, the right fix here is to remove all the DPCM-related dead code: compressed_codes[], atomisp_subdev_uncompressed_code(), atomisp_subdev_is_compressed(), and atomisp_find_in_fmt_conv_compressed() declaration And in atomisp_csi2.c just keep the source pad copying the sink format as before, but drop the FIXME comment since we're explicitly acknowledging DPCM is not supported? Please let me know if I'm on the right track before I send v4 of this patch. Regards, Debjeet