From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B88813D330A for ; Wed, 22 Apr 2026 12:20:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860427; cv=none; b=AF3LGOm2ePKZGTG0nZO3hLqVqVbrwLWrarfo6oYrzlrbGwtpXVvxi2AsUTDnW6TgSAjDjylS1GymnWJ7jbfNP9L7mNCTvzyWDLkv8mVveIgf4GRKgizyMHlVwJBTgen7y3iZDVSKaClR6TAUgjFix+w8aAYONo/9aGOe/o/TkuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860427; c=relaxed/simple; bh=Jz2IRjOiJ/M8WuaaKQqT9yeyni2Rlhh9VMwuz6lyXkM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kr15Em4SkhpN+SARzjT5CujVcgPVesFwgCCc/0bJO9imkxMCwTNHxD0A1AVZw01PiGvonoa/yZVRLDj/JKf26jT6XiNEjm7WJ5AGJu7AbFvh++7q6qrHFjTdVwNpMO59bA+7JYT6pVJ9dD0n00rLM1gmvZc2xeZFjewGer2gg94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mkcgKIl/; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mkcgKIl/" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c797d5ad36bso1582095a12.2 for ; Wed, 22 Apr 2026 05:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776860425; x=1777465225; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9o+1Y3qFEujqIV/P/1ozlPANKTLBduTXUFO4gXypNYs=; b=mkcgKIl/x1543qk6yArfijNKEQZZoblK78reAsrCaSC2QhHY7yixZ7rqVNHtn7ZXYq jyRbSiRn1jTimUo5fwIPksW6mqgwgWdfUS+hTsuIx8IDZ8liQJ+wxy63MM4BN7Xhphb6 JCiV8Niou2InigVrL9wo0SBuXTb9ilzzzw3c07S3LRfkpUrd87dfyFc+1/GvnmJK6IlT 1x3KeHpaWYtkcHYWiHM9bcQy2w2jFu2YQWAchQQPo9hGWzgVQ4hoxi8qs6dNR1zpsKgp bq6CAaMmE9vBQyEE441fs0Ea+FxqOBWK5GNCUQ1dirU+bsQe8D2hsCLzmV+gVQZTSv9H w4jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776860425; x=1777465225; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9o+1Y3qFEujqIV/P/1ozlPANKTLBduTXUFO4gXypNYs=; b=InryxPgyVm+pBjQNlT7+i4QCQig06fW/hBSFQ1TJ/xo5ZLw4s2HY94yQyTkZGpp2mT IUeB7FAe5Y7T4h6k4U17M/ifMAiS+j90NKA6bjh57tPYQzsD5LHi0uBzVpAmH34JIJqL jzFZzPyr6YjBeDmKhBjMhNx+IWJ7PVCFiw4Xf+/7HLL9nI6Li5JlzNavYLNCVY6cYFAZ sTev/oJOBFylEVXuWIPVo2fdQP14Ye12Vn8PP/bvN5YFJw1z5gZU+VCYNjIViq+UM8Fo G0kKoNiqaidBy44l84stn+NNqB+v/pKrno1R6LcKmsCuGhiH8ZBZ4121KjxcIDAyKeMX 1H0A== X-Forwarded-Encrypted: i=1; AFNElJ8ktKDVCEeoj+miGr7YViNRmSryBDuHNYVKUGPnzJggiOSpRbk/O85j5mWccqe7PMjjMSMi818nzwwXAE0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5rz+3TBXARGi9PgHiTMpZGuPgUGwMn01APjCh9JB5NcYZSDvj AUvVoVP3dCbs3qrZPS9Kx/T1teWqQIWW7vbQuPX24FQ6ZPLT+VVLls1G X-Gm-Gg: AeBDiet/9eD7PJORvh5WKxOAlP0zPT/XEyNeoB2RpWOPypwDuR8CdnPCacT2wA/Imw0 6i1gIG/xrQOKbRgzMLWOt36Cpr8RZUD0SJ0EseG141uaetBdELX1M+4kUB9QB3518+byi/bdau/ 4UAlO2UhQRyHkQECsqOC7xt5PFo4FKyUqUYYzDSL3fKJlkK5Jy+0OQMeIPQDVX1PJKufvKMVomN 096Wt/LEhJeD7ItjJWS8Yt5I196TPl0AUzkSJwBu0+Jr+XarP871m9oRb5YpvKXbuhGsYlWh3IS SC4cGzpU5Yev0F1giWxdqaYBeuliUNPYqFSz3z43krnBtNqFKUkPIKwKSDsIucO1aEhiksNauOT jJv+3SrhTWQk+/NUd05/VL6bkjVKxXFTkpMmA52yXuvvYTKIRhGdgHt4MPTnY4/uvy7ydJVTF3H QRgs2OcLTNzZsUVnG/NjXfxBQiwjmiAMhdMb4Z3GUr0hOp0V0ks6P+ X-Received: by 2002:a05:6a20:7faa:b0:3a1:90ef:7e31 with SMTP id adf61e73a8af0-3a190ef81d8mr15048824637.54.1776860424962; Wed, 22 Apr 2026 05:20:24 -0700 (PDT) Received: from arch.localdomain ([103.182.132.254]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797701b1a3sm12798030a12.19.2026.04.22.05.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 05:20:24 -0700 (PDT) From: Debjeet Banerjee To: sakari.ailus@linux.intel.com Cc: andy.shevchenko@gmail.com, andy@kernel.org, debjeetbanerjee48@gmail.com, gregkh@linuxfoundation.org, hansg@kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, mchehab@kernel.org Subject: [PATCH v4 1/2] media: atomisp: csi2: Remove unimplemented DPCM decompression Date: Wed, 22 Apr 2026 17:50:05 +0530 Message-ID: <20260422122006.29390-1-debjeetbanerjee48@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The source pad format handling attempted to map DPCM-compressed mbus codes to their uncompressed equivalents. However, the rest of the driver does not support DPCM decompression, making this dead code. Remove the DPCM unmapping logic and simplify to directly copy the sink pad format to the source pad. Add an explicit comment stating that DPCM is not supported. Signed-off-by: Debjeet Banerjee --- v4: - Complete removal of DPCM decompression attempt (per Sakari Ailus feedback) - Keep source pad simply copying sink pad format without unmapping - Replace detailed comment with explicit "DPCM is not supported" statement v3: - Drop "staging:" prefix in subject (per Andy Shevchenko) v2: - Rebased onto latest media tree (fix CI apply failure) - Fix missing linux-staging recipient (typo in v1) - Fix indentation --- drivers/staging/media/atomisp/pci/atomisp_csi2.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2.c b/drivers/staging/media/atomisp/pci/atomisp_csi2.c index e723304bec80..64419c1a805e 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_csi2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_csi2.c @@ -107,17 +107,10 @@ int atomisp_csi2_set_ffmt(struct v4l2_subdev *sd, &tmp_ffmt); } - /* - * The source pad must expose the uncompressed format even when the sink - * pad receives DPCM-compressed data. The hardware decompresses DPCM - * (e.g. SGRBG10_DPCM8_1X8 -> SGRBG10_1X10) between sink and source, - * so propagate the sink format but map the mbus code to its uncompressed - * equivalent. atomisp_subdev_uncompressed_code() returns the code - * unchanged for formats that are not DPCM-compressed. - */ - *actual_ffmt = *__csi2_get_format(csi2, sd_state, which, CSI2_PAD_SINK); - actual_ffmt->code = atomisp_subdev_uncompressed_code(actual_ffmt->code); - *ffmt = *actual_ffmt; + /* Source pad format is copied from sink pad. DPCM is not supported. */ + *actual_ffmt = *ffmt = *__csi2_get_format(csi2, sd_state, which, + CSI2_PAD_SINK); + return 0; } -- 2.53.0