From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 65A1E3ECBF1 for ; Wed, 22 Apr 2026 13:22:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776864148; cv=none; b=o56Eg19uaPk64QQb++GPy9S6ukQkneosYKBKrLqDWA0NhKePjpSfbXe6MtrYYQCjJG42FotIOG49q9rtEk9XnrNzcF77I3xI/iCdayrcxkS334+VyZpwn/0auvl3uWyVf7WXW/PE/fHDsk0PuFt4O5vCulhA4N8nqF52ElU0m1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776864148; c=relaxed/simple; bh=7c8lB0GCyTaxecWeIBaA39LwkNTIZlfwq/jScNJuokc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CVSCxjUW962xvCwdOoDTmYP2ziJbSxQsVBNWFHSSrL2lFgAoH4IqE+UoDrEmwAE//QDGqg8dmtMiIgvq+ay2BpPmhakVo2k4EXR3L9i1FrRMERqbK2TS+KTOhlJ9k8cAdw1rJtPd1I+BM9TaCjy2tt+mDQvzne/d1j8RVVUVKpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=RxsljniF; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="RxsljniF" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2AFE422D9; Wed, 22 Apr 2026 06:22:20 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DBA623FD46; Wed, 22 Apr 2026 06:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776864145; bh=7c8lB0GCyTaxecWeIBaA39LwkNTIZlfwq/jScNJuokc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RxsljniFNKrVN8K6aZzyRX7WSqj9yJaJGq6LlbF1xoSLpF/frI5I50gh4m3SwfT9Y H7cP757dBvHFeTNjoW8ilNeNYXvuy7PpKCke+AyG0xvP0E4cFnjlCugkV4nugfojO+ kutR6ruf+OvppDtSumRPPVEIkxXfPJbnPKQSty2M= From: Yeoreum Yun To: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com, jie.gan@oss.qualcomm.com, Yeoreum Yun Subject: [PATCH v6 08/13] coresight: etm4x: remove redundant call etm4_enable_hw() with hotplug Date: Wed, 22 Apr 2026 14:21:58 +0100 Message-Id: <20260422132203.977549-9-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260422132203.977549-1-yeoreum.yun@arm.com> References: <20260422132203.977549-1-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The cpu_online_mask is set at the CPUHP_BRINGUP_CPU step. In other words, if etm4_enable_sysfs() is called between CPUHP_BRINGUP_CPU and CPUHP_AP_ARM_CORESIGHT_STARTING, etm4_enable_hw() may be invoked in etm4_enable_sysfs_smp_call() and then executed again in etm4_starting_cpu(). To remove this redundant call, take the hotplug lock before executing etm4_enable_sysfs_smp_call(). Reviewed-by: Jie Gan Signed-off-by: Yeoreum Yun --- drivers/hwtracing/coresight/coresight-etm4x-core.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index 5c74e3d63dcd..66d09e0a4171 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -962,8 +962,20 @@ static int etm4_enable_sysfs(struct coresight_device *csdev, struct coresight_pa arg.config = drvdata->config; raw_spin_unlock(&drvdata->spinlock); + /* + * Take the hotplug lock to prevent redundant calls to etm4_enable_hw(). + * + * The cpu_online_mask is set at the CPUHP_BRINGUP_CPU step. + * In other words, if etm4_enable_sysfs() is called between + * CPUHP_BRINGUP_CPU and CPUHP_AP_ARM_CORESIGHT_STARTING, + * etm4_enable_hw() may be invoked in etm4_enable_sysfs_smp_call() + * and then executed again in etm4_starting_cpu(). + */ + cpus_read_lock(); ret = smp_call_function_single(drvdata->cpu, etm4_enable_sysfs_smp_call, &arg, 1); + cpus_read_unlock(); + if (!ret) ret = arg.rc; if (!ret) -- LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}