From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B29E3BE16C for ; Thu, 23 Apr 2026 12:12:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776946349; cv=none; b=nGbs4RzpTtLzBSGU7TEK341nxliNEUIpzXmsH/2zN2E47owVJly9TpmEw4RYWyLjNBBsSnQAwRa2vFkybQZSS7QG9M1lyZzmsy7XCwYGNKujbgl2B5EbJBL/CkU6Y8MMsinSMKpPjw1Rq7RDZB3QduGHvBf9rzgp8KgQHwPnYZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776946349; c=relaxed/simple; bh=SlQMI8IRV7H1W+0eRMmQQFi9awkSEWmQRb6390DKD64=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pSlCg0MDi/y3KGnWq+/8xnrszPzqds+/jrYDyrjPKf91xTZFxNbWEx9qznklLHKZ1OmPLIK7r5IOBugYfbJnlWmMSBMhGEVaVcMYqMgX0vFX+fQZ+CY0iABmSROy/B0oK1dasjla6cK5a6SVjomucA8EYuqVjK9Ar9+E5BrgVPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Gu/juZfg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eKPKLjKS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Gu/juZfg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eKPKLjKS" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63NBwdGF009834 for ; Thu, 23 Apr 2026 12:12:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JC0K8TJYemUka3ukcc1xuIUxIRphSxLm0aw3i2Lpe9o=; b=Gu/juZfg9DW6wQ53 LoOzGqs7uExgdk74DDKx0DAm8MIH/AvFpR4pJGYFQVSftrjkb3zcrNpQQMEY1ewy 6m/s0Q//ZkPD/yrsV2anqkQziSqAkqxnyc2BSAzsKB4IhkhM1r95Grx60Ue81jab xkimBeZww6MO/w1I5LWRpJPwiZwgdrRz00qH5ByedVFzlqejrmnN1mlVsOvmJ8Tg 4IQrvG1Bq+3yD0aUoYwQs+5kqastSVu2JpANt9quv27YZUV3TQ7fteIeW+k4qZwn eQdT4UYxo/1o8+hVuFuk2EXhz/mGSJfCOtp2ZvuZP0WEClhNmetrfswRVpQquHpJ gWLS3A== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqk1781h9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:12:25 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50e5a336b44so59686661cf.0 for ; Thu, 23 Apr 2026 05:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776946345; x=1777551145; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JC0K8TJYemUka3ukcc1xuIUxIRphSxLm0aw3i2Lpe9o=; b=eKPKLjKS0G225sMkO8X6eNW/Y4hIvKQLkE+kke6YqNuwXuJxpSm7In/i8iwfDbt3IF TLLkW7WcJcrN3pp3s4rde+p5fxbdCSZR/W4dhNrpbvdQLONlyJFdFnR7A98nunWCTfDT 6RofiYT9BC1aqZMv3/XQyGfqi/wmIC90WBIIId2VsH2gOBAwrVnxFz28INgDBvmnbrNj 96WobMTgaVs/FvGJbfnzL3tUu0VlcuaS0LcledWouHOoi35wlmqCbDmqU/Ls+IxVqcHw GE+eQwQj16/WmrDSd245/551bDVMKsvWWUkOayilYX/uANSzlQgbY9Qn0FHQKO+FYUW1 dHkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776946345; x=1777551145; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JC0K8TJYemUka3ukcc1xuIUxIRphSxLm0aw3i2Lpe9o=; b=SY+2Rl4AWz+3Kjx/+5/wmuGL+E6GZVlnAa+nHSJpT3Hsth6lpSpTmqIReP8rgJkWEl 8kpINk3VJNKa+oQGZTOUMJc/mkxcpz4bZRynIEtKz7Gs0FcJqTc11K3DjU2GEFPQyLu6 fmiuAxPZrGT9L/u/+yQbU9O0gv6ArB2OGiFoQjiSBsKesV8PE5WYHPZk4ONxMrjkvLAu gduJ6m/KljGcSFiXfs5MykN5mmt7NBpfin5aRqtofc+4ETIrV/qn4zfpZBGX0mPnC3IA 3JWj4/jWCjHQYUKXDpvnM3Zl4Zehx7o5wh8YX9Sv35b7mjcTQLP7n8U+idYuGcbpdICp ZNfw== X-Forwarded-Encrypted: i=1; AFNElJ9IC3GgHiJwKWfMoOddyGnoFMSaaIyoc8jQvcEQu01aXJen82rT/t/AZCI3ti/DG2ikN+vWKkYIe+XiKjs=@vger.kernel.org X-Gm-Message-State: AOJu0YycTRpVafbdCKYfsIvy37zDoM2/jHkWmAdgiAwkCWw0OW6mWcxW LbkoXBgyVVGyy1dG9FIn8HGl/jiTKNTtoyrgdiL4KgKAHNctVkUpEIZQBeQSIt7aPOKWDiAuqZS dQiDRqq3AEHVWWTQWVIVHMh72pqcy5UEl2w/nbBRAdYZiAEJGP4giBCiYTS22LQem374= X-Gm-Gg: AeBDietVoUDMcnPQYA1BCcwpuHRdlXtmMFZoXr4D4y8PrOYS9eGSw7PsM+cVla7RNRA TynAUHEnlWIrhp/6e81DJtOqqokLFdANBKRTURa3Y2W5U3kfsUy7b35NnWwijTXqQjAdPfKxdDt wanFMEP2G4Fd7zi6KvY9njzZ1T+FySH0rlYnE9X4wO3ELOeSOJcUZK+M40XAgLvyo2CKMukOWWp BE0E3hdouhKtCG1KMhVJhgBFCDTkL48CvqmS2lcur2Araxvqylh+Zrkv5fTPMBNTpPVttugJC5F sGfaAQvfyOZxJHC82aP/CSpenNN0fQEPx2lTSX0wiJvwL4XLeCTIxgquG3YtrNEGuiZTuJkrrPI RMRiKrFyIAb73eXvgbFFsxcUesWv/rweIcObcjJlsFUVl3rp1bcpgp1AguqwDNg== X-Received: by 2002:ac8:5f4d:0:b0:50f:6e68:d71a with SMTP id d75a77b69052e-50f6e68e71dmr189569131cf.28.1776946345093; Thu, 23 Apr 2026 05:12:25 -0700 (PDT) X-Received: by 2002:ac8:5f4d:0:b0:50f:6e68:d71a with SMTP id d75a77b69052e-50f6e68e71dmr189568441cf.28.1776946344662; Thu, 23 Apr 2026 05:12:24 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:843a:1e93:1fb7:5d86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a4b329542sm426273565e9.3.2026.04.23.05.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:12:23 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 23 Apr 2026 14:12:04 +0200 Subject: [PATCH v2 3/3] driver core: platform: tests: add test cases for correct swnode removal Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-swnode-remove-on-dev-unreg-v2-3-0e5213cde2ed@oss.qualcomm.com> References: <20260423-swnode-remove-on-dev-unreg-v2-0-0e5213cde2ed@oss.qualcomm.com> In-Reply-To: <20260423-swnode-remove-on-dev-unreg-v2-0-0e5213cde2ed@oss.qualcomm.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Torokhov , Brendan Higgins , David Gow , Rae Moar , Andy Shevchenko Cc: brgl@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4529; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=SlQMI8IRV7H1W+0eRMmQQFi9awkSEWmQRb6390DKD64=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBp6gyeqxuM5PCbhczHEbe4WKT5eqDgjzg6iDDXO 4wUQzoCmrKJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaeoMngAKCRAFnS7L/zaE w/rlD/wL0If/GvdO1tv7cFZZI8IjImnBBeu5lMLRndVe/71H/5EmyKWMbOhP3vISG/F0wJqdewG 9s1OateVJTbflrHbQ09U0ZfIF9AQMVJuXQF3/aGK0r2wGN1X2iFjNVoa9GND3t9h01lD7T4SkWS o9w30ommUJ0m0kC0Ub9RSBJv8AThLvzN8l5rXRmivTlg5yD4+rcFxZ2oQfQdxwybtfn5LmYOEw+ SdtHFykWabbT7TkD5/0oC5wJtcrbS0Ba3ybWHd/gMkym6f8Csr6+UcXcKRxVRLdlX3iNTTyzaTC /4qmSssPiLOAB9qCf96GA2rvw88ZEbsYAyfHXA3Yy5C341oixHJ0FN6ZFtiPYTXg9gxqVTOyLtf EVezTRz5BEWYEThJodsG6XApGKy0xYB/9cMxSSyMIK33i1jhVuRcCxPYcuEjrf73qgA/gO81+9/ 1reSEhFVPzghc4d5zI11tmRYyUdlaTF+w5rt0HgLAdiLaSpIN0VOrmWFaBHrACYZReLJCCPUxHW s2GRRQ1nqamD24o+62NwQaruMLKPiBvJHeqjfifQFFitkoGTX/p71vj/QeQsVJeNaJ/gBMJnFGp YjyyVbmyZWk5sXld6rMek9TGkX+aCl3R4mI+KUIzPM+lLocPrnrAPs3hR+I1y3JMIVZ4F4MSMhs XCcGSjzvHKedJYg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-GUID: aaEz_kpfn8ZCzwoQsQ6QqoV0BTGNTFnd X-Authority-Analysis: v=2.4 cv=R98z39RX c=1 sm=1 tr=0 ts=69ea0ca9 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=nEOnLqI-ckDzOwT8s0oA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDEyMSBTYWx0ZWRfX3eUWoWJ7/ybi b0d7w3HKM9oPaunJ+MjbWGXIta8kuQIB19zPQ9J/+kkFbYNUm/Uj+R76N4L6cpj4uekXEEirTJP TvsYz3zcq5HoBjsGiMEm3Y4R+7fGEBmJED8EUQC9BSc6IgzAPKRMh/N8HwIiLoDMjOJKqAaFw00 sIkQntuzHbeLP7AKKqLUxTyfuCQdKo3p13kWNB9Txg7afNYwNcOCsydrTnvXWSYlGV+3z3BBg0s kI1za8BbCVt6MByIgLc77KBlb7Euoau7+EHYZdUkjll3cae+eRW7LC4QTHSB/kAPRuUgMyI0Lia 4hS1JxUPp1S6Nxs+2rVzm8aNN6GfBAqeZLkxd+wdRYj/IVo9p8SxU2afbTDrkJ8sOm9kxFoh2F6 z+uKi3yy0Y8BfpWfbdqypYi2ma9xljNwiotEwH58lmN/9J92MZL+a0C+EYs+36AGYlJqU2ciURY nH3E2i6os2ZWRMBsSmg== X-Proofpoint-ORIG-GUID: aaEz_kpfn8ZCzwoQsQ6QqoV0BTGNTFnd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 phishscore=0 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230121 Extend the kunit module for platform devices with test cases verifying that the same software node can be added to platform devices repeatedly. Signed-off-by: Bartosz Golaszewski --- drivers/base/test/platform-device-test.c | 106 +++++++++++++++++++++++++++++++ 1 file changed, 106 insertions(+) diff --git a/drivers/base/test/platform-device-test.c b/drivers/base/test/platform-device-test.c index 6355a2231b741791b54eb78af42e13f31f745184..4b23f0d7f88548c62c49801fcee0919915e6e153 100644 --- a/drivers/base/test/platform-device-test.c +++ b/drivers/base/test/platform-device-test.c @@ -1,12 +1,15 @@ // SPDX-License-Identifier: GPL-2.0 +#include #include #include #include #include +#include #include #include +#include #define DEVICE_NAME "test" @@ -253,9 +256,112 @@ static struct kunit_suite platform_device_match_test_suite = { .test_cases = platform_device_match_tests, }; +static int platform_device_swnode_test_probe(struct platform_device *pdev) +{ + return 0; +} + +static struct platform_driver platform_swnode_test_driver = { + .probe = platform_device_swnode_test_probe, + .driver = { + .name = DEVICE_NAME, + }, +}; + +static const struct software_node platform_device_test_swnode = { }; + +/* + * Check that reusing a software node works correctly. If the call to + * platform_device_register_full() fails after adding the secondary firmware + * node, the software node must be unregistered in the device's release() + * callback or the subsequent call to platform_device_register_full() will fail + * with -EBUSY due to the software node aleady having been registered. + */ +static void platform_device_swnode_add_twice(struct kunit *test) +{ + struct platform_device_info pdevinfo; + struct platform_device *pdev; + struct fwnode_handle fwnode; + int ret; + + ret = kunit_platform_driver_register(test, &platform_swnode_test_driver); + KUNIT_ASSERT_EQ(test, ret, 0); + + fwnode_init(&fwnode, NULL); + pdevinfo = (struct platform_device_info){ + .name = DEVICE_NAME, + .id = PLATFORM_DEVID_NONE, + .fwnode = &fwnode, + .swnode = &platform_device_test_swnode, + }; + + pdev = platform_device_register_full(&pdevinfo); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + wait_for_device_probe(); + KUNIT_ASSERT_TRUE(test, device_is_bound(&pdev->dev)); + + platform_device_unregister(pdev); + + pdev = platform_device_register_full(&pdevinfo); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + wait_for_device_probe(); + KUNIT_ASSERT_TRUE(test, device_is_bound(&pdev->dev)); + + platform_device_unregister(pdev); +} + +/* + * Check that passing a software node as the primary firmware node of the + * platform device does not result in it being unregistered by the call to + * device_remove_software_node() in its release path. + */ +static void platform_device_swnode_as_primary(struct kunit *test) +{ + struct platform_device_info pdevinfo; + struct platform_device *pdev; + struct fwnode_handle *fwnode; + int ret; + + ret = kunit_platform_driver_register(test, &platform_swnode_test_driver); + KUNIT_ASSERT_EQ(test, ret, 0); + + fwnode = kunit_software_node_register(test, &platform_device_test_swnode); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, fwnode); + + pdevinfo = (struct platform_device_info){ + .name = DEVICE_NAME, + .id = PLATFORM_DEVID_NONE, + .fwnode = fwnode, + }; + + pdev = platform_device_register_full(&pdevinfo); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + wait_for_device_probe(); + KUNIT_ASSERT_TRUE(test, device_is_bound(&pdev->dev)); + + platform_device_unregister(pdev); + + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, software_node_fwnode(&platform_device_test_swnode)); +} + +static struct kunit_case platform_device_swnode_tests[] = { + KUNIT_CASE(platform_device_swnode_add_twice), + KUNIT_CASE(platform_device_swnode_as_primary), + {} +}; + +static struct kunit_suite platform_device_swnode_test_suite = { + .name = "platform-device-swnode", + .test_cases = platform_device_swnode_tests, +}; + kunit_test_suites( &platform_device_devm_test_suite, &platform_device_match_test_suite, + &platform_device_swnode_test_suite, ); MODULE_DESCRIPTION("Test module for platform devices"); -- 2.47.3