From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84BAC3246E8 for ; Thu, 23 Apr 2026 14:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776954111; cv=none; b=A1ZHWdQyUTPuYwUOVvv0GLpPtoaw6Yjp3qeEfJKzoVV7x3NbeMxT2TQaXM8obKVaxyC2oojB6ZfUyjjccap7YKmBKg7LBpsODRlspLxqONlG+WdeEqSc9ruxX+kLIMP//NaQthM8eiqXAiFUzWflZYdTNE7QjnuyuKpkbtM3nTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776954111; c=relaxed/simple; bh=qsLARDIVnkaD/ICi7soozFniWWJmCvAqHDdDTOWdWNc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Pe+IZUkEzvTe39+6jYKri5bakfpav1Dbi75PW/7u4CaI3h2oGlDzqjNUKitLpvDuiy15Ypr6zgp6F7mxGteBT/ZrEkT7S/CPQaBFtnRansQ4nJCjofxl9IS9K61LfC4A7DtbEvfVNPR00ju3m57YS/IaiFTmDTFo+4Mw5lE3ShQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=SH8WWtfx; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SH8WWtfx" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 977AC9A4; Thu, 23 Apr 2026 16:20:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1776954007; bh=qsLARDIVnkaD/ICi7soozFniWWJmCvAqHDdDTOWdWNc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=SH8WWtfxYgJIOmCBHZeDq6CKA0QNMeHsHVHtaHNioucGtgF0nYR5PPIpyu8C5Cq7n g1YlCQdjAVEQE938F8lzysjjjDpyTnswPOu5CLw9utjvBC1HIBevkCJ8Dax0JWRI/2 fdjio/tr30Th1oB3e6tVLpFU1IYC6+MR1v0HkHto= From: Tomi Valkeinen Date: Thu, 23 Apr 2026 17:21:12 +0300 Subject: [PATCH v10 01/11] drm/fourcc: Add warning for bad bpp Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-xilinx-formats-v10-1-c690c2b8ea89@ideasonboard.com> References: <20260423-xilinx-formats-v10-0-c690c2b8ea89@ideasonboard.com> In-Reply-To: <20260423-xilinx-formats-v10-0-c690c2b8ea89@ideasonboard.com> To: Vishal Sagar , Anatoliy Klymenko , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Laurent Pinchart , Michal Simek , Simon Ser Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dmitry Baryshkov , Pekka Paalanen , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1792; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=qsLARDIVnkaD/ICi7soozFniWWJmCvAqHDdDTOWdWNc=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBp6ir02WndvzaoJu9fVHl03maWhZDEGbC6j3mLR QkhABJgBzeJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCaeoq9AAKCRD6PaqMvJYe 9SIgD/9Pd6FQKFMsX4tEdU/iPPznMxPeNc3lJQSCoeDlE2x6iS5F4CbFvjewkCTmfG2ncFxMOld K5GGNDl9aJOEGsHZ+n1jroBIFV/l7DBcQ+aPlmIrn1AfPRH85DpwH3v0iurNIexBocnCG2/J/yp sq1TPgoBZDY6BbzO5fSMhLtw7eJyqXnjHVCb2BB5xz4QgYCiWenJn8JTMl2ST2/CsLTRoBQfIBY hE4c7V9wUYeZP9lppLqk3Bb94RpBrZDQsXtPjA3WAbEmG/Ed0G/iMa4acEWK5BG0kMbqLjogp2i OQ4M8Y9w96PHcLN9cepSOJZCvk6AaCRYvcWCKInKUST0c+nSn6YhqAXMJXJtCwkC/tjWBRhXbkn DcKuCWvVxl1W6KAB+VMoyi6FZEfoCLFHxqpWSNvMcePmLovecJi7/Tpe3G5cnymiMyCJRCpvN5x 0BMI/1avkmPRYnFgXk3J6VA0fH7LHqHY/psSEGdAFR6btXL0cA41dxHEHUyD51VZTHhXE4UUISu PcHofQTqI2AyGpwANXqORqUD/6Uc0z2+wCXmNfNGk2iYZhuOZmOqJmMiOeczg0asJk0rfSzzyyh 1jaK633LPo4DWfu6UYKrPyWevm539oH81rcoUZHE35Yp91Ml6ODzvZeBoUUCF/ISrAMZzNRBtwc Ka50JNd1GuzanLg== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 drm_format_info_bpp() cannot be used for formats which do not have an integer bits-per-pixel in a pixel block. E.g. DRM_FORMAT_P030's plane 0 has three 10-bit pixels (Y components), and two padding bits, in a 4 byte block. That is 10.666... bits per pixel when considering the whole 4 byte block, which is what drm_format_info_bpp() does. Thus a driver that supports such formats cannot use drm_format_info_bpp(), It is a driver bug if this happens, but so handle wrong calls by printing a warning and returning 0. Reviewed-by: Laurent Pinchart Reviewed-by: Dmitry Baryshkov Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/drm_fourcc.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index e0d533611040..e662aea9d105 100644 --- a/drivers/gpu/drm/drm_fourcc.c +++ b/drivers/gpu/drm/drm_fourcc.c @@ -491,12 +491,20 @@ EXPORT_SYMBOL(drm_format_info_block_height); */ unsigned int drm_format_info_bpp(const struct drm_format_info *info, int plane) { + unsigned int block_size; + if (!info || plane < 0 || plane >= info->num_planes) return 0; - return info->char_per_block[plane] * 8 / - (drm_format_info_block_width(info, plane) * - drm_format_info_block_height(info, plane)); + block_size = drm_format_info_block_width(info, plane) * + drm_format_info_block_height(info, plane); + + if (info->char_per_block[plane] * 8 % block_size) { + pr_warn("unable to return an integer bpp\n"); + return 0; + } + + return info->char_per_block[plane] * 8 / block_size; } EXPORT_SYMBOL(drm_format_info_bpp); -- 2.43.0