From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 332F6345CBC for ; Thu, 23 Apr 2026 14:21:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776954120; cv=none; b=PX5jc/NxcaHv4ZMJBGSElK65jGKNVBxxKJNam3niY14sgnX/ESMc3PFuRsGDEk2jgT4EWAmkGoJ9KipuD9Fcsc6x3eDcj5mNUhedvIagQD+g7jSpq7B6fbr3ei+AppA+wmuwHgl28dC2MWqrHcXyG9kJeLgca4EEdcbPNRldPSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776954120; c=relaxed/simple; bh=NA2QDN5jXl9bgNq49LlPIxLS7U2YaS5SkWzlnqoNa9Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lLmFVW63fNBckS1PzfB6I5aDi3I6/33sPm84Aytpdc6s/f55nIqAT1wUL+9SO/OUbgYPcZ9WeCeHgSGhhizBsRP1WW8kdRNzM/r9CcCO3s49ZNWJOW7ST4ijyHXlQwROf1r7eRpLADtU2/30ZB1f1yfhIcsi/yJlobufiRtA9Qk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=PIjNMMNR; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="PIjNMMNR" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A0541A6F; Thu, 23 Apr 2026 16:20:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1776954013; bh=NA2QDN5jXl9bgNq49LlPIxLS7U2YaS5SkWzlnqoNa9Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=PIjNMMNRTOozk3d/U0gLAyGnlMKF0NwdXSWfvYi6uefn5lBQD0GxB/SKIsI71QsHX 8+uJli8C7efQ8o9VTa18kKgFEIGyiJorXDiMQLqFP9reHMb6UpHJJ94ph+6m3R9LXh EXkNWIR9UPtDAGrWn5NjOhyrEy8ZiMkRfyNOctvk= From: Tomi Valkeinen Date: Thu, 23 Apr 2026 17:21:18 +0300 Subject: [PATCH v10 07/11] drm: xlnx: zynqmp: Use drm helpers when calculating buffer sizes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-xilinx-formats-v10-7-c690c2b8ea89@ideasonboard.com> References: <20260423-xilinx-formats-v10-0-c690c2b8ea89@ideasonboard.com> In-Reply-To: <20260423-xilinx-formats-v10-0-c690c2b8ea89@ideasonboard.com> To: Vishal Sagar , Anatoliy Klymenko , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Laurent Pinchart , Michal Simek , Simon Ser Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dmitry Baryshkov , Pekka Paalanen , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1623; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=NA2QDN5jXl9bgNq49LlPIxLS7U2YaS5SkWzlnqoNa9Q=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBp6ir2Bj4g+ZrNt+tR1DhVZEp8C86S4jspsDJ77 mZJ9XIjkHuJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCaeoq9gAKCRD6PaqMvJYe 9eJtD/9BrYhqLbquyN32D+rl7G20Xi9EQM7/tEfxj5txC0geZEbtIalNEttMYZmfSBM2H4FDQfo MqmsE4kU7lTuYACISvmBflo+X6BlF7ooO5KFE2/OAJbS+5qyJPuD0deFk7aZcKCgb7PNPHRCTlZ fIsrt4huhy4e/JTO4z3rClxb2DTZ5ogrggVyPGjOhl6LO80GPiNegLtlHmyBg31nAXsJW1KQDUK iLUmcBp/un6jzR21+l+h9tEdi85RkpU/vGpvpqzhQwQxadpxrhGK9H5RP0lBX79kd84bqFC9b2j KtgtUwgsoQwc2qD2oQMjvg5f7fAfz++1oY23tty/9MerqQ1RJ3OX0wZJiSDfvhQXd6Wkuu8i9rt /VvjT7Ll3KE6v+T9mhN7fUSdmllB0U7VNQLDrw/V5IFbREo1NxsEISwAimqLtKulxStWvyuTUSV o1bQCFSlso1DybscdinGVX3hKHnLttnqntydxokVg8BtKi1zllhN82wyIHTBqSf7rLqT8HMNmey UMVobKoHnoGQcdyjIIFZdJdVqvIuxh0yNaYZUa2TtM3ocdWh94cbSAwe9epYIkroAQdkhB/9jo/ /8m7I5+j6D3kbqq5zmB+/dXZJLY8bGJQuOsg9yt02hHbwzK1mNEq0utIliOrxXkqkd2odE0iyGW MfiuFVHykXjV7Tw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 Use drm helpers, drm_format_info_plane_width(), drm_format_info_plane_height() and drm_format_info_min_pitch() to calculate sizes for the DMA. This cleans up the code, but also makes it possible to support more complex formats (like P030, P230). Reviewed-by: Laurent Pinchart Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c index 9a8f38230cb4..12a8d643915f 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c @@ -1116,16 +1116,19 @@ int zynqmp_disp_layer_update(struct zynqmp_disp_layer *layer, return 0; for (i = 0; i < info->num_planes; i++) { - unsigned int width = state->crtc_w / (i ? info->hsub : 1); - unsigned int height = state->crtc_h / (i ? info->vsub : 1); struct zynqmp_disp_layer_dma *dma = &layer->dmas[i]; struct dma_async_tx_descriptor *desc; dma_addr_t dma_addr; + unsigned int width; + unsigned int height; + + width = drm_format_info_plane_width(info, state->crtc_w, i); + height = drm_format_info_plane_height(info, state->crtc_h, i); dma_addr = drm_fb_dma_get_gem_addr(state->fb, state, i); dma->xt.numf = height; - dma->sgl.size = width * info->cpp[i]; + dma->sgl.size = drm_format_info_min_pitch(info, i, width); dma->sgl.icg = state->fb->pitches[i] - dma->sgl.size; dma->xt.src_start = dma_addr; dma->xt.frame_size = 1; -- 2.43.0