From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCD22377000 for ; Fri, 24 Apr 2026 13:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777036842; cv=none; b=CBYwKxkpV7GtdmAPt/AmvAd7VXmXpesIec+SCeNH6yR5reednQTiQbVHY2B0NLN+9oWO68vP1/aIR2DjdQFWSdpNUMGGTS/1eaE86y/zXPoKvcfNKY/U+gaAqgVC3jvcNpu09gjHzv/ctBGgrr5hbq8YbwOeRz/2L52D7L4peug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777036842; c=relaxed/simple; bh=hI2kWju01nADLqFMJx9+zsjSyPqnYmLXRg4ttLuRm0I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DE78ez04g/eYpoCISUvwu/vqjLKM4FHwGLlHEcRgXsdm/SDSP+u5FNQ3gJNHvGGPdWwFoBQzl9WKUNpiiqR96/Pya/x3xpOuUUjSZOj8vfPGgA1ld1LytQl6nkyDLtq5rjvDTEEzeREns2h9DcRURMH8Xkx+1YuE/J0H5nr1qwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eo3ms7r1; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eo3ms7r1" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-358ed696623so3589877a91.0 for ; Fri, 24 Apr 2026 06:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777036840; x=1777641640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hI2kWju01nADLqFMJx9+zsjSyPqnYmLXRg4ttLuRm0I=; b=eo3ms7r1v7F9DP1/ZILuD1LM9slXHi93NQGea/EsI+nN9KPNPnH1nESg1TmH2vOprW 1yCc+v9tsAA9Cb09OTs+12rTY5klkzwZ6s9W2EWtUPp38N0LttCt4h7NUhPmAdyD5AEg HWq8djiJD5sdt+akEONlVRmPw71CV+Jc0NJbDJ4pgK6QxECrqeRxuggrB08vC9dGQsWf DCr9IBYIL7nDcL3uiHJAlBtYnj5kr6XWUA0f3EtygMixRryg+o6yhDi6fX09K2MNfB0a kdP1Q8IhWlbJQH+U+xamB8l98eqiI0CYP7lbO9ozS7yWLsBnyfZTq/A+ipPUDQu+dIXo fgbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777036840; x=1777641640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hI2kWju01nADLqFMJx9+zsjSyPqnYmLXRg4ttLuRm0I=; b=W67yU3eti01Qe6uDslFu2RttnZcmady8Vl5FYpcTSLkHPfjzsQxAubPHI0Wt/Ne5bH IBdymqXKPnXaGRRWpM/v5syXF7bpzNtt4spAvMOTqDJbErKrHGf8HY3c6VAD3vawcH+k uhMtCj/uSA75rV/hycIL/ATP3QNMirm1qGwoQfaqhopp3hKHxY+3x3OIJumgQN/uEF6G lqbBwOoxsQtx6mOkA0bqG1QlD3x7FwkQuvDu0+nLYldyXnKL2fTHZ1ldb6Id85aZMptp +UgsJD+5exlH9cVhBLOOaPbsLP/qD/EFQc5Qda2iHBm7BoUuEgqvxZPK4G7X6v+FHKTj D2Ew== X-Forwarded-Encrypted: i=1; AFNElJ/oRAB/1Nf8XE/umXOnmQZUqVievOqOujHMov6SN8SCtZoo2Muhro19Gt166hV3bDjZlSoYrto2bVV8OAQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxGauA4YX5L2alrq6Ho5zJxq2qKZzNwX/eNshs09nre+LoGKvBj /aFoiTs4GCvtPLZeJ8onaIF5J2Mcbe1Z4NoGYf48rB7HrNGQLTi+79/lGPT50A== X-Gm-Gg: AeBDietSrzk03Gar6oppyRER8yKDARH07CXtYsty29yx7eJ6QUxYH/TnVc0KkOn3HzF mUKsgvqcj+cvDqTxcfETYS6M1+ztp4UJt+9IRbS9QDCoJA1rM2Jz8qeEhbfT/ODgKypAAsTGS/6 /ILerOpM4/YeaYhDsypmVlPYcaWMPiO+G1y++Hk1IF7K1CnGxyg+YSNMywperi9IoZdeKO1sIiJ QYaAMDXAAe/u4of+SSXaRTm1Uf8q6I6eqx/jkR47ckza3n7VJbY2OKU8H2N2R9FJ8RRXu6adMnn VbVkztpORgrie7akJlhUNfhvqQuKwprabXOGVK+yRjcGCjeDfO62r87NKJAP2Z5lrR7OpDTAR8P LaA06E11CNaN7cOPvuGjdTDx3FXAoQD5Sr6eSDe2JK8ZayEJCNqluc20JgAeOwYRQTNtIm4reBb ZXBnpgft4syifngJjRcEo/6utPZuw1q3ul7YQaIbu/UmAQS+f41lvQ2SVgxA== X-Received: by 2002:a17:90b:2785:b0:35b:e4d8:e21d with SMTP id 98e67ed59e1d1-361403bda05mr32688471a91.2.1777036839996; Fri, 24 Apr 2026 06:20:39 -0700 (PDT) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.246]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3613fb4b4b5sm12663689a91.3.2026.04.24.06.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 06:20:39 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: David Laight Cc: Konstantin Komarov , linux-kernel@vger.kernel.org, Zhan Xusheng Subject: Re: [PATCH] fs/ntfs3: reject evcn == U64_MAX in mi_enum_attr() Date: Fri, 24 Apr 2026 21:20:31 +0800 Message-ID: <20260424132031.299385-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260424102024.74d20552@pumpkin> References: <20260424102024.74d20552@pumpkin> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi David, That would reject the svcn == evcn case, which represents a single-cluster extent (e.g. svcn=0, evcn=0) and is currently treated as valid. The original check allows svcn == evcn + 1 (empty range), so the condition is strictly "greater than", not "greater than or equal". The issue here is the overflow of (evcn + 1) when evcn == U64_MAX, which turns the check into "svcn > 0" and incorrectly allows svcn == 0. My patch preserves the existing semantics and only adds the missing U64_MAX guard. Thanks, Zhan Xusheng