From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32CFB26C385 for ; Fri, 24 Apr 2026 15:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777043513; cv=none; b=KD+DfBQJYjcG614WNLDQTGG74aDlkoj7IZTJq3WOy0poybQaN6WTGyzm0wkqFYNc3zKdI64iBU1CSuDUPHq9KxUTRA/iM+MJSDUm24tfXI7GJA9EeFpDbg3OxilghU6PVwjLqrMMohM2c/1JEYwJZf9Og+m1zjLojbPpQSXFG+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777043513; c=relaxed/simple; bh=RMCacskoFmZ9/Ng6hAjRi+I45M638ggU0L3+USVXwaM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sakKu/mgnXhgPdEKeBnSH5dXuaoZlk1tX/QbmR0FDQtJoD2VRYbTR5NjB6Yko7HeX/tBFxqPRZnfpiK4fsEwtScjLMCIKNioE6k0kYljdgi226Z/I3bOvbLrk6WQxcVhvc8oV39GosMuEINFLZg6UL4B7vslXoyv58WHl/fgr/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gPgu5Hdw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EwEArBRq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gPgu5Hdw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EwEArBRq" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63OAeSR31959571 for ; Fri, 24 Apr 2026 15:11:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=lcPhu9r6gLN Un/M0FOO+8vu6c2tQ6RhDeBZbp1avftg=; b=gPgu5HdwyKtcYYBAr726GWrr65T FSrHH2sMTX9yA6xeW18FV+hz+y3yvdmRgAO/0D9HC4X0JDvcwKSeTtzkVBNdMF+u Xul+dd6YUjOZpzee2xookpDRdKlQpjoOBOp4qt62sCyp0tXEjDsLNyphU8p9r6fV qSgwCdYsn/emo2yobQTl46FRbKL3k/+1ftc4jLP6PieXmhM8+KGyfRisbRqbEMrG Wr6EvLE3XvoXkQlrczTX5uUnUDEVJGAjs0bWLWtCNdYB1ocZbrIHuTcPtiSLSfgH 3TLAfuAcrq2CpGbwsQtCDGFQz+llD9WBffsHUd8iqsefSDTo9AfEiqSiMdw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dr2nrjcqa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Apr 2026 15:11:51 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b79f4b35b7so20233685ad.0 for ; Fri, 24 Apr 2026 08:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777043511; x=1777648311; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lcPhu9r6gLNUn/M0FOO+8vu6c2tQ6RhDeBZbp1avftg=; b=EwEArBRqwbx28JSlE3/amzKiYdmKbCwYDWuLMLfT/19zP6D1uh8qBDYQFhcHbiE10t rGujB91vtq6XQQgQqNXXmg0KI/5/AjEiUlrxYJFY7mTpRxvv0IPk05mv0DDJrMVH0hU1 uygvy4fcpuzwmlfTqqFKYUMl5kZJpAODYCeJodPBk5kRbIODatUr6IbzjNHRG86aOoFg NAPMsu2BFBee009VYA+v0epMAI5md3DJ9lX2AybRsbLqLR3t0Ny/7VaN03AQhECkJEdG zqd6xDGjZ90oJquXSmj8FPyXcuoZwXTRykNRqExXCbqdRBBTRHVTe4WwHM9eaWBzAfQX 6uCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777043511; x=1777648311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lcPhu9r6gLNUn/M0FOO+8vu6c2tQ6RhDeBZbp1avftg=; b=XMZr/4bNoeDNQuKh49DnADUaURHpSmPninfi1nkK7SQDGWo52bJV9ZiolIzxmKrFtA TPGcAOoJLh45krOm3Fpk76QTkJKeug0m2eDin4OSOuQYKuEvFyPiTYnVctFhIW1ZTwwj Sw73WL15lOTKcunyy1cipXeDCKuMivJaP6R6fZV7HTYP2/jJbSp0+T/aDEtL9YsFF7xX D6CaatiB8FxwbimaryzywYKof9fwGew0g4NNbs9Hj5YjnjA2TFM1i4qN8Fiu/ITc7RPh hsc/3vRoW8E6XYQ2VeM+IJx3drIar5Zgn8+hFDVJmiY/gdfSM2UWjjb5Vvek2lzBkfBr mKyw== X-Forwarded-Encrypted: i=1; AFNElJ8Fj2gzmhOzzG04ima7m64fJPkz+1kmtmwYNUi0+T3g2OLvxr/o7rdJxcfBhFLwGaaQBhkIj6J+CL5+wHA=@vger.kernel.org X-Gm-Message-State: AOJu0YypQxaD7S02gX3ltSCRcZS0oS62LPUOoGHi1aZumm5LBebYuSbB G5kVTZ2fEulRegAFV0jWUJUXfGa2bktt88HtiqZcnq8YQCvlZ7Id73kDsMEBOm80r8L2DkTikm1 Xzdnq8T5qN+P3aKzOZjuZ5xO01r/zhIPUAKloQzmVdg6q+nkAZGODxHJWEIe//wHcsOA= X-Gm-Gg: AeBDiesR1Bw/xAH5uZObETQYjP7IaTPfZ0IOGJLAC6/R2ri+9N6Bl+bhY9bUSw9F3cy HufPBK3U/DaitqUJ++6H7FJrV16gNN/XJIISxp6IRjfs00Twf0Sq7Xfzd7oaNmVU5XjEJTUcXhn aLr+pvKPCfv6RFDgZc5DwNNYOURZ0INvF9lwbV4uCqy0GyGxiVOTxTAAzZ95hNSKgGtmBPwe3GK 3+7wJv90nMSA3/XYsc7N9YYJ1kJz5i12lOVBeNMuQNoT+qsIJUjfliy2tXIC4SM6jG0TFqjsBKl y2ZA8f7mKdDa0Os8N9+LuXUZ2pMdcSdLD0GlVnTrbbkya2wbTXiRJl6tmdAHS3PBVbIbX949dqG XoWsdYy0dcYeuLnKVlW4Ju8jsWG7G4CK/ackHvzH1QpY= X-Received: by 2002:a17:902:bd8c:b0:2b2:50f6:cdd9 with SMTP id d9443c01a7336-2b5f9ecb818mr216666915ad.8.1777043510603; Fri, 24 Apr 2026 08:11:50 -0700 (PDT) X-Received: by 2002:a17:902:bd8c:b0:2b2:50f6:cdd9 with SMTP id d9443c01a7336-2b5f9ecb818mr216666745ad.8.1777043510082; Fri, 24 Apr 2026 08:11:50 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0caa9sm225689865ad.40.2026.04.24.08.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 08:11:49 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Date: Fri, 24 Apr 2026 08:10:37 -0700 Message-ID: <20260424151140.104093-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424151140.104093-1-robin.clark@oss.qualcomm.com> References: <20260424151140.104093-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI0MDE0NyBTYWx0ZWRfXyQaN3tJTTssP 92FG2alL4rzISsWbjKbxuy4kQz60JiAcCDhy23xDLXKQcSLFewHLH4GSE7ekZ3a89yYizQTJVk6 JNOI4CK06QcK02VjqQw7YgA4JCbROh3b3Vh4+hJHDxlBl8FE4OKP+J0x9lLmU4a6zsFEKXFComQ 0X94mE3hwO4RlKLdlZWxT+V7hh3PxRleltCEKKWuDp3GecnwcPGIMvjqzQUk30rGQOQ80+4UUIF +hapwXsVe5rk6aCIPyWVBAUzrFXh1AMlHphPI0vS9tvMfS3FiPm29YOag0flW6XpgG8zlHpFY+K k3i8vCLic1NNxl68kK4CHDhAmw8RKckeZWmH/1G0aHw+2LuB1mKbSL8l7RERUH/Rh1E4QyU/fob tdtzy8D7xI7zY2nrmeS+7OflyTLRyloxfENhk4uo/qGazk+Nc3QELvhjpT5MJFyWKZ3lQwFN50g yaU905b2DzTxUo3Z5HA== X-Authority-Analysis: v=2.4 cv=UqpT8ewB c=1 sm=1 tr=0 ts=69eb8837 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=ZRXlmS4ShPoOlOK7p90A:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: Dipct_fFtA4JTgxhDNK4yRZ44bJvlvlO X-Proofpoint-GUID: Dipct_fFtA4JTgxhDNK4yRZ44bJvlvlO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-24_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240147 Use perfmon_capable() which checks both CAP_SYS_ADMIN and CAP_PERFMON. This matches what i915 and xe do, and seems more appropriate. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 66f80f2d12f9..72b71e9e44f0 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -494,7 +494,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return 0; } case MSM_PARAM_SYSPROF: - if (!capable(CAP_SYS_ADMIN)) + if (!perfmon_capable()) return UERR(EPERM, drm, "invalid permissions"); return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: -- 2.53.0