From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32ADB238D27 for ; Sat, 25 Apr 2026 21:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777151087; cv=none; b=q5ms5dVkqmZ3fwfo8sPnU18m6ShM+Q0vsSjVKWAPfAvAXuLezeD2Ff3F+YwkUSHzoXOhokp3CsiP5BUDmN9mc1CM8HGGZ/3RHt7nPO+NnOWv/iJgDSyMo1HbR+BFB0vXaSTHMt8PxuC08cLeliqWHl00NMVhgVR7NYzTUEKdO1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777151087; c=relaxed/simple; bh=ve6CgzqBQQMz4Ha6RMOg8/H5yEbwriSnmgV728dVJs4=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=oaytSjWW/ggMP8y5D/ThFppEg4pNKHpTWC6a8ZJEcIcCYIOZfS+EhQeGKCL55EIRvaAvLdsfvic9x477o7AkHOyhT9QZoc2+q9mJ6UHd7VGoNP1QKlR7ImgsIKjQOveXKlG76DGVdwdTEuDbVrT89sao5C4ISyE0lHvxoaS76Ic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=DNOwtKwo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="DNOwtKwo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 618BDC2BCB0; Sat, 25 Apr 2026 21:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1777151086; bh=ve6CgzqBQQMz4Ha6RMOg8/H5yEbwriSnmgV728dVJs4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DNOwtKwo1mgKh8MR3NGdt8e8NmcYb5J4s16oMWSUwpVyuPahMZjwXmB3E8gLyURqB 34AaOktg9xvjfInuQdgQuFDUEFvxLW6XvNjJBK1HTxtlw588T8+m7WUWV9dg9m8yDf BkWmZDdNnswtxrDYkyG2O+RTyD5qO3kg161Zn8Ec= Date: Sat, 25 Apr 2026 14:04:45 -0700 From: Andrew Morton To: Haifeng Xu Cc: david@fromorbit.com, roman.gushchin@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, muchun.song@linux.dev, usama.arif@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 0/4] record non-slab shrinkers for non-root memcgs when kmem is disabled Message-Id: <20260425140445.14ab61224955c88d359dd6f7@linux-foundation.org> In-Reply-To: <20260311030235.240953-1-haifeng.xu@shopee.com> References: <20260311030235.240953-1-haifeng.xu@shopee.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 11 Mar 2026 11:02:31 +0800 Haifeng Xu wrote: > When registering new shrinkers, all memcgs need to expand shrinker info > if new allocated id exceeds shrinker_nr_max. But if kmem is disabled, > only non-slab shrinkers is useful in memcg slab shrink. So in this case, > it is enough to allocate non-slab shrinker info for non-root memcg. This > can save a bit of memory and reduce the holding time of shrinker lock. Are you able to estimate how much memory it will save? > With this optimization, the finish time of pod creation in our internal > test is reduced from 150 seconds to 69 seconds. We test it based on > stable kernel 6.6.102. Is that internal test some crazy thing or is it representative of a real-world workload? IOW, what I'd like to see in your [0/N] is some indication of how much time and memory we can expect real-world Linux users to see in real-world workloads. So please have a think about that, add some words then resend the patchset. Thanks.