From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B33035A927 for ; Sun, 26 Apr 2026 13:33:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777210424; cv=none; b=PQof7vaUIHJJZyKyFWgZi0vFVIt5LVo74yEMeQ901ikK+S/Rdby5r2pHRBOyWqEHqrBYPRQY3E6ezUqGkfuo1k9XnMrjQr1H1XRkPds01GeRz+KPsprCp//dNT2SXEDLVw13rgSMAkHMEOer7pxAb7hmqFDh4bRTftx5IYxqfZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777210424; c=relaxed/simple; bh=GeEu6AP7RSVpatJkLiv/ocVI/gdxJEDtevb36X7eCX0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iVjFtG6dNnqgf7j81zZUg7XMRoBziQQxCuJR/L+BKfeB7QHPpv6fhBO9mny+taYtr9bRSiWJ/IcGdgGtbOObCGZIS0N16xzExGbbPwRryzFwDIm6dSupZrSfSD8zbf29tCXFUlkYym+zZQQCPduIz2cWlhnwF4VC2ttfaH1hxTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DwcdcPEg; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DwcdcPEg" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4896c22fcbaso65680395e9.0 for ; Sun, 26 Apr 2026 06:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777210421; x=1777815221; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=crKkancr7sR8go7iy0R0NBV97WuE5NeC5bAHOLt78ko=; b=DwcdcPEgpAPEat812nfkIDJZEuidRhXrYnzWKT6W/iWrOpuqT1lcntLPAZsyaxdUJy ABiuXvv9EGdR0kzT9ptSd6+j2JTBgZh8/E2YGujIk6Sz99vZQQeDL9TV9w9+3TOAM5GW WDX3ZoSZNpoXa+FKhOpDtuSAWTkrw4Cy8bpBGxe+K2tXsl9mif28GEBG/Zg5cjfzdiq8 ranPFvUFZQ98yOZjfcw55xYa4jSGqmM2cjFCcDCrCMHIVdVJ/WmscDjvDBu0SmjUIjjK cEtbfG2oyJApy3HYO81grDcZrJC7mGonDmWiilc2uto5+CLnDcejsAoc4YXWXOluwgdM 0+kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777210421; x=1777815221; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=crKkancr7sR8go7iy0R0NBV97WuE5NeC5bAHOLt78ko=; b=c5o1rz9+hvnNSbvg91izp50wpL9qpCK72GaIzKwYB5Q1BSSvNoGUT8wdoID2IZkEeR kM7WNOChnjbJX7sKSmUeaEknWAx/QEUN97wrvDA92hgwId/iuoijPCm/uV2g4fvdM1u1 fe9dEpStrMx+p7KbdeBHtSduqfGqTHsOXX+Bex9IkFTvIRL17mfc3d2+T+tvIs4ww6oe SPK1YBInTyNssgJyoB67g1xrxTms1G+WGBr8VsUXqXQFX9LqrrGPi/+J0wyxyKgjHeh5 WDhfNpUfVrdRRwRug3LopFchFZn/uK43Ah2ZCFOQ0kgFlFhg+QJ3UIaoJqaOlRU4Apfs /Jgg== X-Forwarded-Encrypted: i=1; AFNElJ/LQgYp4VsmSUNHqGyPbclKTKX+QtCY829qWuxAfGgGD/yNMxQf0iRHCLn2UabaJWy3jvoqsJuaCRYNYJs=@vger.kernel.org X-Gm-Message-State: AOJu0YzE30otCVWl0Itz7i7GiI9EGRG2hAhnoO/UqVeoOcSp/npPhq3h QyqVHzinfUY4Nn3aHnmAhb2AfC67Uq93pw9LtWW94klbqNhSxOZmoKPX X-Gm-Gg: AeBDies6iW6UTDbp6EpK0aPr4NrDTaIJJJtIElYffF+5NJeXibrMuRh6mV/7S2LCJ9N rsZkjYUbVt6nDwaYAWaus79TPL/o/UtGHN4nzawpji6YKSKIf4GIeCTobS8V0pumkqd1unOvdyV xIgHKX50HL+IOlTXCQvn3ifkIXTugIva4QCmQ8KL5BcnDR4Pqi7DYPw6coeCfQjCm7GH5BEZLxD xV2dBvf7jwXyHEE2Ija0gEcItycFIgq7F5MDycP6GHV9WUaGl4fGIO3SXvxmyWzCt10s84U7OND oiCZr0YSnoT0TwosLaoWDg8Emj3H3Oxjo5IKXTx3oySHOSu/i/pqLoyYObh+9GYdxL+6dwOjU3u oeUFLEualQf5HNlx2By9j1cG9v9uT1k8tveuArbx/wgO6+DV0TU2gZ/dUtanACe1/7VJBy+j/yK o4RA4Z7yDg67dMMA5i9BeZpzUpx1Cp4SpLeSW74Fk5mhC70VjAjV0J3d8beA7EYBr8il5ozhJBC YZGtA1j8R/KtB0bHj/v/aGqKdAwm6AGIQQqxdn8/kIx/FAqkNuc X-Received: by 2002:a05:600c:828d:b0:48a:568f:ae8a with SMTP id 5b1f17b1804b1-48a568fb048mr340987035e9.8.1777210421479; Sun, 26 Apr 2026 06:33:41 -0700 (PDT) Received: from SD.localdomain (heme-13-b2-v4wan-167795-cust403.vm32.cable.virginm.net. [81.108.45.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891cc7b2efsm299107815e9.0.2026.04.26.06.33.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 06:33:40 -0700 (PDT) From: Prathamesh Deshpande To: michaelgur@nvidia.com Cc: jgg@ziepe.ca, leon@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, prathameshdeshpande7@gmail.com Subject: Re: [PATCH rdma v1] RDMA/mlx5: Fix UMR XLT cleanup on ODP populate failure Date: Sun, 26 Apr 2026 14:33:12 +0100 Message-ID: <20260426133320.22378-1-prathameshdeshpande7@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <77145fd5-25be-4791-973e-b9e111589763@nvidia.com> References: <77145fd5-25be-4791-973e-b9e111589763@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, 26 Apr 2026 at 12:19:09 +0300, Michael Gur wrote: > The loop already checks !err in its condition, so a 'break' is > sufficient here to avoid adding a new label. Thanks for the feedback, Michael. I've sent a v2 with the 'break' change.