From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48256367F3D for ; Sun, 26 Apr 2026 14:45:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777214717; cv=none; b=Wift+qG1RsjiRYrvDpC1CEHw8LL+RcK7N4S8CvYmlyXecUhqlOa4QOH+3ydIyNkP5CxCxVll0rpEK8w0U1rcbop7efHT3t1rKkYSJN7kEj/YFxAt511551eV8GvUK0xVHhSMquYfhAvL1S2c+wJt5MYwGWJvtosWEFEjbsZ9EIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777214717; c=relaxed/simple; bh=G65XguRFTm7zXcup5EUJgGsyJNI1Wz/tFU4uJ30YpbQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=DnuPVI5kA7M6w7cGFzZniXo2dvwbSzMbjiaqnV7WNmQW3m1c1BLWuMyRwK+OAg2roqVxz1y3S0iQKpbuAbxQqqhCmoiCCvTGukd9GxrdLAdmPKS8cDvJKEs/kRhacp/BfabP/5FpvEEC3dmXlqWr6wrzN+0w0aVXKr2uyREcde0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=dvsEkto2; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="dvsEkto2" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82f8892d4d6so4038857b3a.0 for ; Sun, 26 Apr 2026 07:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1777214713; x=1777819513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OiFyBmC7gClh7pyL8uPE736qSNuG55EW852NdgZNRz4=; b=dvsEkto27OfbYJLDAIeOEeWXLn0Xmr0p3Qrs7DhBQSdrAAQlc/StsHuMWvLho/Bu06 +o6Ip0rx8pFqs80YDXHKaR49ZE+2WLyAt0KlwtQyj3Q6boTMxIv7luP/Rc2mU7uM1lv8 LpF5OiCMxEUMKIDETF8lIT4fPuTU7EbgZa/lI+ORnjPMSHBJL6rhBLTa1p2jdb/gE2gN qYvWlCWL6p+OG1ewSm6CTyRbGcCfikSgqCEUQtLhJx9/TQ2e2VKdu5ozRRsIf3NefE/5 8i2K4lOmJF7ASlm5HVhl2KIjBTTv4d0+/iTR25dvnfpFrIHsRAL3z4bwUMlSEX8DgbQn 4JYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777214713; x=1777819513; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OiFyBmC7gClh7pyL8uPE736qSNuG55EW852NdgZNRz4=; b=cmTRJYcwDSbdikT3+x4mFCgcXTUrr3qSoClhU/IN2mlKstREWtTggNTXuoZF7Npzl9 Cv6xuEt1oq4Y6eQPOmBUEX70IErHfn5yX6KpJKrtURM2AZJqM/1nmZHruorbsacBHc+Q I9g7ORreDuBrKuEJO3VFjMHl0TybKQouM/l1g9AQje8FDFU4ov0tyOa0otzz88RcR+I/ CJtHfotHggEV5r1EP7dcXWHxwyoI2evNcNDk1PLiXI5t1ytcxtsT+k0uGCwTZpIq5QNS 34OA+40D7y0EnajsjGWxMyiY9T/FGburvDeePcX76NLvL6VF8wzn+N3pauxTp8UaSkUv 3Yaw== X-Forwarded-Encrypted: i=1; AFNElJ/1tV5MFYb9BnTjPUbfhu7CM6UnG7dAzKpsPC4wtQMifEu8pEnTzFg8pJL920gqKBCMqalGGWs7WLZ4ewE=@vger.kernel.org X-Gm-Message-State: AOJu0YwBcKzV4iNhD7k+EkgcxrB6Mqx7V9vG7cdCL12wYIuezu9whu9n WmNd9k3NPxN1SYqlIY8QwTzHSDvRqp8c+dcc0Gyd0/DZUG1x2CIcHTOxZIhJFEsZ5o0= X-Gm-Gg: AeBDiet7eizenmjUxCoBUaCtpOeH4G4OUhThjpQUx0zXtSRFY+79j2F4d6J1zS19VpJ G1Tk1nLMDML8ycXzzdUniDU6c+gIER44MRwEvFtyeKSlFaqIYPnXvSU78aPomvZ/Hqr0/38JR3A hHJeqm5fn+pINjyyS4pXSgqcLRFFNqxP7JL3yP8QtuTLue2hVw6cIybN1QyZrvFEcQEXv8mS1mr 5gQ6AagMDoIn1tQZhUr90XVTITrB0XH0nKYZgbKg+UKAnmRJEF9uA6clTnJE+iYwfTsis2VUY7m lbqopTZdWgw0lcYuwveK8w13Rv6ZM9uZMtS+3ysN0xW935zs4sH0JL12yFfftW24DrdbnJRDq88 qMlbQlM/XQAYHFc+fJvVaDH0qtAhQ+8g3n6KrZ2v4tR6axgEdNBIYABBoabBzLwJxLcm7hItqbV yBlmhllRBFPblPDC7a8rC5BqswoT4j X-Received: by 2002:a05:6a20:1b17:b0:39c:241:65a3 with SMTP id adf61e73a8af0-3a08d68777fmr31746742637.1.1777214712721; Sun, 26 Apr 2026 07:45:12 -0700 (PDT) Received: from n232-176-004.byted.org ([240e:83:200::349]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797703059fsm22340550a12.24.2026.04.26.07.45.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 07:45:12 -0700 (PDT) From: Muchun Song To: David Hildenbrand , Oscar Salvador , Andrew Morton , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich Cc: muchun.song@linux.dev, Ying Huang , Dan Williams , Vishal Verma , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org, linux-cxl@vger.kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, Muchun Song , stable@vger.kernel.org Subject: [PATCH 1/2] mm/memory_hotplug: fix memory block reference leak on remove Date: Sun, 26 Apr 2026 22:44:46 +0800 Message-Id: <20260426144447.817722-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.20.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit remove_memory_blocks_and_altmaps() looks up each memory block with find_memory_block(), which acquires a reference to the memory block device. That reference is never dropped on this path, resulting in a leaked device reference when removing memory blocks and their altmaps. Drop the reference after retrieving mem->altmap and clearing mem->altmap, before removing the memory block device. Fixes: 6b8f0798b85a ("mm/memory_hotplug: split memmap_on_memory requests across memblocks") Cc: stable@vger.kernel.org Signed-off-by: Muchun Song --- mm/memory_hotplug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 2a943ec57c85..4426abb05655 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1422,6 +1422,7 @@ static void remove_memory_blocks_and_altmaps(u64 start, u64 size) altmap = mem->altmap; mem->altmap = NULL; + put_device(&mem->dev); remove_memory_block_devices(cur_start, memblock_size); base-commit: 7080e32d3f09d8688c4a87d81bdcc71f7f606b16 -- 2.20.1