From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0663C3890F9 for ; Mon, 27 Apr 2026 06:35:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777271746; cv=none; b=a+ER/OGBu/rbOr9PWMP56LUTgEa/IxDwEa0nkP4wg3yxcpVJ1/6u69Ke2H/QnVhmlPkoNONOHhw145SZG+im2CD0NVNVhBrDurOLQ4f2InperkoAqzS1xxGjFsopEUIRArI+xjqCVjGr+KRwV2JymD6zVTbnBx7X45/V0CDlqp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777271746; c=relaxed/simple; bh=aO28WQilAxZVtQvI+wCGetkRJaY0+sEy2pV+6FVXyTc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cMjye3jDh9qJKXKZ9tKtlEKdb2m1TvtEc2i7XQMK2b3QofHDlwdr/KvfnEylrK2YA75+8zrT2ldpDcrisJrc6bSb6IfmfFbPK2BuOrHbwCt3PilnSlLSunoNv+z1VMZE5CRHoXPnTzLd92EopdAOipAAG3f0dz6S8s9ZkVnh6Yc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oARk0f0p; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gBVWpszm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oARk0f0p"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gBVWpszm" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63QIBtSp2981641 for ; Mon, 27 Apr 2026 06:35:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hiUBwHms4Hb1isi9MNvxSr7/NA/P2eiTLjhGmjdWM4I=; b=oARk0f0pCY8Mf9Hz Fya6UQRmjX6wEXmriNLNQ7YjlHchBZHOKHsWXxPWlzDw2TS7uwQzPhsi1N0SV3f3 Ze53DZRO4zHFg9jvU+wovEAzSdgN8TvEIfGqLNzRa79DZuBVXaAf0uddaKzvuhVh 55r97B+DJjktE0BtKycy3UxenvyhWgUmjR1bwDAToZfW2j6JvX3vZTLaEmS0npa0 k8zmrvTxuTfYyOkLDu2PhuxiraKIqH7ZJ1hV0KfVlbzqj2Lt54tUepgpJ4JH1OI9 pOmakGQHfpZq9driQNNPXi8jd0qeOHiyVw2PxcSn8z1AOF38j5IEuBbtzB5cyTiO 4g/pmg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4drpsgvm8v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Apr 2026 06:35:44 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8f4ef450191so177105585a.2 for ; Sun, 26 Apr 2026 23:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777271743; x=1777876543; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hiUBwHms4Hb1isi9MNvxSr7/NA/P2eiTLjhGmjdWM4I=; b=gBVWpszmoTZtCrnSFsO0bICrOqJK643kWyO1ushHyyACXwzQwaUF0sJW71UqXHfWnI 6bv21xEzNgDt1Q8Fcmi3Iu1l96gcQPvhalcDoyJH37ok4WTTMYDIfN8d5SDAZAnD/AbN KAG2bsLrd2gTK+2eG/2ppX/ZjknJVHZ1AvKNkhjEcuJOlZioGcUyVZZq/EnlOOd5WA1B ReJc4l5eXsXrw/6dKi4qAHsEYRvaxi6alkwP83X20EaiCrku4qSlz4yztphlbrvAZmCj ru2lZZQABNM/hHJzxyZat53+MvVoxSbYaY8ZNktuzIx7LplS2KmirYdk1c42QDOFLWMH 9dyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777271743; x=1777876543; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hiUBwHms4Hb1isi9MNvxSr7/NA/P2eiTLjhGmjdWM4I=; b=s7sKddfYH6BhIIOR2b/18NDhBl5uMjoq4NbAozx6LC8DQY3dWFS2/EQcsdrhqcwCnx kN/l8ilN8sSIJ29/rjscveDlJVwAZwVvPPgAsxTE/unSbznAx2qJrbApIMjXLPZSIbFF iN6yEQf1VAvEdjl/YETwyIAG6ZhB+tLjaB2eUXn9rK1oL8UGcge6PMB8CIkqNE0N5sQB eRxFMcMXmgMBcaH5F6DbbZLn0V3pE666YPRmkFSlDLrHqyl23UP6SJgYuFeGyGK7Kt1W elg5Z/wyNwhrgEJrHp7VMZFxob1nCuDB8WOSzGjAP+VYxelnT4jN8eYcd6flflKbhuro IPeQ== X-Forwarded-Encrypted: i=1; AFNElJ9cGynjvmnljKcqO+sqxDErVAbAlrx4KVWWdilUboVe8k1is0mQAdpHQ5GoY/VqqnuEeZf9NHbBPxO5v9w=@vger.kernel.org X-Gm-Message-State: AOJu0YzL+/FxoOsjoG1iKjTJTo3NHZQ+cSwkHwknH6rXf45lKIdsIPUP /K/X8uUpdTnLdRrXsqwZ3Yc/ELFrsw+8WAsEMIiO/ACiVQ/dGKLw7DpqIYbvZxaBnyGDZXrK6oO aVAPN23lwNAUlrvfDVcYpz6T9tS/kU0TqAKDEym005EtAXs7cXfJMhIL7lGoCWPFQ6Lk= X-Gm-Gg: AeBDieveSxpCnx1aWwm430pxN4aRN/ZI1ygjVLKom8jnQM3irw0hjdKaiBQhiyiukKT mMAp+DyIKFoFc/U2kZT89TE15uBA7DmsZ30obDjEoancobtehJ72pg70KO/DJaFqG7tgwhfN1iX pMlRhhtULaufkCNp64JlWh5mCQIHhedPZJ+1EhDIlqwVhxnjkOd2SlLQ3s6tHhgT+qsfmLEZe1d i4vXZTwLvDDaXp85T8ozBticu96IZadqE5W8HmmYpeLl8zmBbtzrFGkzTIzoP+ZDGO80hjfcwQS Q5qpg0Bua0iJM0sUciaAOIOxrh78YIXsiFajFXtl/d0jGvvV+6Shq8SRUZ5Q/NiMRJZOqzdY4gE nNmGE5q21TLR8SK2UPsNd0/8t/Klcy4ppmX3y4lVi1scOg0LGfCkwc+uUbZE2wEeNu5bM9yN/Yw SiamYut96SawAaBX9vRg== X-Received: by 2002:a0c:e003:0:b0:8a2:1149:3337 with SMTP id 6a1803df08f44-8b0280cbac0mr536922126d6.24.1777271743153; Sun, 26 Apr 2026 23:35:43 -0700 (PDT) X-Received: by 2002:a0c:e003:0:b0:8a2:1149:3337 with SMTP id 6a1803df08f44-8b0280cbac0mr536921836d6.24.1777271742775; Sun, 26 Apr 2026 23:35:42 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ac7d4e6sm251899256d6.20.2026.04.26.23.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:35:42 -0700 (PDT) From: Yongxing Mou Date: Mon, 27 Apr 2026 14:35:22 +0800 Subject: [PATCH v5 4/5] phy: qcom: edp: Fix AUX_CFG8 programming for DP mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260427-edp_phy-v5-4-3bb876824475@oss.qualcomm.com> References: <20260427-edp_phy-v5-0-3bb876824475@oss.qualcomm.com> In-Reply-To: <20260427-edp_phy-v5-0-3bb876824475@oss.qualcomm.com> To: Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Yongxing Mou , stable@vger.kernel.org, Konrad Dybcio , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777271722; l=1322; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=aO28WQilAxZVtQvI+wCGetkRJaY0+sEy2pV+6FVXyTc=; b=KhT8bRFH9JS6NuUlvP1bcZQMegP1Zye5cxMcaApOj1lBr2zb4OC7W9m2Q7pfbKczPsrAsty3K WxNAK+1XhaKDXx9A2RQ4WZtSERsqPM3AN5McM+OZsqiUec4ko+30Wmf X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-GUID: 34_JsnoVgBpEy1LfYgHuhvLNHwojh9kX X-Proofpoint-ORIG-GUID: 34_JsnoVgBpEy1LfYgHuhvLNHwojh9kX X-Authority-Analysis: v=2.4 cv=Y+fIdBeN c=1 sm=1 tr=0 ts=69ef03c0 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=SO9rCO7GgoKHDwPkKK0A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI3MDA2OCBTYWx0ZWRfXwn0zjgAXVoLp tHqXyaNlsK+kTzuYyXbvxVEpVdKvg8whgZbpa1EDIOgG0aca8NwLdaQ11sRvNaXolcdlUdxJTMr 89K4Q1RjlY9E/sA4wmOkIjNDsCI6AoYwH0RTTXn4ypFqxIGqfSyvYU/vqRb/yQiPHKHqo5DRI6B NZ1zbI1PHJgIQoLewOOk8R+hcowll0fOTY5jib15n9ywpzg2VHQcUuv+CtDr9fkwcTT9ZFoEPQ7 9AVT5WCf/htIr0rL3d563Z4GwTc22UBMQ4YCwx5++kw7PsC2XcDwHDi6ITyLan0OJAkImVd2dEe qOuCrw9ViD7m723V+rsw7un2+JR7t9Oe8gsDYN3/4mPpwRUpG0WU/z7Nq5zbQ20VAlvAbDRTIQM hu4uhN3e0pe8cNR7TVWFXQM8LGH3JMA2ImpqJTD3RjBi46XbnqUohSpXEwyhvATUXFNgXkGB6TV YJ4EqBV/ObWKJSfLDNQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270068 AUX_CFG8 depends on whether the PHY is operating in eDP or DP mode, not the selected swing/pre-emphasis table. All supported platforms already have the proper tables, so remove the unnecessary check. Cc: stable@vger.kernel.org Fixes: 6078b8ce070c ("phy: qcom: edp: Add set_mode op for configuring eDP/DP submode") Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Yongxing Mou --- drivers/phy/qualcomm/phy-qcom-edp.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index 3e613b374032..3a848f18a8d6 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -325,12 +325,7 @@ static int qcom_edp_phy_init(struct phy *phy) DP_PHY_PD_CTL_PLL_PWRDN | DP_PHY_PD_CTL_DP_CLAMP_EN, edp->edp + DP_PHY_PD_CTL); - /* - * TODO: Re-work the conditions around setting the cfg8 value - * when more information becomes available about why this is - * even needed. - */ - if (edp->cfg->dp_swing_pre_emph_cfg && !edp->is_edp) + if (!edp->is_edp) aux_cfg[8] = 0xb7; writel(0xfc, edp->edp + DP_PHY_MODE); -- 2.43.0