From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 245BF3793BE for ; Mon, 27 Apr 2026 06:39:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777271965; cv=none; b=mOuctLndmybQPWCs+Xwy5MkavJA9Y5Tn5hwtc++SOTaNaiFswdahtNISRiVDF2d3wpB9C/E/2EG5/rNq3SPDPii9+4kXq0a07lIO/4JZaiyT62SOHESjGVFjtEZ30xBfx0Z2K1NBxeQrKX956h1cCr7T+2DPAbemMCeRp/PLCJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777271965; c=relaxed/simple; bh=R4QRkVHAwQ9KrtjujN9XD83vLhDAkEyM/SDEmmoV3Sw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZouGuZN79CHEoE+zfFzSRMZUbKeSU7l2aJmXTiv4xaEB1T2yrJVhyIiYHuyjPe2JpcTBjuAsUSby1wz3DjwqETjF7f3nqr5g/0h+UXJYJLsV8cg48sEn30+isofmByzJHk6Uz1jepBVtCAbUxGiR/z1H7KTvpl2p69eFXUBzQME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hSHs70Vd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EbO8VZ+m; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hSHs70Vd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EbO8VZ+m" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63QMLf1S192374 for ; Mon, 27 Apr 2026 06:39:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= k9t2Skqy5JANgUESsWXa9v41qvVlWGnC0rrJSF/Em/Q=; b=hSHs70Vd+yUPJWyd gHC8XZXPfCL8oSQ/os1j7z1/ZUPcFBHGA/T7FnY0wCbXJ0PJhW+luAhrHwlZJ3k1 t7fAS46HGGPaVCWs1vAZRKJH7KKGUTNQvSMB1ND540pEAuVtzQlv+Fstelt4ah/7 0z4SCZpX//EP6aDBp4uuX/FxjaCRv3VIFuyIpQkigihekvxT+aWn/+Unl0ZWbi21 XRgJ9BsvFuarm+0ZBTAf3liFbamz5tPXwhcZb/XCaVuqBwO+QJX/ew5MMmpdcqtI Hn1/Tsg8q6OdWhu6/aisW54TrbnWVnzhe9a+EIYjRAZZviateIXXwosiqAMSFkFn ErPJyg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4drnqrmpt6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Apr 2026 06:39:22 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35842aa350fso19307507a91.0 for ; Sun, 26 Apr 2026 23:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777271962; x=1777876762; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k9t2Skqy5JANgUESsWXa9v41qvVlWGnC0rrJSF/Em/Q=; b=EbO8VZ+msehD9Vy7LCxLsUMX3kRX27XVPKyXzBqfX6MWmOPIlY8RiaydPsRF5QKkjU QLSJEbDGc/eKhuFOe3LA1mCU5EdPWBU9O4Eu08Js78tHdgFjbi/V9+WofzR12+nbhu/x Xlw5SAk5pR+qa1IegGgUb7ehRn7OqFc5hLQbTpBsEx/bGnstGpFFIdb7mUiUEyVeyjW8 kmStrFJ9vGedUhg7YPDN3+mNNarQ6+ukgK972PCwp6hriyiFTvjDo+SKl72KoF90H+S4 yzK+vEdMs6Tlp3eY/NMvMY3JyJJiYtshU33bSs7TdbhmJMaYVEhkV0ec0q/LWzAjCRs4 HTqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777271962; x=1777876762; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=k9t2Skqy5JANgUESsWXa9v41qvVlWGnC0rrJSF/Em/Q=; b=bL+EJf3htsY+bvnVtY2KJANSAoIfYrQH+TtxwThQX6WhBvZpZXolYfm75BfZMktp0M j0jSZ9TVG24snq6AQMX4nsX74Tq6Xf9nRD51dVjxSMboq+q8rQKIOuQJfKBjkacr77WT 8FLgL3BuhR//a+nX64gqO4fwlPyEjsJvXOH2xGYba4b8xALVkyFRAYtKEk5avbIsT6qH SvIkyiNfaobqq2uxttXx5yIa9DLCFL/DvaTo5gpNPmQ4NkUUnnDDjWEJ1IH10tv94J2x mo1KGqLl9MilToFuNX8hDc6ED6+XfmwoUBODfbKXct5LXTenHWTLO0THRKVBaSrlqCuT VIJw== X-Forwarded-Encrypted: i=1; AFNElJ/dCnpubvdCOX0prqOOkt8URsznn2mtjU7w+/3Z+RbVjfE7NBxlxlUrRCMq02FTH++14haQR/iF/4Qh4S0=@vger.kernel.org X-Gm-Message-State: AOJu0YzRqqrWAENKB3XCWi55FsoLpUKi95HRZcJlyJFe5wDtYuYQNHxs X8jn+KTSc4HDWTwDZ29z9xxQFIjNjN0t0fmawAXIrFGc6rWQ0T+9EOIHMhYkdr2dlfNDkHle9Rj BKz/ciHP4QgrN5ot5ely8nD5b8gn4HeBSdD6piaCLqIasix4889DoFftjAlM9Be3LgCMQanDOrQ 0= X-Gm-Gg: AeBDievyh1V39wv4xKhCNsafQxUHq96ycKMd1WWlx90sHBKLpGdnr/5PKG4CtMDkQvj 47kGMWfJR5w03njqoua7DcmQdi6NyWmf3Abgr355P6XbSe2PsHiM63ybN/xKnOqzah2TlOwRnfH cjV5xdUchYekDjhP+MWZkKgu21Vb1NUf0XEIxTAxWGUwhmin7uisVlymyD9aJQ+BCG8pGVy8jmT Hddt2CQlp/Ky6FofX/OpCQt59hsz8W51FkTSu3b2RRs3iuFHgjkdOot+Vhq50tvcpHtrztimmV+ nhzbvIp5oW15RgCPSRH00oAU3+FrpT0Hc/W4TgcPcrt9Hs5D5BEkEau1pj3+Yg9oCAlwyQni9gi pFpxG/PzHyRXJTqHQ5YShaBdYeNIEQcAwkoVkL+FQ/vPqyGk9I7Bf9LYZ X-Received: by 2002:a17:90a:d50:b0:362:eaa6:a3a2 with SMTP id 98e67ed59e1d1-362eaa6a580mr8394459a91.19.1777271961605; Sun, 26 Apr 2026 23:39:21 -0700 (PDT) X-Received: by 2002:a17:90a:d50:b0:362:eaa6:a3a2 with SMTP id 98e67ed59e1d1-362eaa6a580mr8394436a91.19.1777271961165; Sun, 26 Apr 2026 23:39:21 -0700 (PDT) Received: from hu-tdas-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-361410a7ab7sm38628234a91.10.2026.04.26.23.39.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:39:20 -0700 (PDT) From: Taniya Das Date: Mon, 27 Apr 2026 12:08:56 +0530 Subject: [PATCH v2 2/6] clk: qcom: gxclkctl: Use custom disable callback for gx_gdsc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260427-gfx-clk-fixes-v2-2-797e54b3d464@oss.qualcomm.com> References: <20260427-gfx-clk-fixes-v2-0-797e54b3d464@oss.qualcomm.com> In-Reply-To: <20260427-gfx-clk-fixes-v2-0-797e54b3d464@oss.qualcomm.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Konrad Dybcio , Abel Vesa , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Taniya Das , Pengyu Luo , Alexander Koskovich X-Mailer: b4 0.15-dev-aa3f6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI3MDA2OCBTYWx0ZWRfX0Gk0ERHUDZn2 FLam8H+JLyV4O9c0T65n/J4J39hU6zZj+NHWU4NJShRrUQn1nvAgNSdgANW2oagPH2sH9+VYlA2 nG4W7Lq8gdnLK+DXn4jLt2ja92ozMDurV914yrxcxqyqktQWjP06kKPGvxtrAS/j6yEfSrIE7ln QJGw1etlsK0xKpviQuWBjeb7CG5Sb2IkU6VoFwrOXK8TdSygsZqLKd/C/dHTQB5o1KqvI85TPAl 50MoMrmLY1IUnl15eJ+9DSYTWvBXgXMzYLHb+/DX1SqiD55gJdFCnZpm1jRPrhH/kwn6GIMmfQD s+ier0p8aeOQudCr27x+E/UDiPSzbWqcH7ziaO7cpSSdgQA9bdSAsPKa4bm5TAi7QtjQj1nNzbC L7mBC2Flpyv2r8ru6nfNKyCAdtxR77qrXF+EMSbV+sN+hHwNNjIFphOaQ/0Qv63ttZtzvRxv8HN ut50AYkZhFbuu/ijsAw== X-Proofpoint-ORIG-GUID: 8Qy4D5zwd5wO9Dm2ET20x8i6wsSlABpL X-Proofpoint-GUID: 8Qy4D5zwd5wO9Dm2ET20x8i6wsSlABpL X-Authority-Analysis: v=2.4 cv=UcthjqSN c=1 sm=1 tr=0 ts=69ef049a cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=r9sBLZ6K9uwiCka_ugMA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270068 The GX GDSC represents a special GPU power domain that must not be disabled during normal runtime PM flows. As per the GMU architecture, GX GDSC should only be force-disabled during GMU/GPU recovery, where the OS explicitly resets the GX power domain. However, when managed by the generic GDSC runtime PM path, GX GDSC may be disabled during GMU runtime suspend, resulting in warnings such as: gx_clkctl_gx_gdsc status stuck at 'on' and failures in gdsc_toggle_logic() during rpm suspend. Use the newly added custom disable callback for gx_gdsc to ensure the GDSC is toggled only in recovery scenarios, while preventing unintended disable attempts during normal GMU runtime PM operations. Reported-by: Pengyu Luo Closes: https://lore.kernel.org/all/CAH2e8h4Vp9fJYAUUbOmoHSKB25wakPBvmpwa62BTRqgRQbMWuw@mail.gmail.com/ Reported-by: Alexander Koskovich Closes: https://lore.kernel.org/all/gwVAH2mJerU4dBInw8pKmOs5aQK55Q7W6q_UQAlLFCsEgX6eyvSgXAWbNNMqAX4WmPlYCKUSMhfkr5Jry4Ps5EqnxYZqEEDd3Whwv7ZXGlc=@pm.me/ Fixes: 5af11acae660 ("clk: qcom: Add a driver for SM8750 GPU clocks") Reviewed-by: Konrad Dybcio Signed-off-by: Taniya Das --- drivers/clk/qcom/gxclkctl-kaanapali.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/qcom/gxclkctl-kaanapali.c b/drivers/clk/qcom/gxclkctl-kaanapali.c index 40d856378a74aeb706c2f4a7a17a2c5602042af2..d7cf6834dd77c2a5320ffb8548cdb515be237bdc 100644 --- a/drivers/clk/qcom/gxclkctl-kaanapali.c +++ b/drivers/clk/qcom/gxclkctl-kaanapali.c @@ -26,6 +26,7 @@ static struct gdsc gx_clkctl_gx_gdsc = { .pd = { .name = "gx_clkctl_gx_gdsc", .power_on = gdsc_gx_do_nothing_enable, + .power_off = gdsc_gx_disable, }, .pwrsts = PWRSTS_OFF_ON, .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE, -- 2.34.1