From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 573793F0A9F for ; Mon, 27 Apr 2026 17:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777312770; cv=none; b=u+wmS0VclD73+A67rhOVQ0ChNZRLjtCy9QwQhajgTI/pzwgXBPugHoNoBjGG4n/I1230oW258h+g+a74zYDd2tzTW+9Z9dxJEJenyFgpzqRHqLhx/wfIXMKTb8+tr5mRGqPxXfB3YO4Id6DEGBElZaWX+xE9Ow91516ES1D5W98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777312770; c=relaxed/simple; bh=W/jdrMMOR+FvAcaLb6DCGvMLoN/HdffKmNBgDjoCT/A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M02vLw3Hw6EwnAFPQm6iF/pZHqF90UUH6mO53fQoin6T2zGl0m3RM5fgAtzpuV2iEJxJVbnEOFsFeQzeBhU7UFmDJp6+e/GLNQjN/4FCuzizqpnpo2GQxnpoEMdkmtJ7D3KW2Z4MhXJ5ITjhJhpIepHqbDn5/7V9ijeZ1Dw+mc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RzglCDF/; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RzglCDF/" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-79ee5037d44so140516927b3.0 for ; Mon, 27 Apr 2026 10:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777312768; x=1777917568; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=R+ZGKTVkBXN8ikP50VcfnPbIIQ0Oi7+ClKejUhvLkNg=; b=RzglCDF/2/eTn0QGiJvDO5T7C3ClYwr9s24SDv4PCVNGiUOYSW4U3q2iSdWTF6OAm2 fq5CzZ7cl8jWam3ugovu//q9vcliZncLWMU4EE+avV535MJRoOCsmvrHFJcJdwnqF3P3 LkQoCnU02shXIWfBjZu8ioueiZbfLWO3J9CTPjkJeyla7TwKKaVOf5eIMvXYfuEuicnb AcsJSzLSR0dVgWg/NQMk4Ej7/IcrnZU6e/NoFxAjsxV9Vg7L0rq1MbNy+Pq2GI9Yzc9i ZX//2ANNOlE/bmmgVlnx566kEsEd23i5MMffPRmm0MVOTQLVpdK3SQaPlNoCHwAW82fb aSZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777312768; x=1777917568; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=R+ZGKTVkBXN8ikP50VcfnPbIIQ0Oi7+ClKejUhvLkNg=; b=PHtF7EsJsblYz8kFUJqgRXjwsexka49b3/64JANw0rQ7lC4a2KY7Iugs7Fu0CUR7c5 ySOnrwAcWQeoddnUrEtdJ1yFJSIGUTJ27D1HMl4KtwJNpPRfkxZq+oLq9b2k+EXyJo+G iHNHXNOa3ST5y6moBfx5/SbLv6kKD4GZFHDVQubcngzyVIrgoASuKO9mAW5cEelUEcHd 1YKh6j0+pnmHn5aSzE253OtivmlzzRK9Uwmf3Os4a4rTImDoTB/8T3Pc0rBuduBcbLrt Ye7OqmkefCnClD0mmUo4ir+OWZc0GEkjsTohLKlweGKyCcTyEtRMRK7j8mI5t8U81jmr 9vRw== X-Forwarded-Encrypted: i=1; AFNElJ86q57ozS0cjSUVw5FBAMrmZmQMgkqGHRFPSXVvjtcVEqkGPmXXe4bWTPPiowEUbbyP4VR8oa/O6h66/S4=@vger.kernel.org X-Gm-Message-State: AOJu0YzMhUhrvoAE3AK+8XruYZ6AweoEfvztIGLzFEo81TWLtVcxQBg0 zBSTcyEkA48uoL3KTnRaPaygns+b/3T3fZu9ovJ74RsJsfLCV5QncqRn X-Gm-Gg: AeBDietcUDFyQKF+jIegC3KXrFEWA01P5TgNEbcVxZW4sYTAzkVRb87RzTXURZzcl9f OYWAKSaMo6u8oUb5TY7iYv9BJ1+7nMX8pmk0rb8CpSrUxGxj+079IVzYGgbfE79CGbAbT4iYa/U ceHaSM8nirde+aCrDS0bnKUxymCPEsDHO8YauDiaoXNGRve4d9chFKoujJNQzGAUC4ls22AOuhN Xfw2l3f9/ORBTiiOdEhmQ5o9+0tKJHtbZo134ZiCEyaGmNEbHqh5n9aa57YZjMZ9dPjqD8Mhvzx oa8JtuD+j/SxwhKosnELY1oh7w+bfX3uTLYJ0nwPdgGytxxAD5Wdt5pDz+X/QLJ9UoGfaykc+O/ s4k5ZiJ7I9qqg8saoYEB8nv3n9FfCSBbPSFQRpLDM51/nYY976evIhop2uTqYi8KNUGDJneOnLI DYS46Npa/GKSaZUThMQI+2ABFYjvel3aONQTWB X-Received: by 2002:a05:690c:6609:b0:7b1:9036:a23a with SMTP id 00721157ae682-7bceeadc0eemr1800427b3.14.1777312768435; Mon, 27 Apr 2026 10:59:28 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bcf05e9cf8sm198467b3.18.2026.04.27.10.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 10:59:27 -0700 (PDT) From: Erikas Bitovtas Date: Mon, 27 Apr 2026 20:58:32 +0300 Subject: [PATCH RFC v3 10/11] media: qcom: venus: add power domain enable logic for Venus cores Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260427-msm8939-venus-rfc-v3-10-288195bb7917@gmail.com> References: <20260427-msm8939-venus-rfc-v3-0-288195bb7917@gmail.com> In-Reply-To: <20260427-msm8939-venus-rfc-v3-0-288195bb7917@gmail.com> To: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.15.2 Attach power domains for vdec and venc cores and power them up if a vdec or venc session is started. Signed-off-by: Erikas Bitovtas --- drivers/media/platform/qcom/venus/pm_helpers.c | 121 ++++++++++++++++++++++++- 1 file changed, 119 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c index cc21a4762188..41272c194a6d 100644 --- a/drivers/media/platform/qcom/venus/pm_helpers.c +++ b/drivers/media/platform/qcom/venus/pm_helpers.c @@ -246,6 +246,94 @@ static int load_scale_bw(struct venus_core *core) return icc_set_bw(core->video_path, total_avg, total_peak); } +static int vcodec_domains_get_v1(struct venus_core *core, struct device *dev, + struct dev_pm_domain_list **pmdomains, + const char **pmdomain_names, + unsigned int pmdomains_num) +{ + int ret; + struct dev_pm_domain_attach_data vcodec_data = { + .pd_names = pmdomain_names, + .num_pd_names = pmdomains_num, + .pd_flags = PD_FLAG_NO_DEV_LINK, + }; + + if (!pmdomain_names) + return 0; + + ret = devm_pm_domain_attach_list(dev, &vcodec_data, pmdomains); + return ret; +} + +static int vdec_domains_attach(struct venus_core *core) +{ + struct device *dev = core->dev_dec; + const struct venus_resources *res = core->res; + + return vcodec_domains_get_v1(core, dev, &core->vcodec0_pmdomains, + res->vcodec0_pmdomains, + res->vcodec_pmdomains_num); +} + +static int venc_domains_attach(struct venus_core *core) +{ + struct device *dev = core->dev_enc; + const struct venus_resources *res = core->res; + + return vcodec_domains_get_v1(core, dev, &core->vcodec1_pmdomains, + res->vcodec1_pmdomains, + res->vcodec_pmdomains_num); +} + +static int vcodec_domains_enable_v1(struct venus_core *core, + struct dev_pm_domain_list *pmdomains, + unsigned int pmdomains_num) +{ + int i, ret; + + if (!pmdomains) + return 0; + + for (i = 0; i < pmdomains_num; i++) { + ret = pm_runtime_resume_and_get(pmdomains->pd_devs[i]); + if (ret) + goto err; + } + + return ret; + +err: + while (i--) + pm_runtime_put_sync(pmdomains->pd_devs[i]); + + return ret; +} + +static int vdec_domains_get(struct venus_core *core) +{ + const struct venus_resources *res = core->res; + + return vcodec_domains_enable_v1(core, core->vcodec0_pmdomains, + res->vcodec_pmdomains_num); +} + +static int venc_domains_get(struct venus_core *core) +{ + const struct venus_resources *res = core->res; + + return vcodec_domains_enable_v1(core, core->vcodec1_pmdomains, + res->vcodec_pmdomains_num); +} + +static void vcodec_domains_put_v1(struct dev_pm_domain_list *pmdomains, + unsigned int pmdomains_num) +{ + unsigned int i = pmdomains_num; + + while (i--) + pm_runtime_put_sync(pmdomains->pd_devs[i]); +} + static int load_scale_v1(struct venus_inst *inst) { struct venus_core *core = inst->core; @@ -331,6 +419,11 @@ static int core_power_v1(struct venus_core *core, int on) static int vdec_get_v1(struct device *dev) { struct venus_core *core = dev_get_drvdata(dev); + int ret; + + ret = vdec_domains_attach(core); + if (ret < 0) + return ret; return vcodec_clks_get(core, dev, core->vcodec0_clks, core->res->vcodec0_clks); @@ -339,8 +432,18 @@ static int vdec_get_v1(struct device *dev) static int vdec_power_v1(struct device *dev, int on) { struct venus_core *core = dev_get_drvdata(dev); + const struct venus_resources *res = core->res; int ret = 0; + if (on == POWER_ON) + ret = vdec_domains_get(core); + else + vcodec_domains_put_v1(core->vcodec0_pmdomains, + res->vcodec_pmdomains_num); + + if (ret) + return ret; + if (on == POWER_ON) ret = vcodec_clks_enable(core, core->vcodec0_clks); else @@ -352,6 +455,11 @@ static int vdec_power_v1(struct device *dev, int on) static int venc_get_v1(struct device *dev) { struct venus_core *core = dev_get_drvdata(dev); + int ret; + + ret = venc_domains_attach(core); + if (ret < 0) + return ret; return vcodec_clks_get(core, dev, core->vcodec1_clks, core->res->vcodec1_clks); @@ -360,8 +468,17 @@ static int venc_get_v1(struct device *dev) static int venc_power_v1(struct device *dev, int on) { struct venus_core *core = dev_get_drvdata(dev); + const struct venus_resources *res = core->res; int ret = 0; + if (on == POWER_ON) + ret = venc_domains_get(core); + else + vcodec_domains_put_v1(core->vcodec1_pmdomains, + res->vcodec_pmdomains_num); + if (ret) + return ret; + if (on == POWER_ON) ret = vcodec_clks_enable(core, core->vcodec1_clks); else @@ -905,7 +1022,7 @@ static int venc_power_v4(struct device *dev, int on) return ret; } -static int vcodec_domains_get(struct venus_core *core) +static int vcodec_domains_get_v4(struct venus_core *core) { int ret; struct device *dev = core->dev; @@ -1023,7 +1140,7 @@ static int core_get_v4(struct venus_core *core) if (ret) return ret; - ret = vcodec_domains_get(core); + ret = vcodec_domains_get_v4(core); if (ret) return ret; -- 2.54.0