From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C249399031 for ; Mon, 27 Apr 2026 08:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777277906; cv=none; b=GQNERM5iaqFWCYZ2pfPD34D3K0u1dvAccsQWFn9hdSm33QMpXOQErwbADOvL2rg+ZYbQH33LJU4TWwUhPhOqdYyejtiHWXx+0GmUBR82fr3snrNV83gL/SY3Nf9pC8KhodaEPFOxgjl+SNpTaGxykrDi3BVS6g8TNSJWRMpif4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777277906; c=relaxed/simple; bh=X54KA9PavQZQEzucsCa1+36HcRdsBWVlMFDudcoevyc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xn46i5Et1SKiiCZOTGm9mQbPlS4sRfCnhkEDC9SLfgCfILJhmpr/ww3GAMOuihyUbpk7YeRodc94If0gQ85syabRog9LpxGaS1Rvj6DyWFnF934WLWnS14evmYJwXoTLR74N63F+8XO8SaGW1+f5riOz5cydLkrCiTg/W0ry2A4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iaCBC7mt; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iaCBC7mt" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4896c22fcbaso72041695e9.0 for ; Mon, 27 Apr 2026 01:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777277903; x=1777882703; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4VGLXQGdtwW4M4dZrF/iMa6PrGQcTVy/0M0hUiD6E5M=; b=iaCBC7mtUL8wNQ2E2UfXAk41pu2EJAoDfvWVLTC4DpfYUxC3wN8vQQLBoH2sH+f583 VDU3O9Kzkw0k+0vjq1bx33yrS10x2t3Lr/Lw864rxe/C0bNuSxQmEXf5IssVT5JB1jV8 9+nAyggvj/iEVE15EZsFpctK+5rnDgGtw392RAn4OYRFfMYysLXKtF4z74brlH0ZSo9U NhEeDd4e5xFnogNw2crxzcQakM0+TQWW1es+sAuq44iyZm+Q4ToCay9EphbG/92WMVxQ gpRs8TGKnDDbz/DcAKrX8mqgPxSQ2WwFRz7LMA29BuH5GCNFQam9iH6bC54VMdhtJA+F wXZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777277903; x=1777882703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4VGLXQGdtwW4M4dZrF/iMa6PrGQcTVy/0M0hUiD6E5M=; b=q4tf7Uyfjey0Cutzto4sCApdRhytHA69yfXVJkHZuOjXSryOLxekpD0c+JdEuQo2nA xh7KSZG2t82J85YYh57wpsDaobCp9OREswJFIV8sylWMtPoa5u6DFJpYGh4yso2qWllS kDHUI/pgkcwWc4InoOdDhRONBBXDxB5pADOI4jIHxM++kudGKAz4b5rAHqEcuwJDLWRf nifc9HhZVljlRSV1RcZSO/L6O9YXjnQeq+pmNQfi3o9a9W4iTuiP2JOwc5sEQHrv1jJW yPvA540VCsFnXZwRcuWmE2Wh2NQeN7AqFRZYZBDs3gNtp4J+QnxRoyTT3sW4TxTP2tAn BhSA== X-Forwarded-Encrypted: i=1; AFNElJ9hEulYer7AifXbYVYc9CmXHUx2MJNBtGqWBFOhdL7R5Wr7b/cslmPmAJEOD30Tn4QHRmji/8OkfFvt6K8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxv5KRHRMtyxo4Y7Pr67kkcpSlIYqlbG1k1IprHNQbfJaEJp0vU Xk6uWPPBidRzH75tsMDO1pfY29UYkdoNeLvSMoeDlR6byUJbE2KqtAre X-Gm-Gg: AeBDieszHAXMVXGgDO7OpAJdtPVh2/RPUBamRcr5dpjEqFxMWdSMHA4CtH1E8SrF1v3 vlMZeQG7tH/pSWLWm1aaE7gC6PvnrbFc7j7AbrbauCRemrEjS86WTDT9HwII8tCazxzKxMVC1bF bwpX35CCo2e4sRUO/lFMWrPK2K6FgdvBujuxVbaNhRP++GI69jp51Q43YH/eGZH+N5ys3qOnBbp Nt44lSMMhzN5N1LQaza7UiapDt8Nc5gZl2lQ1PPQo2OsfJUPwwGHXzDXxT0EjzUs3Z/OOIPN57g ks+M4XUftfc3rTeYZKpxVtppvSROxtLDMgeZ5Oq2kaWNd5XRUiA7jCV4d3cAuz4yVOMKDPXQoRd zy0Y4Qn+pq9lIDJl3UNIRvVUBGgII4SO6I5D/ynt7PLtBJIfWjqNB0GUVfEBDdJb6P0qvOca99r +QQsTdVtN5JbhxMxU394nJ3j3KEIIDPGpCDtl2wUAlYe3H12NgOu08Uru5zAhxVjNXa1FiXW/uC AA8lOsvoyFGF81bp9UGBuaigcJfHQhABsPGzO88v9WeafP7EXfbjuIDIWIa0XnAw/8sa1M= X-Received: by 2002:a05:600c:c106:b0:489:1ba8:5be9 with SMTP id 5b1f17b1804b1-4891ba85d07mr326445715e9.29.1777277902712; Mon, 27 Apr 2026 01:18:22 -0700 (PDT) Received: from ahossu.localdomain ([82.78.232.184]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc14a61asm712652115e9.15.2026.04.27.01.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 01:18:22 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: error27@gmail.com, luka.gejak@linux.dev, Alexandru Hossu , stable@vger.kernel.org Subject: [PATCH v3 1/3] staging: rtl8723bs: fix OOB read in update_beacon_info() IE loop Date: Mon, 27 Apr 2026 10:16:24 +0200 Message-ID: <20260427081626.3393697-2-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427081626.3393697-1-hossu.alexandru@gmail.com> References: <20260427081626.3393697-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The IE parsing loop in update_beacon_info() advances by (pIE->length + 2) each iteration but only guards on i < len. When a malicious AP sends a Beacon whose last IE has only one byte remaining in the frame (the element_id byte lands at len-1), the loop reads pIE->length from one byte past the allocated receive buffer. Additionally, even when the header bytes are in bounds, pIE->length itself can extend the data window beyond len, passing a truncated IE to the handler functions. Add two guards at the top of the loop body: 1. Break if fewer than sizeof(*pIE) bytes remain (can't read header). 2. Break if the IE's declared data extends past len. Also replace i += (pIE->length + 2) with i += sizeof(*pIE) + pIE->length for consistency with the sizeof(*pIE) guards added above. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Reviewed-by: Luka Gejak Signed-off-by: Alexandru Hossu --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 6a7c09db4cd9..e0d73c267786 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -1289,7 +1289,11 @@ void update_beacon_info(struct adapter *padapter, u8 *pframe, uint pkt_len, stru len = pkt_len - (_BEACON_IE_OFFSET_ + WLAN_HDR_A3_LEN); for (i = 0; i < len;) { + if (i + sizeof(*pIE) > len) + break; pIE = (struct ndis_80211_var_ie *)(pframe + (_BEACON_IE_OFFSET_ + WLAN_HDR_A3_LEN) + i); + if (i + sizeof(*pIE) + pIE->length > len) + break; switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC: @@ -1314,7 +1318,7 @@ void update_beacon_info(struct adapter *padapter, u8 *pframe, uint pkt_len, stru break; } - i += (pIE->length + 2); + i += sizeof(*pIE) + pIE->length; } } -- 2.53.0