From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7873439936F for ; Mon, 27 Apr 2026 08:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777277915; cv=none; b=UhSY1gn9HrdW/eQInFqvkaLNkWJzspTvddMpqRQ4VsZqIvGdy3b+oV7BpV9fGYve9PVXVW23Sg8lnMC8wKm2yjAOVZi1d2DB05Z68HPru0VsgOSAro5EFDYcSp+Ut8KIq2ufnUNP4o2XMSexh0khg24yFhtY5cGearQjeGha+9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777277915; c=relaxed/simple; bh=UGUi2ZtX1bemwYp8cSksp8hkcBsw8FfUwrFHOQVPgO8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ssimZI+/oyxiMSdppz6ebeNglNFYOw+tQgRvmjObhdwTB2qBqEAUQqtZOoqQuXmL4aCPJeawaYDUav3ajzKqTuOCrFHOZee8IFlFurhn1N99YeZQikqBpkzbBZlTBr1TsZCUnS9zBJDP9hs7MYaajJjgEl1SShaX5smWd/9XJw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=enl7lMNY; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="enl7lMNY" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4896c22fcbaso72043335e9.0 for ; Mon, 27 Apr 2026 01:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777277913; x=1777882713; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ORRSLkmyVRQ6NCw35RQV07Yi/LmWTcjj6Iy7t//9MNM=; b=enl7lMNYY+PU3skof4mFDxIopNGaynUd6Dy7HT3QRR1FkUEYRA++cCHxlOJ/5Bddty J1lLkwzStKVyPUWqG0xMh33k727ZeW3kWFcUA4u6cevK2/Vfy8euBTdgN2lQQI1sABjh gTIPHkqNIqZ7lguQbs8j58DGkAslwXh5rapDtCkdekMkZaOivN3ikquYmIMgR3AqJNnZ w4PAjXUWlhVOBHhM4kM/CPIgQoAb82186mOH+AoCMR40eHhx1XG8wRuwYqowCpXVuluY Ti33l3RdxNBKCARjsiMHyCxz/ffjc3A7PtjJ2OSkR9WnuDotA3CEtkrTG2uLLJOvoiax Lxpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777277913; x=1777882713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ORRSLkmyVRQ6NCw35RQV07Yi/LmWTcjj6Iy7t//9MNM=; b=BQNzJMvFsu44Orfi9xcjvlWDmnqBSN6jEzTWPazXQCv+SlZMFNVEKnEcQepzuYJPoB 2p/d2QfIZ/H2NiPNLVXZcBE2Vh8ewgAeXRFnnznSOiGBrVCCOGjM+LBnVgY9LGCciGI2 DqhmX/g8exIp+Zu7AsBm0XFgjL1HP6L8BYp5iMkijuX54rUzT73SMTGoeGZmyiviYtD8 DmUxce++ib0NKXa4lpAHCEb2ZxlQ5jtHD81RYXUFkO47raO2eR0ToIBul7HHGrp7jFr1 WKdDltag9cO60eXf0FWPsZqnF3exfMe1Q+ezBr++7RaWRw6oopqsdJE0WnJxPDfsx3Wk P1YQ== X-Forwarded-Encrypted: i=1; AFNElJ8ITBdU2mnFJmwdWCeJMnXcER9iyK9mtGW+007YR4Tap8tbzDCrbM/68xOYNyVUYRCL3ANXEVAhB/PI6aA=@vger.kernel.org X-Gm-Message-State: AOJu0YwX1w65b6FDKlMWpKf5YkfVFIPJR+iv6LPbhQ04S1Rqdiblhilv b41jEUwK5NiZL/kZlIWmn0qdGmI8tg80yZ3pTw87IVmT8f5XXCGmTY01 X-Gm-Gg: AeBDiesiGPAaos6qVYoSWMKwA8A0+PrsPFrvy2BE03ScUZECcp5mjnspl7X3WE2MmVY vFOfE0G/pAqQe5f0dAlvULiKCw4PpVV3XIbgrGVpgEP/25564ICneySYB3S1ah5emS2efxmOMRe d8CX0qP0QCWLb7TNdYbBVR6DCgWThJxiMGe+kpf2g+KYJ2idxzIT2wUy1IwDG/DssnO2cH+0Z8Z 7uOgc3EWf+6ZqOJhc1FKD9OVqB9WDDRnStuIZn2TsESHdJVg1j9lKDHZYJ1ZjSyzi+M3yaUAbJb KPIbqhX9k4xDL73rUJwfDPflMySUvLCfVuGuWjtLV5G5YiMO/S/HO+7/8eBn6p5eYrcNZgVEOoE pAOXr/7bmCzh8BNHT410eg9lxVedgjECz4oxn50+ABZyZk6eE9vCsEtBpKAdr/by2VgWWvS0gr3 4bqC48tUzhbCb+zI93F2M+Zx3hB8TnIktRYw55Ncn/vmPQHOIPkiLJpFnsEWNWtpfW6G3ceUKww mZnoeSiDEGTxdwmJzkq5l2xThoVg67qZdtT/LpoRvvvdQqh3b4hk5UIGdTP7bilHS6RyEs= X-Received: by 2002:a05:600c:4652:b0:489:a4:e578 with SMTP id 5b1f17b1804b1-48900a4e944mr303852385e9.14.1777277912730; Mon, 27 Apr 2026 01:18:32 -0700 (PDT) Received: from ahossu.localdomain ([82.78.232.184]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc14a61asm712652115e9.15.2026.04.27.01.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 01:18:32 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: error27@gmail.com, luka.gejak@linux.dev, Alexandru Hossu , stable@vger.kernel.org Subject: [PATCH v3 2/3] staging: rtl8723bs: fix OOB reads in IE loops in issue_assocreq() and join_cmd_hdl() Date: Mon, 27 Apr 2026 10:16:25 +0200 Message-ID: <20260427081626.3393697-3-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427081626.3393697-1-hossu.alexandru@gmail.com> References: <20260427081626.3393697-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Two IE parsing loops are missing the header bounds checks before they dereference pIE->length: - issue_assocreq() walks pmlmeinfo->network.ies to build the association request. If the stored IE data ends with only an element_id byte and no length byte, pIE->length is read one byte past the end of the buffer. - join_cmd_hdl() walks pnetwork->ies during station join and has the same problem under the same conditions. Both buffers are filled from AP beacon and probe-response frames, so a malicious AP that sends a truncated final IE can trigger the issue. Apply the two-guard pattern already used in OnAssocRsp(): 1. Break if fewer than sizeof(*pIE) bytes remain. 2. Break if the IE's declared data extends past the buffer end. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Reviewed-by: Luka Gejak Signed-off-by: Alexandru Hossu --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index 884cd39ec756..c646dc2a1741 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -2931,7 +2931,11 @@ void issue_assocreq(struct adapter *padapter) /* vendor specific IE, such as WPA, WMM, WPS */ for (i = sizeof(struct ndis_802_11_fix_ie); i < pmlmeinfo->network.ie_length;) { + if (i + sizeof(*pIE) > pmlmeinfo->network.ie_length) + break; pIE = (struct ndis_80211_var_ie *)(pmlmeinfo->network.ies + i); + if (i + sizeof(*pIE) + pIE->length > pmlmeinfo->network.ie_length) + break; switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC: @@ -5324,7 +5328,11 @@ u8 join_cmd_hdl(struct adapter *padapter, u8 *pbuf) /* sizeof(struct ndis_802_11_fix_ie) */ for (i = _FIXED_IE_LENGTH_; i < pnetwork->ie_length;) { + if (i + sizeof(*pIE) > pnetwork->ie_length) + break; pIE = (struct ndis_80211_var_ie *)(pnetwork->ies + i); + if (i + sizeof(*pIE) + pIE->length > pnetwork->ie_length) + break; switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC:/* Get WMM IE. */ -- 2.53.0