From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BFD639A7E9 for ; Mon, 27 Apr 2026 08:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777277920; cv=none; b=oR/voSor0SMME0AXBYY6WCccLaz1UNV9Pfm7GJGquztuxpseY67iqM5IfseHmHvO3ZtaShaNxRZR0uG921Q+BpFfrVjc+jWR7Yv1WIn2OOzMV6Id/ArAVnFILDWDMrG4VRqSGqcoQIJg8DxSq+PLs40p7Ftv4Sih4BYqrkvpVds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777277920; c=relaxed/simple; bh=QsWgV/TRc8h5FUj2uOm4q4TApmuKuKTXIme2FfHuqZM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ms4uZDDVEiYkg1M0t9TQ840HKaFue8UgivbkAXiYpfMTmoM2TplZkVZNXfVfXP9EDrLxbnALE3m6podJB9gQk+7Ty4kQgoTeV11UOEj7iRYndq2MwZt8ysIPnxqLhjsGL/rp/iII5621DEJowuHXDQusKCGirYE3xrmj+OwmZFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BiWf0YJi; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BiWf0YJi" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso82791405e9.2 for ; Mon, 27 Apr 2026 01:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777277917; x=1777882717; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HVlRFyF005cdj3KbEszpkmE7tTQiTu1k1/BY4S0J3Oo=; b=BiWf0YJiQhOBp3HBblmFm5xmdTKRLB2cWo4h/5ehzjk4YWCdanQsNeUtfGOW0aHEBL FkqFO7B9UqTCoBi4oNTpwo6s3how0BoVno6StGolSEAMz2qxh17ui0+xRt6gJxfjDEie QfbtFZrqjSCziMkeAsMIrMAUX6H3a2/uUfh/toowOH6wQX7zAUTg2p/prRiyInde6aH3 FUfW8Inzx+BJxqPOcr5XdCiVkm+Hib57i+fSWVWCjwqno/SAYzLsrANlPv3yrzFxIuLL Z2kS/8bUk+NrEqULF0HplNp6vEgQacqkTDWCDVEmimMROsX2gItrkWLB/Y5YhsMK3U/M kYyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777277917; x=1777882717; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HVlRFyF005cdj3KbEszpkmE7tTQiTu1k1/BY4S0J3Oo=; b=RFB/AIyw6cdDCQrUadmrzmL4SY00zx8EXirsEsU7/jmQyYUv5V1j2AjY6/+Pv+BSVM WURTzQweVA4uC4gR6XPG1AyqkZ8s0ZKfSue00wDwEDVvzokYJpViN/8XLsCIHOWM5Nu0 XFfFr9+231C6wUaaFMUUBRTcpejYHIpyeWSrKFMO5ABQjvwsJwL0MOiZMhnwYvY9Sapg GioCDbbgiO/7qKB0xnZdWlcfWRobf0CsBs9SdCk8fK0SSF4WyuIe2COHXy/pVEwcQIN7 Z8yZQ/heKYYMZSQ4yPnVA3UBi2tDpdRNKl3xEPJLra/bcejEsTs0YZVuW8tXfkHICkct 3u4g== X-Forwarded-Encrypted: i=1; AFNElJ8Co+6CzSwTePVA2ObNtJn8qTXNQL0E2ybsUKH1jIKMvyMqHX9ZP8wiylxZIpBTDd7fsdw+mDGZhRY54Ko=@vger.kernel.org X-Gm-Message-State: AOJu0YxZgcl6m7R0UYyFc876hzYW5GPZecf/HZAv65zu8RiQVQtCvUJm 4ukGo4hHtFVapQ/ca4cH5GJng+3p2nxwTHs3rWNKeWAU7c3cbLWK4caJU5CoxEde X-Gm-Gg: AeBDievh/egoLODl/fxjKoynWdFCgtvoyRQb92UBswwRYa8Ea/m+ABXclUj9ncVILpr 1Omiv6RSbVz/wlSiiY9VCCMMH0xkXgU4309QsPLAjND6heYTYxdPbu/PxrehHgYIS9XZ1MhZzio bTtN1qlnRowvOSTjamCS93CqdNR0oSzn4opZutRTH2Ufw5wyw9V0scO5lYM/Mc79pMxMo++dGyA /UbED4clcJWj8LjbrEUnxJCw3MLxiW+X5RGtOioKcQH4/15z180ScmzZ0PC75fR+tJ5ApDcfSlw pgBaZZkwFRoWVxp6sOWAJQLDcJoCFC+wTuX2wghKHpWqr88HMSfmdqYqH04+jbATY59rTbhgDcw 0KA8bPeKZGNJ6+l1ht9iMEDD+hROqE1h9CbXEKTeZ4YI69q2o7fvwUd+lzlHksFYLbkSGXHc2N3 gvR/D2jilZbKtdxBpvRZIyglfLh2WANiRe23i/508xDwtweOts1WF3cmzOm/EaBFz0qj4tHyWar EfkvwmX1devnP6RPYnEwGdVkdI/j1GLW68Ktpgdt5JTvr/HJU02QNZ+Jw9p25+gQt4DCLs= X-Received: by 2002:a05:600c:548a:b0:48a:75b9:b0bc with SMTP id 5b1f17b1804b1-48a75b9b0c5mr734945e9.29.1777277917225; Mon, 27 Apr 2026 01:18:37 -0700 (PDT) Received: from ahossu.localdomain ([82.78.232.184]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc14a61asm712652115e9.15.2026.04.27.01.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 01:18:36 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: error27@gmail.com, luka.gejak@linux.dev, Alexandru Hossu , stable@vger.kernel.org Subject: [PATCH v3 3/3] staging: rtl8723bs: fix heap buffer overflow in rtw_cfg80211_set_wpa_ie() Date: Mon, 27 Apr 2026 10:16:26 +0200 Message-ID: <20260427081626.3393697-4-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427081626.3393697-1-hossu.alexandru@gmail.com> References: <20260427081626.3393697-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit supplicant_ie is a 256-byte array in struct security_priv. The WPA and WPA2 IE copy paths use: memcpy(padapter->securitypriv.supplicant_ie, &pwpa[0], wpa_ielen + 2); where wpa_ielen is the raw IE length field (u8, 0-255). When a local user supplies a connect request via nl80211 with a crafted WPA IE of length 255, wpa_ielen + 2 equals 257, overflowing the 256-byte buffer by one byte into the adjacent last_mic_err_time field. rtw_parse_wpa_ie() does not prevent this: its length consistency check compares *(wpa_ie+1) against (u8)(wpa_ie_len-2), which is (u8)(255) == 255 when wpa_ie_len = 257, so the check passes silently. Add explicit bounds checks for both the WPA and WPA2 paths before the memcpy, rejecting any IE whose total size (wpa_ielen + 2) exceeds the supplicant_ie buffer. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Reviewed-by: Luka Gejak Signed-off-by: Alexandru Hossu --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index 098456e97c96..3d930d9af184 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -1443,6 +1443,10 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *padapter, u8 *pie, size_t iel pwpa = rtw_get_wpa_ie(buf, &wpa_ielen, ielen); if (pwpa && wpa_ielen > 0) { + if (wpa_ielen + 2 > sizeof(padapter->securitypriv.supplicant_ie)) { + ret = -EINVAL; + goto exit; + } if (rtw_parse_wpa_ie(pwpa, wpa_ielen + 2, &group_cipher, &pairwise_cipher, NULL) == _SUCCESS) { padapter->securitypriv.dot11AuthAlgrthm = dot11AuthAlgrthm_8021X; padapter->securitypriv.ndisauthtype = Ndis802_11AuthModeWPAPSK; @@ -1452,6 +1456,10 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *padapter, u8 *pie, size_t iel pwpa2 = rtw_get_wpa2_ie(buf, &wpa2_ielen, ielen); if (pwpa2 && wpa2_ielen > 0) { + if (wpa2_ielen + 2 > sizeof(padapter->securitypriv.supplicant_ie)) { + ret = -EINVAL; + goto exit; + } if (rtw_parse_wpa2_ie(pwpa2, wpa2_ielen + 2, &group_cipher, &pairwise_cipher, NULL) == _SUCCESS) { padapter->securitypriv.dot11AuthAlgrthm = dot11AuthAlgrthm_8021X; padapter->securitypriv.ndisauthtype = Ndis802_11AuthModeWPA2PSK; -- 2.53.0