From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11DDD39B955 for ; Mon, 27 Apr 2026 08:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777277994; cv=none; b=M1TXwCRd0offN3B9e4e/VlIlsUg8BrTp+tBQ6Q4OnrK/Ai5WWKKcBPdo0iY6ydy4sLiFw9UiPyCq4RsYCx0tTfe9UoAXggJULxjr/Qznbvp4CYlfJjeKgzvRhLe2TUr/tmg9KlAGUo6sSJ7ATohLcl2Tszf6K3WxSTlB2eVvTwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777277994; c=relaxed/simple; bh=+YeUIV1+wtcPKuOvB4oPRVaxMCPwWFWxjyfdg1SSC4U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dc90cH3RvmMPHkkCOSzfc7/3ie9e8IriNbdklvrjveMJlNdoIlKJwD6bhswd/HWNHJUKfWo8NGCQNYWagwI/YWVLocOrulBNW5ib8PCNnEKXBUQXevrk2O/n1+Uy0Y/rJBPITPiIrRsC6rGHh5nSgKqsk9yu1BSgpkw/kFb4wRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aYDmNIJD; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aYDmNIJD" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-48896199cbaso98765525e9.1 for ; Mon, 27 Apr 2026 01:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777277990; x=1777882790; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nMczc9e1ajSbK4Mrr/Qq92dYlg6aGcU3H3gAe4DnWL8=; b=aYDmNIJDmeG5kuWBwm+tc7QFXop2w4cElQd/tU/p3it5otFdb5Tdae2KIAKDZvSxMC MMxbR6B1ioDUrWc5yfB4GwPMSDdr4HZb/BqZ5suZNKOBIS7x/Hu/J905h3uXD6NA+Q7S a9hsrfjPzEU3qzoFHy4F7U6frGVCbF+66VAQ7y9L0Lo462j23SOAIwJLMW/TJHS/ic+q g68cmb09Y8gVMmmPXQ2eJ3NJkUJ2a8tutS0ryekNKvMyex+eG1+Ozv3qDwlH77sP2Fu3 QMeX2FGoRVBuLLXHQ1Gycps6QCRJU2pJMiN1Apykw5ObmbW0zPQuggao0o+W/flMOJj2 5kwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777277990; x=1777882790; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nMczc9e1ajSbK4Mrr/Qq92dYlg6aGcU3H3gAe4DnWL8=; b=S0dZC3Ai9jgQFhcq0A50ztvoLT6V5963kiO3J2o738VSagcNwOrhWG2gZ/FcZx4zGK ofAyL2oQhXOwMaSFleYY+4n9mY1G7zhYXb+QTpuWJ9CzwfVci1h4+s/Ir1CN3sCv+bEL /qszHSnI9CPCsDDxoCEaeWSBjiQcYYZKN5DQXdoRqN8s6WFXYe//RMV93ObmiSPCBEf2 t5c3xdbbwyYsguTrWBbd5rPywwc/XD9kiLk2N4Ylf0ukqWpT8s5yDQFzFmeJ5xNn3nii FBsIyjypiXrh/XVBgWEHxk6Iy/F4ikzLBvkX+9C4YqM3RaJ65VtZtvPuCo3sI3T2WuBd xX1g== X-Forwarded-Encrypted: i=1; AFNElJ+HmLQhkkrVUjAkhigEs/zQIfhhS6FdmsS+EwOpxLt3w2vnODTqOqmVtwtUXeO+AzH/S9Hpx19uHyoggjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzqH9/Yc8kLSvEPlNZiaEjseiVAj7gs1fDMXJpTKUBj1eAZCEMQ rLaWcXmd1xaWvrkvBQFn6Ei41Jy4EFonjc8Jd89WMWWRi0a/L2HTT6gZ X-Gm-Gg: AeBDiet1SVkenrBltHo7ligIrQnJrISLQIGzGCKP4sTPJFMHLFAQt+gpHy2RkoCmkzE NxnCBZx1jnu/++erRrHbLIwIASe/NqwYrwMJZsLOXr0pWCOZdpqjnJg/0a/K8lKRBpvYyvbp10w cD2ZfesUDn/7vfbrmhLwWtAAS2cQR0otuJbPNRGUwLvzM0GRrnyhDA1/Fed4XOPZNgIFIGLvTaB YThPAQr9dnsL70PE01Ubdb1Z/Gv8QqIHnUprmP4L4PCb5b7NYvEwwzvQ4T5OSTUVKK9FKJi2y7A dbSMz5ROLJ3XLRl8lVp0biQahgThsVWrEKc4iNVrYVjTF6ahfyNsZCDI5D2M8+RRVHTfXCXdvCG eLqWTnpkIREBGYff1Mw5rqXEQMdN1i7nUJ4qP2zraxFycK89ng4N6bTyafgzjcMss+aK6F3xpza U4hf+8IeIgMsYb1eJj15+GUI6Vz7qEycjDRYqnRMO1D3aFMYCktTPJ1lxPJMTmiM9wNndUNa+91 RlYsAnTAABlUavOuVlY11iGBLN7WHdvZP9TLcL3vGdEJLoEGGUH0homtn3iX6+BrH9qkmw= X-Received: by 2002:a05:600c:c090:b0:488:9e54:94c0 with SMTP id 5b1f17b1804b1-488fb74e130mr452914045e9.8.1777277989920; Mon, 27 Apr 2026 01:19:49 -0700 (PDT) Received: from ahossu.localdomain ([82.78.232.184]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e3a18csm90455670f8f.20.2026.04.27.01.19.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 01:19:49 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: error27@gmail.com, luka.gejak@linux.dev, Alexandru Hossu , stable@vger.kernel.org Subject: [PATCH v2 2/2] staging: rtl8723bs: fix OOB read in OnAssocRsp() IE loop Date: Mon, 27 Apr 2026 10:17:48 +0200 Message-ID: <20260427081748.3407939-3-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427081748.3407939-1-hossu.alexandru@gmail.com> References: <20260427081748.3407939-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The IE parsing loop in OnAssocRsp() advances by (pIE->length + 2) each iteration but only guards on i < pkt_len. When a malicious AP sends an AssocResponse whose last IE has only one byte remaining in the frame (the element_id byte lands at pkt_len-1), the loop reads pIE->length from pframe[pkt_len], which is one byte past the allocated receive buffer. Additionally, even when the header bytes are in bounds, pIE->length itself can extend the data window beyond pkt_len, silently passing a truncated IE to the handler functions. Add two guards at the top of the loop body: 1. Break if fewer than sizeof(*pIE) bytes remain (can't read header). 2. Break if the IE's declared data extends past pkt_len. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Alexandru Hossu --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index c646dc2a1741..68ce422305ed 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1406,7 +1406,11 @@ unsigned int OnAssocRsp(struct adapter *padapter, union recv_frame *precv_frame) /* to handle HT, WMM, rate adaptive, update MAC reg */ /* for not to handle the synchronous IO in the tasklet */ for (i = (6 + WLAN_HDR_A3_LEN); i < pkt_len;) { + if (i + sizeof(*pIE) > pkt_len) + break; pIE = (struct ndis_80211_var_ie *)(pframe + i); + if (i + sizeof(*pIE) + pIE->length > pkt_len) + break; switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC: -- 2.53.0