From: Furkan Caliskan <frn1furkan10@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
vschneid@redhat.com, jstultz@google.com,
Furkan Caliskan <frn1furkan10@gmail.com>
Subject: [PATCH] sched/deadline: Fix stale comment above yield_task_dl()
Date: Mon, 27 Apr 2026 12:20:30 +0300 [thread overview]
Message-ID: <20260427092030.28975-1-frn1furkan10@gmail.com> (raw)
The comment above yield_task_dl() states that bandwidth reclaiming is
"planned for the future". This is now obsolete as GRUB-PA has been
implemented.
Update the comment to reflect that yielded bandwidth is now actively
reclaimed for power saving and scheduling efficiency.
Signed-off-by: Furkan Caliskan <frn1furkan10@gmail.com>
---
kernel/sched/deadline.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 27359a1e995f..fba29af74107 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -2368,14 +2368,11 @@ static bool dequeue_task_dl(struct rq *rq, struct task_struct *p, int flags)
}
/*
- * Yield task semantic for -deadline tasks is:
+ * Get off from the CPU until our next instance
*
- * get off from the CPU until our next instance, with
- * a new runtime. This is of little use now, since we
- * don't have a bandwidth reclaiming mechanism. Anyway,
- * bandwidth reclaiming is planned for the future, and
- * yield_task_dl will indicate that some spare budget
- * is available for other task instances to use it.
+ * Yielding indicates that the current instance has finished its work
+ * early. This allows the remaining budget to be reclaimed by other
+ * tasks or used to reduce CPU frequency via the GRUB-PA mechanism.
*/
static void yield_task_dl(struct rq *rq)
{
--
2.34.1
next reply other threads:[~2026-04-27 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 9:20 Furkan Caliskan [this message]
2026-05-13 10:25 Furkan Caliskan
2026-05-13 11:54 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427092030.28975-1-frn1furkan10@gmail.com \
--to=frn1furkan10@gmail.com \
--cc=dietmar.eggemann@arm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®