From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE4A6366072 for ; Mon, 27 Apr 2026 20:33:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777322010; cv=none; b=Dbf4Duje13kky1KKe6o7y/is0sOmJWBH6TsblkZnkR/EDIHajM9W7O6yCP/uEb6YOXSjgBYnJnnbOLuC1pkBXeuOWgdxmDSeNzFY9mSqzWfnnLiryuUbvz2APohmnugqoE7Ugl8yarc2MRO8zDMC6nYO8Wnjb2Rr26bUjbwdqRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777322010; c=relaxed/simple; bh=YaJGQbpQ6MjSMX2sNG9+jirJnxmiHYUlmisNX7tDnn4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=caG4rsJddfXsAQJ5oYJF/uzzTqvowv63NUAN5f1ByqFEoc7UNBJlvcTy4aH3ZHdDMmiZAHKy0BfRuI0qC3s5vR3itIRhQYUqaqlELoFVRxoAIqWOaM0JUAPR4NvgK3IzUPzEQCNfJOBq8fNeg2+jFymOU35AJHp6/4/t4ZXc9K8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fHUErDSM; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fHUErDSM" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c648bc907ebso6956573a12.3 for ; Mon, 27 Apr 2026 13:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777322009; x=1777926809; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=T8ukke/PuH0j0OqYXoJI9DvAjkySK0Nck/KzrZl6Qp8=; b=fHUErDSMj1YmKoHnNiEvOR8zNwS7xhmTNal9kF1s54JuQ/ecvkhkbnJCLMkyv2VhfX G0qu0xlqrccyLlaexLHvM+R6C9Y12d4pCIuC2Rz8+E9rtjUSp07MFWKUA1dNi6RXpFEu 4/4wY1qhjE8iI0wlZRyrWkmqe/SPrs8wLKu0Lq2zbkEr6ZTEwunLKAxYhHOv0gOBb0HV vbm+pxO5ub9h2zwthNevD0Cn5U72/IjexQZi6eDehjfyeaTUnsgESyzDTQ1F8GaiWoQ7 VNbGcarPr2xx+b1nNT/nMA/lW48kcZWm3g7utIIEALVXioHeUxDACjxHXDh+6qjWUvkj tnfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777322009; x=1777926809; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T8ukke/PuH0j0OqYXoJI9DvAjkySK0Nck/KzrZl6Qp8=; b=AVz0TsJoBe6sTVCDWOr1BqlOtyEAdevFqAK7Ji4jG+yqQV8WnYjCev9x8NqsamPC2b VsjBpbtusiOr9kKeioLvvNJ60HLx36O44yRt5/BvJYLUw3tzmQt59hfqx+EsS+P1TwR5 12fveFkMiFdioHtmLXlwiAfrAoNEcz+74h6AaOJJxU5EvKVEbww5Xj5iXDPYwrnF1rsz qcc2ssXUoZtUNHmTAivvMZBRw1NTq92gu03NidAfE45jEao3bfCga6kN3tzgGayMt7xp b2Y/UkVcimOVcW9xEp+Z99lEeXHoP+wbL3hojqcXk1YT7qsxMDWIagQhugBoj3NJ89ob DFPA== X-Forwarded-Encrypted: i=1; AFNElJ/Qzl/7aikRluma23d8yooFgCCNvEfR3oCvFaos/xo0/s+i54/2oF0r8/mc8Fxae2F2P0y/WW84ZKNelU8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2afPv0T8t7VrZ1SRuqvzrWhwsD07UBRSGI6W8t4r8cli6Xypg CiEH3BLFme1IcNnMYPYUPCJzahxXe7gEjvvRRgY7cDoA6kbQ0sbQV2Ti X-Gm-Gg: AeBDievMUun5wbyTwsu5d66Nzy0f+GI8uJ+OwlJahVLsBv0cGSZjOx3pIuRqy+snLSp AkGrQXq/cCtd0/XCzvX+niGgMZOeauK37W55c/KHdlQknbZk3NmfSeia9aIXhg5EjMNoppcojXW wFK5OOJBQ+Qou3x0iR+Q1XBJ389JiCrXJMKqcr9uBtxBmrv2AKa43m49UC97zvv1hAqs5CEeb6g 0qzcDrt9VYjQChGQgqzA1Hqv08aDknQAELbyx4x/TxzvniBLYv+/1x1VvgEe+B3UEk+K2dKPl2e n4bPvLAVzc21SklPRL3ajan5wP2P9Ac2brMK+3rRlkuToOpS9Gw75tYGihHx4cupwdnEGs8NygM gtcOO8eTl+jKkegLBNwhNrzBhO+dkhTsM8aZovecUTDxU/9tEfQveVSATMnGjdGne1RkdbOaC9P v6z5DQYrNk+8rTf08BxP1q8e4anjSXSZtDLkDZcxz9vcm77IJwyb4= X-Received: by 2002:a05:6a20:548d:b0:3a0:cd5:82b7 with SMTP id adf61e73a8af0-3a39c46a108mr222749637.55.1777322008821; Mon, 27 Apr 2026 13:33:28 -0700 (PDT) Received: from Nighthawk.localdomain ([223.178.220.204]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-834dae00c58sm386080b3a.3.2026.04.27.13.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 13:33:28 -0700 (PDT) From: Sagar Taunk To: ojeda@kernel.org Cc: boqun@kernel.org, lossin@kernel.org, tmgross@umich.edu, dakr@kernel.org, aliceryhl@google.com, bjorn3_gh@protonmail.com, gary@garyguo.net, a.hindborg@kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Sagar Taunk Subject: [PATCH 2/2] rust: sync: atomic: clarify AtomicAdd safety comment Date: Tue, 28 Apr 2026 02:02:58 +0530 Message-ID: <20260427203258.22148-1-sagartaunk2@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The previous safety comment for AtomicAdd was marked with a TODO and contained a grammatically broken sentence that was difficult to parse. Rewrite the safety requirement to clearly state the actual contract: calling wrapping_add with a delta from rhs_into_delta() on a repr obtained via into_repr() from a valid Self must produce a bit pattern valid for Self. Signed-off-by: Sagar Taunk --- rust/kernel/sync/atomic.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/rust/kernel/sync/atomic.rs b/rust/kernel/sync/atomic.rs index 9cd009d57e35..b38d9a17f9e8 100644 --- a/rust/kernel/sync/atomic.rs +++ b/rust/kernel/sync/atomic.rs @@ -127,10 +127,9 @@ pub unsafe trait AtomicType: Sized + Copy { /// /// # Safety /// -// TODO: Properly defines `wrapping_add` in the following comment. -/// `wrapping_add` any value of type `Self::Repr::Delta` obtained by [`Self::rhs_into_delta()`] to -/// any value of type `Self::Repr` obtained through transmuting a value of type `Self` to must -/// yield a value with a bit pattern also valid for `Self`. +/// Calling `wrapping_add` with any value of type `Self::Repr::Delta` produced by +/// `Self::rhs_into_delta()`, on any `Self::Repr` value obtained via `into_repr()` from a valid +/// `Self`, must produce a bit pattern also valid for `Self`. pub unsafe trait AtomicAdd: AtomicType { /// Converts `Rhs` into the `Delta` type of the atomic implementation. fn rhs_into_delta(rhs: Rhs) -> ::Delta; -- 2.54.0