From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C9C53C0607 for ; Tue, 28 Apr 2026 20:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777406860; cv=none; b=u0tE91JCQGT+avw5Nenc/1UqfZsvPu6vwS84x104kqxx6ZoIK8mWarNJV82I81EkCaRqLzxRpi+Q6bnaAO62izCv87ZyqH1pKKb/8rIOlE5b+PqZ/xn54GkWi49pQD35P2LlX+nnLT27ryFX6DgTpfpmXWVboxUqOsTgl5EogyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777406860; c=relaxed/simple; bh=XO1A/HibqZZptlBWN5BCzJBPBBT6OtgGPpR1fmvJiA4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PyT2KqmpEedKxmnlMnDipIcffYR2SmskKU6eKkkWD+CbTClwwXs8oDzZjI6fez7Wv31gsIjuLAcCxabOzcMG+DXFe0+E3lrR5EK9ItH4CL/FChq5iPiVcOLEldeKc+Pg1/zdC6uENj0iljXniZJ4ZcDc8MQUm7pLUCyodYg5xaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=lgoFIlx5; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lgoFIlx5" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2de831d2b20so4561188eec.1 for ; Tue, 28 Apr 2026 13:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1777406855; x=1778011655; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wyEh8MUYI6uV1LBlX4TWKPlLf6Jaa4vkUqpt47EeXpM=; b=lgoFIlx5tLNJIADdHllLhe2CgooduUbz4JdRKVvEGiRC6/BorZMWXqS3GvbBGZqWtm b0OsNU5naFbwnHe0Rwn4QgHD9vWZAGcEwN5AIK/KqQoQgjkIqssTJ8Ldmhh71JUY0vRC ZcmLlxLpVf0PWsG1Qf++1bgkRLrhUL1oiva6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777406855; x=1778011655; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wyEh8MUYI6uV1LBlX4TWKPlLf6Jaa4vkUqpt47EeXpM=; b=GwiRS27u8RPqAfjQBpK+fkG19JDCwhPB895KDe+uyWZqhzuHbyG8FRkUTX/xKq6C0p QiR9V+rNuvzDqD1Gv1nn+grq2b2yIi9z2symmf19sOgbgF2RZU7wHPVR58b62v5ZfD/Z jo5Pfs/yBiCydVrGRhFlfVnEaBivR6EQLrfmzKBulsWw7b+mJl6dAUTsTEaYcB/w3bmu vUBdBuSFwocEKYrHz7ogR0IJjbDilzwixWUtrzDC8moicuTf+2no+MhZah3L/yWOCEOk 4vKrT+02sRUbU2N+/r6D0955DKGJw8e806+zseXYoqG+iinnSzw9m56J5wXVZdpnTPpH ZXZQ== X-Forwarded-Encrypted: i=1; AFNElJ/pdcFRHhpOjOYIKE3GrZlMfHg3+nhmzvKJuQaNoLvKsz0jqIBlzHZ488o0wkuhKjdKDrCVpn/KubFAM/w=@vger.kernel.org X-Gm-Message-State: AOJu0Ywl6aI3714qi56wzG8dyavcklCgXnNSvDtkry16Yr0TtGTbfEuk sGa7VFgUxtg7xFNobAAdTwlsOgwF+fp0lgWnZrJ81tRhH+soP2dtE9RbY9DHFGCumA== X-Gm-Gg: AeBDiet9e28ElqdrUwWxer4zL64mhTK5d+yWRi3KS9aZVz7unAHEJvwKpwGPklpxDkj gUg6PipRyNHiTPKyHHskjplkkztNYlWV4aOsMMQXf39B7TFsEyvwXpwSaxeO2SYD0DOOpi2cfpJ 34kWErPzK7cuRPT3LReHtQPJ6xYAtIi6wRyegP1f1gy/Y7ruftTBip+jPY8/eFRTDruQ/l3QgyR woeJmtaquXpICy/2WamR0Jg7lxTLsx/y29QsTqp9sIOFH12DupCLDC/Z5c+yYbhCHoANybANY5p ZSZIJTCH3f385prZfcVOuy229HxsLxFXWUOhCbZAzpcupKKQMfR7kRQYjQOscZ3d7Als4F6/QNO WzQufCVJw9aJbg3DaIhbtwVPkIveplnrCpqjH5zlUq20Rd20ApiDhleyyJsLOXCcYQT+L/gBsqo Sr8pSWpo7BTI9IMGeTOfaoyxC2qyru0cPEFGLzPPB76wcX86jgAvbKiznH3yXkUfiJT90pMvA2W BM9/ptmwJs= X-Received: by 2002:a05:7300:5707:b0:2ed:e15:c924 with SMTP id 5a478bee46e88-2ed0e15ce32mr1940281eec.32.1777406854721; Tue, 28 Apr 2026 13:07:34 -0700 (PDT) Received: from localhost ([2a00:79e0:2e7c:8:4ff5:9607:c7e5:48f3]) by smtp.gmail.com with UTF8SMTPSA id 5a478bee46e88-2ed09fb6b8asm3015155eec.8.2026.04.28.13.07.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 13:07:34 -0700 (PDT) From: Brian Norris To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Heiko Stuebner , Matthias Brugger , AngeloGioacchino Del Regno , Bjorn Andersson , Konrad Dybcio Cc: devicetree@vger.kernel.org, Doug Anderson , linux-arm-kernel@lists.infradead.org, Tzung-Bi Shih , chrome-platform@lists.linux.dev, Brian Norris , linux-rockchip@lists.infradead.org, Julius Werner , Alim Akhtar , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/7] ARM: dts: rockchip: Add #{address,size}-cells to Chromium-based /firmware Date: Tue, 28 Apr 2026 13:06:54 -0700 Message-ID: <20260428200712.2660635-3-briannorris@chromium.org> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog In-Reply-To: <20260428200712.2660635-1-briannorris@chromium.org> References: <20260428200712.2660635-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Chromium/Depthcharge bootloaders may dynamically add a few device nodes to a system's DTB under a /firmware node. A typical DT looks something like the following: / { firmware { ranges; coreboot { compatible = "coreboot"; reg = <...>; ...; }; }; }; Notably, the /firmware node has an empty 'ranges', but does not have address/size-cells. Commit 6e5773d52f4a ("of/address: Fix WARN when attempting translating non-translatable addresses") started requiring #address-cells for a device's parent if we want to use the reg resource in a device node. This leads to errors like the following: [ 7.763870] coreboot_table firmware:coreboot: probe with driver coreboot_table failed with error -22 Add appropriate #{address,size}-cells to work around the problem. Note that Google has also patched the Depthcharge bootloader source to add {address,size}-cells [1], but bootloader updates are typically delivered only via Google OS updates. Not all users install Google software updates, and even if they do, Google may not produce updated binaries for all/older devices. [1] https://lore.kernel.org/all/20241209092809.GA3246424@google.com/ https://crrev.com/c/6051580 ("coreboot: Insert #address-cells and #size-cells for firmware node") Closes: https://lore.kernel.org/all/aeKlYzTiL0OB1y3g@google.com/ Fixes: 6e5773d52f4a ("of/address: Fix WARN when attempting translating non-translatable addresses") Signed-off-by: Brian Norris --- arch/arm/boot/dts/rockchip/rk3288-veyron.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/rockchip/rk3288-veyron.dtsi b/arch/arm/boot/dts/rockchip/rk3288-veyron.dtsi index 2d6cf08d00f9..ca8e8e735078 100644 --- a/arch/arm/boot/dts/rockchip/rk3288-veyron.dtsi +++ b/arch/arm/boot/dts/rockchip/rk3288-veyron.dtsi @@ -18,6 +18,11 @@ chosen { stdout-path = "serial2:115200n8"; }; + firmware { + #address-cells = <1>; + #size-cells = <1>; + }; + /* * The default coreboot on veyron devices ignores memory@0 nodes * and would instead create another memory node. -- 2.54.0.545.g6539524ca2-goog