From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 341C83AF659 for ; Wed, 29 Apr 2026 12:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777465431; cv=none; b=rSG0Pun9WAQgzAJYFIt/GcMXZaoIUT68jMOvXR9Cui+areFzpDGJGAy8yl+h1f7m+fa4MzWnFZ3C1JvnRU6Rd1aBrn4sXNNlExkszRMi9cFITBtpvU35jPG6vqzoTdZvEyidSsA7D3zYPQvfksVRJSx7leHDc4Zyu8fHuK0+k7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777465431; c=relaxed/simple; bh=ncnLURwuItKNKYvI3sRiEpQr98lYszQWZjbc8hBirlU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p9fqkDFrMQjmAjuKAEb1inATLxp/tDVZQ9z8pPeHcju/8NTq7O0PSQjyNdebGNelyITz3RC23FFGb/cbkMIslxHtMRkVg8wf9My606yGC/gew1YYWilDlcd3vT/zMh2urxJlElbiq4pkDQdqq4fjnG/BvQPqwB+EHFyqVoCWAfA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Y+kSlHGx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AJQ/VcvN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Y+kSlHGx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AJQ/VcvN" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63T8pufC3752544 for ; Wed, 29 Apr 2026 12:23:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GQzBC/3BZiZto/HF9Z6Ln6jPx6M4VZ9t5SZNzoPBWBw=; b=Y+kSlHGxmF/ZJb8E 98lPgib+s9Z8xRHx0cOwCPqIKnwVs7WGPW/8NnBCC3SUp9z7NzAo6AQZl8cycysV L4ShDKUKV+WOaDkZMhmQik2MZD1vBdNp9sE1C6c1e3BDAaOUyGeSv7rDNH6gugYi U6Q90zmRWHtFowJdWuWdGjUtf2w9aDCuRFr6ga4b7pvaY2eYOjVul/hzY5zv/cxJ gx97OHLv/tp4BJoWYxVZoDYOzh4g1v7/Xog1GgGQXwzt+NJCvMPEogLUjS/IhIN+ e6ATgl1ZY2IbcuxqQ2GdMmArzWnKreTRyn1IQYyNXA2C+j8s6MjP5+3D8owfcnWG G//bew== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4duch1hfpy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Apr 2026 12:23:46 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50d5d1c2289so266382281cf.2 for ; Wed, 29 Apr 2026 05:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777465425; x=1778070225; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GQzBC/3BZiZto/HF9Z6Ln6jPx6M4VZ9t5SZNzoPBWBw=; b=AJQ/VcvNAlBsHQNx06VKu0pfgS0WGe0d8Kx2QU2DeiVfrwgfIufXV+Ax/dyjsY4UZK lZyshrglloa7T6W8iK1Am7oVmLbhY3ucJlAm1jL0s5m9wpNeHeALvTeTTksqW5BjftY1 7m68D1p0lotsOsHj+HBEm6XSZSRxoE7gIcmeX3YZ/H9zwSPWiEzuxWOcmT7r0iIoDDpC zLRe9SitlpRWAxzH20ee+dMd1oqw8zxM1qc5RND1XGSB+Y0+diSjyqcwFyQ/y8Hevn5z NHDVFYvfXkurUZvqxofROsS/IaYbz8YHTCCGfxCoVmKlw2xx+ZyH8xTwkT+vny6Wh3aU 9ulw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777465425; x=1778070225; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GQzBC/3BZiZto/HF9Z6Ln6jPx6M4VZ9t5SZNzoPBWBw=; b=tIVtE9egUucd37O+zg0hIxaVDRWOLXc0L0v8qxxAzrM6JfIKeCF+EyzPu9izzLzw9R TRZbgzcMKWb0Wt7ojjNbwSEpZ6dP9Du6aEB1Wi5S1rjdqiZopmkPBmG7Ijs90zlk6lEl 3JMSSyj/xcUNRNO9W5P5XHhvRJCNsggU3mwycUjELNw+Dh2cK/3BCWONTq84+zsxNqwh 8Vgcp0jvOVPCXAjKBh2eg4zYVY3sndctncsiJxWkhggWC+REFomS7ozhawwJ0ErBdEB8 zoJD05V0BYCisPWIOY4GbKtwsi9twpW3ARdP9XAbRnVhZS+skDLRZn3dbmGHY59MUdl6 Opww== X-Forwarded-Encrypted: i=1; AFNElJ+oSqmtxSgzPsv3a/ZF7W7ydQeHIJa+oCrg6RDsqlffVde0Qy1xjjLRGDo2wU/8zzvqK8tit/F8Fj7kqjg=@vger.kernel.org X-Gm-Message-State: AOJu0YzYjhrlT3l0ZD0nIBJ3F641FoJhyys8PZeFDxliRZ1Qkvtfrmnw S7kCwbjTmjecWmtr+IkjXlzIuzcg/k435tFd2l0OpwdaC6jWGuD4BAWRPw3pMi2BGmhJdgSrnUh ZWgrV2YPEWpDxPx/qKw+PaiciEfwR4YAEFbA0MT1PzC7ZPv4uZ6gj1SOGwZgjm3w7Dl4NIp+IIG 0= X-Gm-Gg: AeBDieubn2fnFJcbrdyvodHP6B7Xyd+5eqskjjj1NyWZLlskKWYauqi3YROSM7Jr3Wq 2p87JyOiryLp/DJHz1lY0wRLmhT7rLPL4Ufu+3knKUFsMvjTz7phyopbm2Z/zNXd7Fj2bl8gy18 EWOvbYK/Is171HqDVQR1xysWBOMiO0RLnyDZ06esJrD1fMf2w9gIuI9zbJrwBtmUbXu2BxnQFhm vV6YIpRW+YpodlekTWnRohHiqxGeW7RxuHjQaAaEYqNPSe5d6cEXT6VG+xQetVbXo/bvDhp7H3a WHqMjlBLQKvzzgKs4CIy6A4cxXmQy+tAWvl3/r0WtGa5hVLgQT5XClva3fJg4T+HGKKJIW/ygIe /XlVoJLKeojtUF+79wrL2QX6QJFKzEXQ6A7p37KmPd0txAOG34FDrYOG64TGIUQ== X-Received: by 2002:ac8:57d5:0:b0:50e:5f36:1da0 with SMTP id d75a77b69052e-5100e1d5605mr97616831cf.49.1777465425328; Wed, 29 Apr 2026 05:23:45 -0700 (PDT) X-Received: by 2002:ac8:57d5:0:b0:50e:5f36:1da0 with SMTP id d75a77b69052e-5100e1d5605mr97616111cf.49.1777465424661; Wed, 29 Apr 2026 05:23:44 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:e9c0:e45a:1dbc:c82a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-447b4216dedsm6126438f8f.13.2026.04.29.05.23.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 05:23:43 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 29 Apr 2026 14:23:31 +0200 Subject: [PATCH 2/2] x86/platform/geode: reference the real node of the cs5535 GPIO controller Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260429-cs5535-swnode-v1-2-2bc5e17ddcf9@oss.qualcomm.com> References: <20260429-cs5535-swnode-v1-0-2bc5e17ddcf9@oss.qualcomm.com> In-Reply-To: <20260429-cs5535-swnode-v1-0-2bc5e17ddcf9@oss.qualcomm.com> To: Lee Jones , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Dmitry Torokhov Cc: brgl@kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3719; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=ncnLURwuItKNKYvI3sRiEpQr98lYszQWZjbc8hBirlU=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBp8fhK+OFpo209mHHrbsdhhWQnnhuS2ZMmUZ6kV aTyzSvazU6JAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCafH4SgAKCRAFnS7L/zaE wz8iD/9hGgYiGus/Nv2OdPHs0itk+oP5w9pIT6lptGbikox6Kzap4/6CuXG6+4qaAAa3xlvKTab 6RVQA4140EuI7kyg8EUVd/82bxdiEKuyM7NeygxKxrkjqO5TTFghQd0iAgTsDVlLQELp5SX8OQ7 Ib+z4QreILJRDiAeOP4eCcalkMqzdmlRdSyFj71b2q5ybJAAjvsv65Nqvlz7uPk3jmLsTZ7IfGB 4RZQO6GDFvzPPhHw1Y6Eo75jca82GR/JQVUDAVdgfUF+VjamQt4Oz/72yjf9/ikbvvP0OTFBNqb oM/JtwhD3R4NdegZUghMtg0KObgFv8u14slF1SwIb2rDm555Vm+07jsAJB5QF8x/Cez9XaoCY8E xndWXByY4giIPnZ0WrOo8v2PNTrKnfE1PM0epmrUwbvvOEbpl43WfkFVsKr4rbEQJ1sf1Ddyfsz ODuYos433U/eh2psCSM+uYbUNUQiITP8bkZUKhhBJqI+BmZymJ26/rSEZxjS6mDX0ZbwOhkfrzu 3g6/hqdscabUSLJgtKcbgDtDhLgqhItN1iieMaqigczf60jMij1v0YriOggK7ZAVD9xhVDzS2q8 BGbhNry+S79gLoyguDIwcnQPP58VE0oLy3Boisc/k3lqaZzTJXjFlYBqpzd6CndDfH3zubhb4Wh AhkzHfcOVAN3Qww== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=arGCzyZV c=1 sm=1 tr=0 ts=69f1f852 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=Wi0uR1pbJS1IZyDR8ywA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI5MDEyNSBTYWx0ZWRfX917dPvIUq4qU Yd5YbK1n501zXleSliNyw6/5IUPUZ5h44xTMvV0ouzeMAJspX6v9KqHKTVBq/NjJBdd+aaUY5bD IHQTMctzsBJ1yq6GlO7OcW27uRdSkGkILSs2Io8Ea9tzWfuaJqXfHlhbeA8MrgYTjOwYispIbBI 7EfOZJlIyEFULdgGEVzATIgXvP5OBwhlMli+ulLBzUwelsFd2+mowYNOfmJ7wOf3XEbM+DvlHea qtP3uFhTqAgSw19tH7K3EFyKndkjJhecxde4Ol+coA3ky8h6JBktj8NwrRjLYfG+GbxBW4q/DF3 TxTPglq2XE5WkO0PZtEMQP56IJDYjpbxsgRdYXzhPOMCvnJBv5VpJb/u5dqkgrVf7Dkdwchuhqo AdEwe2+FPGKhQPwhkPL0OH1vwvD3v3wEqnHU6In5MtiLMi8OaEiRa64n3JeOtlqhImqgAuLYw7t c6gMlldryjAWH/1DCzA== X-Proofpoint-GUID: qVdoiX1kzSyzJSxYQNN3zlYjIdHEP2cF X-Proofpoint-ORIG-GUID: qVdoiX1kzSyzJSxYQNN3zlYjIdHEP2cF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_05,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604290125 We now can access the address of the software node associated with the GPIO controller cell of the cs5535 MFD device. Make it the target of the GPIO software node references in geode-common.c. Make sure the cs5535 driver is built-in for all boards selecting GEODE_COMMON. Signed-off-by: Bartosz Golaszewski --- arch/x86/Kconfig | 10 +++++----- arch/x86/platform/geode/geode-common.c | 12 +++++------- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index f3f7cb01d69d022538d283f6c7049ba8bd4c3792..1b3cb3d92bdeb0e02f249e1b4801f06fb5fd8648 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -3072,7 +3072,7 @@ config GEODE_COMMON config ALIX bool "PCEngines ALIX System Support (LED setup)" - select GPIOLIB + depends on GPIO_CS5535=y select GEODE_COMMON help This option enables system support for the PCEngines ALIX. @@ -3080,21 +3080,21 @@ config ALIX ALIX2/3/6 boards. However, other system specific setup should get added here. - Note: You must still enable the drivers for GPIO and LED support - (GPIO_CS5535 & LEDS_GPIO) to actually use the LEDs + Note: You must still enable the drivers for LED support (LEDS_GPIO) + to actually use the LEDs Note: You have to set alix.force=1 for boards with Award BIOS. config NET5501 bool "Soekris Engineering net5501 System Support (LEDS, GPIO, etc)" - select GPIOLIB + depends on GPIO_CS5535=y select GEODE_COMMON help This option enables system support for the Soekris Engineering net5501. config GEOS bool "Traverse Technologies GEOS System Support (LEDS, GPIO, etc)" - select GPIOLIB + depends on GPIO_CS5535=y select GEODE_COMMON depends on DMI help diff --git a/arch/x86/platform/geode/geode-common.c b/arch/x86/platform/geode/geode-common.c index 1843ae385e2dc038fde6fb02f6de0b818e22d8dd..679b4b07b790db3ce1c06bd6639bba7516ca3f71 100644 --- a/arch/x86/platform/geode/geode-common.c +++ b/arch/x86/platform/geode/geode-common.c @@ -9,15 +9,12 @@ #include #include #include +#include #include #include #include "geode-common.h" -static const struct software_node geode_gpiochip_node = { - .name = "cs5535-gpio", -}; - static const struct property_entry geode_gpio_keys_props[] = { PROPERTY_ENTRY_U32("poll-interval", 20), { } @@ -44,7 +41,6 @@ static const struct software_node geode_restart_key_node = { }; static const struct software_node *geode_gpio_keys_swnodes[] __initconst = { - &geode_gpiochip_node, &geode_gpio_keys_node, &geode_restart_key_node, NULL @@ -66,7 +62,7 @@ int __init geode_create_restart_key(unsigned int pin) struct platform_device *pd; int err; - geode_restart_gpio_ref = SOFTWARE_NODE_REFERENCE(&geode_gpiochip_node, + geode_restart_gpio_ref = SOFTWARE_NODE_REFERENCE(&cs5535_gpio_swnode, pin, GPIO_ACTIVE_LOW); err = software_node_register_node_group(geode_gpio_keys_swnodes); @@ -143,7 +139,7 @@ int __init geode_create_leds(const char *label, const struct geode_led *leds, goto err_free_names; } - gpio_refs[i] = SOFTWARE_NODE_REFERENCE(&geode_gpiochip_node, + gpio_refs[i] = SOFTWARE_NODE_REFERENCE(&cs5535_gpio_swnode, leds[i].pin, GPIO_ACTIVE_LOW); props[i * 3 + 0] = @@ -188,3 +184,5 @@ int __init geode_create_leds(const char *label, const struct geode_led *leds, kfree(swnodes); return err; } + +MODULE_IMPORT_NS("CS5535"); -- 2.47.3