From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
To: Srinivas Kandagatla <srini@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Johan Hovold <johan@kernel.org>
Cc: linux-kernel@vger.kernel.org, brgl@kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Subject: [PATCH v3 3/9] nvmem: check the return value of gpiod_set_value_cansleep()
Date: Wed, 29 Apr 2026 17:43:18 +0200 [thread overview]
Message-ID: <20260429-nvmem-unbind-v3-3-2a694f95395b@oss.qualcomm.com> (raw)
In-Reply-To: <20260429-nvmem-unbind-v3-0-2a694f95395b@oss.qualcomm.com>
GPIO setters now return integer values and can indicate failures in
lower abstraction layers. Check the return values of
gpiod_set_value_cansleep() calls in nvmem core.
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/nvmem/core.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index c18c7bb94a13b20ad27ec452a2b9fe80c2a4f843..61f7484f96f3a89450686745c1efad8fc24c667e 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -64,16 +64,22 @@ static int __nvmem_reg_read(struct nvmem_device *nvmem, unsigned int offset,
static int __nvmem_reg_write(struct nvmem_device *nvmem, unsigned int offset,
void *val, size_t bytes)
{
- int ret;
+ int ret, written;
if (!nvmem->reg_write)
return -EOPNOTSUPP;
- gpiod_set_value_cansleep(nvmem->wp_gpio, 0);
- ret = nvmem->reg_write(nvmem->priv, offset, val, bytes);
- gpiod_set_value_cansleep(nvmem->wp_gpio, 1);
+ ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 0);
+ if (ret)
+ return ret;
- return ret;
+ written = nvmem->reg_write(nvmem->priv, offset, val, bytes);
+
+ ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 1);
+ if (ret)
+ return ret;
+
+ return written;
}
static int nvmem_access_with_keepouts(struct nvmem_device *nvmem,
--
2.47.3
next prev parent reply other threads:[~2026-04-29 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 15:43 [PATCH v3 0/9] nvmem: rework nvmem core and allow unbinding with active consumers Bartosz Golaszewski
2026-04-29 15:43 ` [PATCH v3 1/9] nvmem: remove unused field from struct nvmem_device Bartosz Golaszewski
2026-04-29 15:43 ` [PATCH v3 2/9] nvmem: return -EOPNOTSUPP to in-kernel users on missing callbacks Bartosz Golaszewski
2026-04-29 15:43 ` Bartosz Golaszewski [this message]
2026-04-29 15:43 ` [PATCH v3 4/9] nvmem: simplify locking with guard() Bartosz Golaszewski
2026-04-29 15:43 ` [PATCH v3 5/9] nvmem: remove unneeded __nvmem_device_put() Bartosz Golaszewski
2026-04-29 15:43 ` [PATCH v3 6/9] nvmem: split out the reg_read/write() callbacks out of struct nvmem_device Bartosz Golaszewski
2026-04-29 15:43 ` [PATCH v3 7/9] nvmem: simplify nvmem_sysfs_remove_compat() Bartosz Golaszewski
2026-04-29 15:43 ` [PATCH v3 8/9] nvmem: remove duplicated reference counting Bartosz Golaszewski
2026-04-29 15:43 ` [PATCH v3 9/9] nvmem: protect nvmem_device::ops with SRCU Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429-nvmem-unbind-v3-3-2a694f95395b@oss.qualcomm.com \
--to=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®