From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C26D37F8C5 for ; Wed, 29 Apr 2026 15:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777477438; cv=none; b=hfkKPcgHSXM/JzTUxRtbKOuAHeooiMUd6L6W5E9c/nXH6ZxWuWurVIGD1jG/qKD1GmECFhTU8az+L8PffsokqQYe3vTQU1G2S67KMgpYzAz+uBZwViqLO75GD5UOjI9ppd6I486WvBJDFIG4Z9e5v99HOrYRVj9pWM874nviyTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777477438; c=relaxed/simple; bh=KZCWEvO63oX1FsDdFQQdyHnksuMOPYlcREE3/YRGNHE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KM+8nEXwdgNNnQRnOsBYYM4ZpvwVIIMt9VtGg0G5D6NxMjE70cRPc3WdVg89fP8pUKmRPA3lVf2oS4ZcmZZquRhQrKBfR9MxXxYMOavHsf7TqWqa7N+vhnbZnEwHVv3y6lxRnHwPlDpiyWr16+vGdbftvfg6L7veXVvqwn0G6BI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OK5exfgc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G4VsPLNV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OK5exfgc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G4VsPLNV" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63TFabuL1721209 for ; Wed, 29 Apr 2026 15:43:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Vlf4PlfS5tzFdpwjI53mxhIfEkjVjBfwJFd4T/6BeLw=; b=OK5exfgc21fRZg8N 50Dl1tWtvNwtONEuKwpoHNIiOjyOyN+B6upfWtNBK1/X76QrCjCzSrkfYUo+fL5i ZYHfutYPdlQsTol+0a5Z0W7O4v9pQj8qRWqDIGhn+uXC6mn2KEsCqxvcVP824ilv TiyHTlUG4slIvfoX1TXrvODY8Gb5Qjonqn5n7nSMoterEXPYgjPNiiSJsSKS8COu Y4jC7P7kt+jruTFq66mVyqe0UOsm5j1Mb21HkMA/odfwmakBkcKcP4vZ+aWq1V7x KY5caRfY6tZgTQq/NahHrp95Jx4/p6nt83CzXo4LJcI5+yX1y5zFFWMj19M7E5is 7CzcNQ== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dua732r0f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Apr 2026 15:43:50 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5662a21d35bso26042644e0c.2 for ; Wed, 29 Apr 2026 08:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777477430; x=1778082230; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Vlf4PlfS5tzFdpwjI53mxhIfEkjVjBfwJFd4T/6BeLw=; b=G4VsPLNVuq79AwxWii3tu2uLH80x4e1KOmlEGXvfza75VH1zvadUWXtfenJY2XGeOg 8leP7PFPMTe4gkYOfmEmLMZgTrmwhyIbIc07QEABJruZn71vOjOrvX21rugr9pK6kpAP TGJyiv1Ih634qeiqL8S7KL3+qImMaMAiZiyp8LVRWWlR2AS0mppoJJqa6jTHXu4cXwOq A6DowrqsyDiRFFK3YcTYwGE0zetULlyuPBu89Ghft+iSwjb/J75COmpaxtbn8PoViCSb Y0YLvfpbAAHsBKAYCYuU1D83Rniw+KZ9PPNVR6ok2cb64QxRJWQvXP+bmSP8uGnVe9bb h3yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777477430; x=1778082230; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Vlf4PlfS5tzFdpwjI53mxhIfEkjVjBfwJFd4T/6BeLw=; b=dF74flSM7udJFhnt4iYiH3vAG9mfWtwA7dEv3b0VqT+5qmErW1Idht1WPnTY+YshN5 9d0VyN97HBGar0/o17M/xXJHWGUFx4XbeYW2yiLLQTbli00CP1fo2wscQM8kU4KnwEHh Nu0xKlU0xjzdiLOpOJ/+nreipmZZvWcaah2qF83Gq0+X6s7m/lEQRd7WAaWzpkaojzzz RxojXJEdM9s813yboome5T79cF7AEdgjZpQYv8ceOA4aRs6rtk7SHib4KOqFSZqb035Y 45IuSXCYGUJIprWHw03VFaaA3Dueqh700sUA50saH/IPLnXax1lawSoZyJpYSxiWpZBu 9YsQ== X-Gm-Message-State: AOJu0YzpNVH37Jku+O9/SyQUMkljaV8zZq/6VMA+28gAZ5UwHwBEpg3e 1cyumBlYQuE2vMsIx/ahdAfB4XW0nhhlwB9kEcMC/xb/nbAbt31psU2FCRdws1nGrl49ktcOO2W UBkqDAudj1Ksfid4ZOWnKWZ0Hj/Sze0xe40GMJscezNk4nR1ntJNMzowQwccUzgy+9kc= X-Gm-Gg: AeBDieuRq3ktl8wqcD9laRL/Sxj5GviC48NT7CAh2hwqaXASkHx5LYOpSsNEvL3a4CB BYeZc3qRSHMt7ogALTuCGhZyqIbFKGh7p8waWEyYyMeZvlUVkvQQjvlNmrtzHt8PsDSquwBq/IQ +vWqT82CCZwJl+vx1L7o+BQKQB0CyO2asyP4BEbXi5BHy5ScdQCUOTOvO3UtZqCi4oX4YGLLChA d1YZejYjVbS3vYzZ6+9yp4GXkFdkVMGpGxFusx9AZjHNh2KA7G8NbxSBO/AynMbYNjHXQTWGk9X ROFvVOcc3ubv3CdQitCz4/F79ZruRFkz/cnALbZV9VGicbZmXmGU1Y1Pbwc10pus2rAcPhGyyT7 nvPgOxJrYzyUjlfchIeeMo3m1WLA1ZyDtvcLO4zGU3uQN4DJnZFTKLqO1R5x0Aw== X-Received: by 2002:a05:6102:1609:b0:605:218d:ae0f with SMTP id ada2fe7eead31-6280a9b9ae0mr4402872137.18.1777477429934; Wed, 29 Apr 2026 08:43:49 -0700 (PDT) X-Received: by 2002:a05:6102:1609:b0:605:218d:ae0f with SMTP id ada2fe7eead31-6280a9b9ae0mr4402827137.18.1777477429518; Wed, 29 Apr 2026 08:43:49 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:e9c0:e45a:1dbc:c82a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-447b3d481b2sm6837552f8f.4.2026.04.29.08.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 08:43:48 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 29 Apr 2026 17:43:22 +0200 Subject: [PATCH v3 7/9] nvmem: simplify nvmem_sysfs_remove_compat() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260429-nvmem-unbind-v3-7-2a694f95395b@oss.qualcomm.com> References: <20260429-nvmem-unbind-v3-0-2a694f95395b@oss.qualcomm.com> In-Reply-To: <20260429-nvmem-unbind-v3-0-2a694f95395b@oss.qualcomm.com> To: Srinivas Kandagatla , Bartosz Golaszewski , Johan Hovold Cc: linux-kernel@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2068; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=KZCWEvO63oX1FsDdFQQdyHnksuMOPYlcREE3/YRGNHE=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBp8icnvL0B2hP8hr/x8g5DPP115aLzQQPnH0b1q lsgbZHtTJOJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCafInJwAKCRAFnS7L/zaE wxucEAC70VEkgOfOfzuhRG0ENw0kXdjjgBOc0CrKDC+ycbL4LYLo61blmB2NhsRJj1ppIEKSwGU 5nMGjdq3zybPnNSFqX6gOwSct5y1pe1eDZvKFcv3bdCAtIdH0GcyMDx+4/nf8EfapEE75fQA/P7 ExQjP7tI5Wvl3MSa6g2FzF5bJVsKmPnJaaS4AS26RK/pONHygTEzdU1Ox7SSSBViwtmzSah+uFT 45IDQdzGKpQGz2GDAnNctRLTBxSuehc292GTUOd7/7GP1btJU7OFDo7lt+l2s3lW7KhnfZIBacX lbsofGZPhDJ7fBISG73KmpytYa47ak7Cf7whGD9nqy6u7wlUj/qoTa48YN0UapS1Y9BBJXE0ffu Zwm/9FJo2qqKE91DyITvthoa4CwYy8STXLJW/8a1babNuuFZP7jjm1OjkLoRY2c+Sqoufw7J3bD SC2Z1Wvat1NbmM3kH1F40xxqyxkpseNSfKX1mJwNpyl0mQJWYdaD37kfoJs/GeS4YRvP4vVwfHy ny3lS7hhPjUqYpf/7YOi87OCXCApySuIm0PzB9nxthvs1UNWRHFpOaWjT7VNv+a/uk5agdoEcBj fyF5igKvGhZO55+pMrRKAXZ5JRjkU8iFV3T+2BEKo3KIBk2JVphePJlXpzMja4HRnLqFbv3bklD qOkfoVSH/cXETow== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=XtvK/1F9 c=1 sm=1 tr=0 ts=69f22736 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=vscgUUECmMDzLPOjfHYA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI5MDE1NyBTYWx0ZWRfX2sJqGARzhDH6 YimPenbBklFnxkogO9KAXlorqT5OiWsxJ8GtP/LVSOzWcnGdq4IN0lUXTKgcaLOZvuHwSbmn/Km mQG4MphUAyfgDNmYF8wd28XeEGREmkJUUxg01cZ6cKCKfoHSevlsEOy6E77fS8Y8JV23wap7DnG Lxo4DkKHzr/NrO2N8GA9UmVMgJ1bavw0dImRcFFlobGqFrCa7RRpxds0N+huWmD17QTa0ZldPGZ IBHcgKHjyJOWZ7fNBPt2Zfi4rwGGvEccUt9/ofJJFXpUHRuohqLNoQBykJ0vcvjQSObfrVbjqvw oeygCPfYbjvQsuFEzpbWqMAuQe1i5WTCToDvOc+LyACVnDkV2pC0EkL/yKLFGTi2DELFHHbNamB WfFr/uESFdKquSHN0j2i7dDQB+yXjndI3TR3npF3aRHhsr+WILZQ99BWKNPE/e1nn33oV31AMFb lc9apu82sxsGmHLkMhg== X-Proofpoint-GUID: g1iT1x1nWAjizqEP510_yUOpRuxErVAj X-Proofpoint-ORIG-GUID: g1iT1x1nWAjizqEP510_yUOpRuxErVAj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-29_01,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604290157 There's no need for the config argument in nvmem_sysfs_remove_compat(). Once the compat attribute is registered, that information is carried in nvmem_device::flags. Rework the code to always query that field and drop the second argument. Signed-off-by: Bartosz Golaszewski --- drivers/nvmem/core.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 83ef4858939c471daabd4641f9746d92b43daf5d..32fe048a4a9152b7a5ec465ae5bbf04e30319554 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -454,10 +454,9 @@ static int nvmem_sysfs_setup_compat(struct nvmem_device *nvmem, return 0; } -static void nvmem_sysfs_remove_compat(struct nvmem_device *nvmem, - const struct nvmem_config *config) +static void nvmem_sysfs_remove_compat(struct nvmem_device *nvmem) { - if (config->compat) + if (nvmem->flags & FLAG_COMPAT) device_remove_bin_file(nvmem->base_dev, &nvmem->eeprom); } @@ -524,8 +523,7 @@ static int nvmem_sysfs_setup_compat(struct nvmem_device *nvmem, { return -ENOSYS; } -static void nvmem_sysfs_remove_compat(struct nvmem_device *nvmem, - const struct nvmem_config *config) +static void nvmem_sysfs_remove_compat(struct nvmem_device *nvmem) { } @@ -1046,8 +1044,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) device_del(&nvmem->dev); err_remove_cells: nvmem_device_remove_all_cells(nvmem); - if (config->compat) - nvmem_sysfs_remove_compat(nvmem, config); + nvmem_sysfs_remove_compat(nvmem); err_put_device: put_device(&nvmem->dev); @@ -1063,8 +1060,7 @@ static void nvmem_device_release(struct kref *kref) blocking_notifier_call_chain(&nvmem_notifier, NVMEM_REMOVE, nvmem); - if (nvmem->flags & FLAG_COMPAT) - device_remove_bin_file(nvmem->base_dev, &nvmem->eeprom); + nvmem_sysfs_remove_compat(nvmem); nvmem_device_remove_all_cells(nvmem); nvmem_destroy_layout(nvmem); -- 2.47.3