From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18B9B349B0D for ; Wed, 29 Apr 2026 05:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777441585; cv=none; b=QonE3BznbGP1IiW3LULyLX3eQQwJBgKi01f6C9A5sQHg9Ss6mHoP6YJTo57znowu/0NrESSWTW/UEL2GC3CydHxNbLrUMHQojqrOEuTuYBkA6Lu3DrANwIGMIpjIfRmVvGej4vGYent59onzj7KkELeaZBD9+yMUQWVVQVPPnac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777441585; c=relaxed/simple; bh=xXaxi51qGj7aWurvmfktAlX9UTUq1LtX72gN1BATBxY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n981kIDWFveTKeg/hwUBxLRLk1itJ9r3W1kzPAOcA9Hj3LkqL5wrMXC418NgzDbxjavB2ebNJGPYsZ4bFgqUNl8EWudL5kTAeIvusX4tPjV3ObLcyOn4t9qhDeem5AgrHfnFxcVwYHprLODLWZxCxd3TTlQCqAnPTy1jIVYrGXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OirhAIjf; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OirhAIjf" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2b24fede2acso80311265ad.3 for ; Tue, 28 Apr 2026 22:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777441583; x=1778046383; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pxEW3u9KIKQo+IcX8Gj4fVHnzWaGq05CdwSfKooXYVY=; b=OirhAIjfm7Rhik0AuLp0Nslvu++fvKXzdfigB4laAFx3VXS+PZLc0FJX8GgKZu8j6h Z+2FIGj6HW248w5gHn3fsVwjD2MCV6HkQ489hlWKWmhXD1szT3FRVt4GBguAwaovfUIq QEw5SjQ08yj3cgCwz2hu2Ujj7RrJ4Fy6oMggwsJnWteR+joHPQBpoLA3urq1j4BojVgE ND56zx9ewilRLsIKugQfWaxOSKexMFSerIpoVe/GkIDh+stobQokFqoebUJ6LYJij2Q2 64m5n98dpwg/5weJ6V/z6s3U9dFe6ZP5pS92cCHhLliinjNVbufJxthOxeHYnXzFhwhw dxyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777441583; x=1778046383; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pxEW3u9KIKQo+IcX8Gj4fVHnzWaGq05CdwSfKooXYVY=; b=DVdvUur+nuwoM+HK6e8K65Wdrbc7MiAynXl8jbXzSNguRsF+lZnTU7t+9n3JD/pCP7 mJ9RwtwuiD8P8MmDhWM4kLRwkV26s0F4RgR8+FdsdbX5jYrkmsUwmlsxyVKm8G9bjY6g bng5BaPKMICqeMy3QvQ16lqg9Hj0+lEb+j7o+LBmLNqfGqJxTUXf5cSYsUjBcqzGT5OC 29gr6HHViGSxJzuW0SNILotrO4Sb3FgjyrYDxDP3qBVNmAsUVnlf+WAZ9XS9dpzN4jgT kHcjfJYUfrP2aVlZSYGLegwvjou2+o25BzuviePPUfAVzbwEnkImOpbXnMoDNDJDcnKj P2WQ== X-Forwarded-Encrypted: i=1; AFNElJ8qgvSuWHlnbjzhC3wZaDqs2dwDcRLU5wAqC04vSYWqcFTQo1jKrXqP6xjSI7ZcqqUwqA0/Afpts6NJOwg=@vger.kernel.org X-Gm-Message-State: AOJu0YzP/QjDardLzkmJWIbeaInCEaSFxgR3r2qyEPwtV+X+0oT9tNQQ GE8Gd0s0+ANS3Sma4yPFYEWWjUj/jdAaFyhbDFH6Gqj6Q/dgZac9exVw X-Gm-Gg: AeBDievUyAVkUPMytAbR+CWLkbGLA9gDe347/2fF+5i3wUmNU4XW4iiRaC1o9Ca1Sv7 e1dxJuxLas98q2jr/6sgYZomJS1nTWP7wxIw4tGqR+lak/PdHLalKab5Ne8ElpLcmYgkZizlx7y cC09wt8r26SMoCa9pshUawK4MCN0z6cp63iHQi/ZQUybpBqkRCILuW/9APuMY7tQbW6tHIQxeJV DQkMhB31ZYaxTjFIijeguMUztkhRtXrNf2Bbv95f/37uwKHORBSwf5Cem7a7d1REKKkW6rD3cV+ Af+lIzqGGvdcVI1JDVV4twA1cR0oPD3JvUA+2ES6gbwZmPZIWazGtFdgoJjC0iql+iLFwR8cHdG r62MZOZHkIiCP8StujlN8ESM2q1fzFMJVxl3mX9KnEUqT3SgT/zJn3HTIw+G9Xn73LT3npe/cYI kGlZMZSWb4ZjEyD9NxjKptkSA5yjOfLw/ZURuzak67egbVnvehO4De0uTRJGBYK4WbWMXHcnzPO tl4RuGlw07yu2VKGXhuWIw78s7XHameAokuWsXJr8Uxpdi5kA== X-Received: by 2002:a17:903:380b:b0:2b0:663f:6b53 with SMTP id d9443c01a7336-2b98733776dmr22390335ad.13.1777441583465; Tue, 28 Apr 2026 22:46:23 -0700 (PDT) Received: from lord-daniel-VivoBook-ASUSLaptop-K3502ZA-S3502ZA.. ([2405:201:31:d01f:5fb:20b2:c2f6:85bd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b98879656dsm9346365ad.25.2026.04.28.22.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 22:46:22 -0700 (PDT) From: Piyush Patle To: ak@it-klinger.de, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 07/11] iio: adc: hx711: pass trailing pulse count into hx711_read Date: Wed, 29 Apr 2026 11:15:40 +0530 Message-ID: <20260429054544.123862-8-piyushpatle228@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260429054544.123862-1-piyushpatle228@gmail.com> References: <20260429054544.123862-1-piyushpatle228@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move the trailing-pulse selection out of hx711_read() and into its callers. This is a preparatory change so later variant-specific code can pass the per-channel pulse count without adding a separate read path. No functional change. Signed-off-by: Piyush Patle --- Changes in v5: - Split the trailing-pulse refactor from the loop-iterator cleanup. - Keep the loop variables unchanged in this patch. Changes in v4: - New patch split out from the earlier refactor during review. --- drivers/iio/adc/hx711.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c index 666f64284a0d..d85ff2f4a3dd 100644 --- a/drivers/iio/adc/hx711.c +++ b/drivers/iio/adc/hx711.c @@ -155,7 +155,7 @@ static int hx711_cycle(struct hx711_data *hx711_data) return gpiod_get_value(hx711_data->gpiod_dout); } -static int hx711_read(struct hx711_data *hx711_data) +static int hx711_read(struct hx711_data *hx711_data, int trailing_pulses) { int i, ret; int value = 0; @@ -174,7 +174,7 @@ static int hx711_read(struct hx711_data *hx711_data) value ^= 0x800000; - for (i = 0; i < hx711_get_gain_to_pulse(hx711_data->gain_set); i++) + for (i = 0; i < trailing_pulses; i++) hx711_cycle(hx711_data); return value; @@ -237,7 +237,8 @@ static int hx711_set_gain_for_channel(struct hx711_data *hx711_data, int chan) if (hx711_data->gain_set == 32) { hx711_data->gain_set = hx711_data->gain_chan_a; - ret = hx711_read(hx711_data); + ret = hx711_read(hx711_data, + hx711_get_gain_to_pulse(hx711_data->gain_set)); if (ret < 0) return ret; @@ -249,7 +250,8 @@ static int hx711_set_gain_for_channel(struct hx711_data *hx711_data, int chan) if (hx711_data->gain_set != 32) { hx711_data->gain_set = 32; - ret = hx711_read(hx711_data); + ret = hx711_read(hx711_data, + hx711_get_gain_to_pulse(hx711_data->gain_set)); if (ret < 0) return ret; @@ -264,8 +266,8 @@ static int hx711_set_gain_for_channel(struct hx711_data *hx711_data, int chan) static int hx711_reset_read(struct hx711_data *hx711_data, int chan) { + int trailing_pulses; int ret; - int val; /* * hx711_reset() must be called from here @@ -280,9 +282,8 @@ static int hx711_reset_read(struct hx711_data *hx711_data, int chan) if (ret < 0) return ret; - val = hx711_read(hx711_data); - - return val; + trailing_pulses = hx711_get_gain_to_pulse(hx711_data->gain_set); + return hx711_read(hx711_data, trailing_pulses); } static int hx711_read_raw(struct iio_dev *indio_dev, @@ -349,7 +350,8 @@ static int hx711_write_raw(struct iio_dev *indio_dev, if (gain != 32) hx711_data->gain_chan_a = gain; - ret = hx711_read(hx711_data); + ret = hx711_read(hx711_data, + hx711_get_gain_to_pulse(hx711_data->gain_set)); if (ret < 0) { mutex_unlock(&hx711_data->lock); return ret; -- 2.43.0