From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A51DC31F989; Thu, 30 Apr 2026 15:11:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561877; cv=none; b=EEMKXjhnUzCizmzcZ5pt1pH5pEP2on6S1L9AF3mP9R+Ml7gwUmZbpm/J1LPgDQXZLxWjyy2lIcM86aCVkb8TNqOkNLMirVOR5kMY1gQUt659hIV4gyrUGlbR/uWXBmWriStMIeVJjCHkks7gn62JtYXQOTajBfVkHKE8KjKhRhQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561877; c=relaxed/simple; bh=+nd8s7gfQp/En4pd5u3HKu50CUSpxEmkHUSDYTDjb90=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SjVry6/q3wVTlfhdodNrCMMteNghxvb9wwBZhNbIcn92YUisqcGVq4BAaWfs/36DA2nl0hIe/Xn9SEX9Uxya/8pOREOLkx6LaorIDIw7rIWALNiqW8DwtY8kdHCvf+4FOTw+vfKwrZlk/1PsPKYPsFAsVzyZZIqQlfSVIZAjSu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HC45SvdN; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HC45SvdN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777561875; x=1809097875; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+nd8s7gfQp/En4pd5u3HKu50CUSpxEmkHUSDYTDjb90=; b=HC45SvdN3ur0HO7Kj4yl68CvMyX0CCScpMt5oj9d59QitCCLM+KUPEXo Qd0pa0df5Z/KXwfJXfLLZfcl+qOBp+95Fi2MYDzoxkDcwQF9gGum86Z78 Z2e8tyZMSE1s0HJt/czoGG7PDiu6abvTHrGoG6TIaaI8DA0I9wCDdVqek lT7ahaRFFphgURobygINk2AWrPBhD0GuCvuAp5H05O3YLe5fp+sxE1FE2 4oDp8OI6Md173bzYy8CZu4/8u1gGMQQwUwrMRisAMOkWgEMEzDrJZWyeE UPxbO8mAMGlQxy2M+xlDMWrCs2UkW6sRCI7JF07qva/rjlSFI0lBsPLCt A==; X-CSE-ConnectionGUID: kG0tY0xLSkmAc+yrVw7Gfg== X-CSE-MsgGUID: WoRnRFbVTsqZUtdgqB8LIg== X-IronPort-AV: E=McAfee;i="6800,10657,11772"; a="88828154" X-IronPort-AV: E=Sophos;i="6.23,208,1770624000"; d="scan'208";a="88828154" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2026 08:11:12 -0700 X-CSE-ConnectionGUID: tABge+VjRT+Eoa4UVinWHw== X-CSE-MsgGUID: 80Db9/bNT3GDQOdFX4FS+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,208,1770624000"; d="scan'208";a="258194278" Received: from spandruv-desk.jf.intel.com ([10.54.55.20]) by fmviesa001.fm.intel.com with ESMTP; 30 Apr 2026 08:11:12 -0700 From: Srinivas Pandruvada To: hansg@kernel.org, ilpo.jarvinen@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Pandruvada , Stable@vger.kernel.org Subject: [PATCH v2 1/3] platform/x86: intel: Move debugfs register before creating devices Date: Thu, 30 Apr 2026 08:11:01 -0700 Message-ID: <20260430151103.1549733-2-srinivas.pandruvada@linux.intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260430151103.1549733-1-srinivas.pandruvada@linux.intel.com> References: <20260430151103.1549733-1-srinivas.pandruvada@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit It is possible that the driver handling device is enumerated before registering debugfs. If the driver wants to access debugfs by calling tpmi_get_debugfs_dir(), this will return error in this case. Hence register debugfs before creating devices. Fixes: 811f67c51636 ("platform/x86/intel/tpmi: Add new auxiliary driver for performance limits") Signed-off-by: Srinivas Pandruvada Cc: --- v2: No change drivers/platform/x86/intel/vsec_tpmi.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/intel/vsec_tpmi.c b/drivers/platform/x86/intel/vsec_tpmi.c index 7fc6ff8d1040..a38014e81e85 100644 --- a/drivers/platform/x86/intel/vsec_tpmi.c +++ b/drivers/platform/x86/intel/vsec_tpmi.c @@ -817,10 +817,6 @@ static int intel_vsec_tpmi_init(struct auxiliary_device *auxdev) auxiliary_set_drvdata(auxdev, tpmi_info); - ret = tpmi_create_devices(tpmi_info); - if (ret) - return ret; - /* * Allow debugfs when security policy allows. Everything this debugfs * interface provides, can also be done via /dev/mem access. If @@ -830,6 +826,12 @@ static int intel_vsec_tpmi_init(struct auxiliary_device *auxdev) if (!security_locked_down(LOCKDOWN_DEV_MEM) && capable(CAP_SYS_RAWIO)) tpmi_dbgfs_register(tpmi_info); + ret = tpmi_create_devices(tpmi_info); + if (ret) { + debugfs_remove_recursive(tpmi_info->dbgfs_dir); + return ret; + } + return 0; } -- 2.52.0