From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C758381AE9 for ; Thu, 30 Apr 2026 19:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777579035; cv=none; b=Q9XdkipDrN9TyrSHzxWs4VuwNObrebHhBwqIco7ZNc+fFnqw5cKWTTDVL7LMGQhP6OpHuTutvQAki3AWvrFRY9Je84KWtNqWgw+Q+ffICppb0WSLNP1CeQDGPjlSdqqjO7IVX9Be7630vSq4H40OEZhEyLDrAcF4wWoP8dBMWfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777579035; c=relaxed/simple; bh=IamWvDL/vfzrLrP055VymOxe9MPDgKdr9LOvSE+KKa4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YTbYbwGJg9Lrc7keYJosvFtgEQboamPs8IWpFd6TS9rW/0HQt2TfqYQV6Vv8L5xjHszknAguvAQo99D2ml2pOJsPT7DoLSEuWDwwq4CgEEYQls7k/T4kDoWVeFxvlL68H+ZYeflquJyQUL4u1XPOXq/rs8JJVuFXVZ5hC3k4uF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GRfraDgE; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GRfraDgE" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43cfd832155so863909f8f.1 for ; Thu, 30 Apr 2026 12:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777579033; x=1778183833; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xXo4GTKuApdH2855i6VQmTYDmGzNNitfMak3tWGUlss=; b=GRfraDgE5l3pb5/OT5SeaM05MWot4xQ1AMGjibQIHaIwl+Z3vQD84sQmM2ulCOaP+r Jt4gSF6CDqZXnVJZN4Q+P4/GF9ZznMA6VmQyaaHr1Vjb7RxQIibAurQABFFSzc/3uVbX zcAgBtkwe/i2L9GS4sVJyP81iO1ARbYM73ed6NbeYFJjmLNpBZuvsp0OC4+OIlJyTtOw 1TqIbKb4kPugBrOJLgoWjh+yG94hSGE8zCWkWiH6OSkP6k8rNehfiq8JEuOsoPmkMn5L VSWv5ADuIvHUl4SlZB+QPjziEyR8fdG7VSHlUjsejZ0hoCRk49B5X7bqrWNd8YgcSE0F tLyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777579033; x=1778183833; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xXo4GTKuApdH2855i6VQmTYDmGzNNitfMak3tWGUlss=; b=gy1hx4Y12gTwVDfWzt3LyhheHlzTJ3JHA4b+v1MRiK3g3U4sJ7qp5zzJN43p1JIRKJ MYX5C/xZnGcgjoaCy7akzpd5nZmTGRGA2D1g6Oe4zjWV+W3XHQ1fRow7gyuJY4SWgKH9 1fJVqsyXoooYe/jbm23LX+lh56I462dJlLsK4xqqZI17CIGyYgTnf0RWUEZ4quU7UUPH LtlNyWMxm+2qe7XtbqERCT8GUmIKburU6Z+lnYTMpGzdgHHJIxxEq7FidiFc1YW/AOoS NzhkRXpX4YwaNIBQTVXG+TEa9yo7UiZXCFHqS1PdxV+c2KZ2RreiW3KOi/wSCz93bWEl mSzA== X-Forwarded-Encrypted: i=1; AFNElJ/0nDCuzWfV2NNKCZyXji/jxVnR5UQxJ1bxheEhHFSaBFxoUNlRloibjpm2o5NuS1SNOUJyGMq4odSkvA0=@vger.kernel.org X-Gm-Message-State: AOJu0YxBcdWKnBOJsHFp+bhhvmGYFza3qy01U1yeUg2CHWBBPMOOP2pp Rb7dc8Zt0f6XqIlUi2DqFX+VtJqDqsvnuXUpLLjBJmUwQbP7IxSE65rC X-Gm-Gg: AeBDietM7BhQjMaQMC/iiV1XT05wXtGcN7HXlC2NG5jXgf6iXQ4o9mFlyhqeKYRe4N9 3A8a+njp6vQHuKgnNbXKJIVQypPf8+IqoQexye8c3xpS3qnS/6nH3l2gZVl8hzBUCfVRVnk1DWV 6ozDtt6aiB0De9YRK89E4ZAK9PcTOQc/+OaaiGdpcOiKciaBVWdLqFhmAkj+sJSH4X6Uoqum5xe u28ckWGWULZ5MJnSA2XaIJOwgw85ImlfGhNwSSlKc7aSC9RNjzhxrt+r2SaKHu+sV4nWZBGVZy0 R/CsRjvbhpMZEjg45S7s4QM8ro5AnXdgUtjCtGes2bMeRVBiu4WJ78AwQdzjajFnVyCYd8zSgz8 8TPoyg3QuI4Z+HhLlSBfKgDncUa1yeeP9xgXZp1YwtTtvmwy7u11IzDLvPs/hsABwUg3Bc1gnB4 LEdQOSMlh6nJ0R5gPQIZ05yikcvrZ0JpRzPeUCPRSMxHeu/986TO3ftLy+GfiKhZ7KiO6GCAA= X-Received: by 2002:a05:6000:2c11:b0:43d:775b:c9bd with SMTP id ffacd0b85a97d-4493cc3f4e1mr7237459f8f.10.1777579032765; Thu, 30 Apr 2026 12:57:12 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:55a4:d495:8d6f:1416]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-447b76e5afesm13003924f8f.30.2026.04.30.12.57.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 12:57:12 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Peter Senna Tschudin , Ian Ray , Martyn Welch , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Archit Taneja , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader , stable@vger.kernel.org Subject: [PATCH v4 3/3] drm/bridge: megachips: remove bridge when irq request fails Date: Thu, 30 Apr 2026 21:56:59 +0200 Message-ID: <20260430195700.80317-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If devm_request_threaded_irq() fails after drm_bridge_add(), remove the bridge before returning. Keep drm_bridge_add() rather than devm_drm_bridge_add(): registration is tied to the STDP4028 device while ge_b850v3_register() may complete from either I2C probe; devm would not unwind the bridge if the other client's probe fails. Signed-off-by: Osama Abdelkader Fixes: fcfa0ddc18ed ("drm/bridge: Drivers for megachips-stdpxxxx-ge-b850v3-fw (LVDS-DP++)") Cc: stable@vger.kernel.org --- v4: update Fixes tag v3: add Fixes and Cc tags v2: IRQ failure path only (explicit drm_bridge_remove) --- .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c index c9e6505cbd88..2d02cc69f237 100644 --- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c +++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c @@ -251,7 +251,6 @@ static void ge_b850v3_lvds_remove(void) goto out; drm_bridge_remove(&ge_b850v3_lvds_ptr->bridge); - ge_b850v3_lvds_ptr = NULL; out: mutex_unlock(&ge_b850v3_lvds_dev_mutex); @@ -261,6 +260,7 @@ static int ge_b850v3_register(void) { struct i2c_client *stdp4028_i2c = ge_b850v3_lvds_ptr->stdp4028_i2c; struct device *dev = &stdp4028_i2c->dev; + int ret; /* drm bridge initialization */ ge_b850v3_lvds_ptr->bridge.ops = DRM_BRIDGE_OP_DETECT | @@ -277,11 +277,15 @@ static int ge_b850v3_register(void) if (!stdp4028_i2c->irq) return 0; - return devm_request_threaded_irq(&stdp4028_i2c->dev, - stdp4028_i2c->irq, NULL, - ge_b850v3_lvds_irq_handler, - IRQF_TRIGGER_HIGH | IRQF_ONESHOT, - "ge-b850v3-lvds-dp", ge_b850v3_lvds_ptr); + ret = devm_request_threaded_irq(&stdp4028_i2c->dev, + stdp4028_i2c->irq, NULL, + ge_b850v3_lvds_irq_handler, + IRQF_TRIGGER_HIGH | IRQF_ONESHOT, + "ge-b850v3-lvds-dp", ge_b850v3_lvds_ptr); + if (ret) + drm_bridge_remove(&ge_b850v3_lvds_ptr->bridge); + + return ret; } static int stdp4028_ge_b850v3_fw_probe(struct i2c_client *stdp4028_i2c) -- 2.43.0