From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 847C4376490 for ; Fri, 1 May 2026 11:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777635184; cv=none; b=mhBxtUDNiEiJ6dG7PyJQzGp2PU3xy9z2TYnQKecxyx+4rp/o5z0I4XH9IMc7wYLHsQzoamGjzUEbg1u97+vCEJN5zT16cA5o//uBNWUEDu8NXRF22sHEUnnBuKeWKMfuT2Yf2cDpp7xVfsKsn9RvbeVx97SYU98+AAIDNX4O3HQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777635184; c=relaxed/simple; bh=uyYaC1lTz0w/nk+wumPROnOpURb8EgSxj6J839JiKk4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hg4xPfI3ql5yG1X5eugK3O2YthiEUmP6nTgua9NsuN1JRlgsMnuXc7ngbsOYgjgjBydtJkv8j1iIWDh4QLFfQTI36L+fnQ8EJfsyykdXHZY6dhiMdyxtpQElrOHhKrci3IhOUDsJFoAWPxh4zKH4h6LxJ9dldKBErSxFks4qmSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=PCDmSwbC; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PCDmSwbC" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-38dd9f0fdc6so33224481fa.0 for ; Fri, 01 May 2026 04:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1777635178; x=1778239978; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=t8cx0IS1VAS+UenVXpVCneZJCK5BcfnnFJsArKfUIY4=; b=PCDmSwbCWhAGyVSPuTpr2Ub9I5xgn6RbyRfO02vW3yTYQ7/7J6lzF/6AkOl0lreXu2 C7YJXoveVTKGvmd/gxTlLvoZRCsv4E/ERrLZ7CAqkUXuL68XDURvZQ9HvuzZgTYocGJB dNl1TZ5C/+gxGEroATa7aNoUkddfblq5ooMYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777635178; x=1778239978; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=t8cx0IS1VAS+UenVXpVCneZJCK5BcfnnFJsArKfUIY4=; b=NlFFgDpuJN906p+G5Vi31BYEDbimeNEacdJ0Bvgi2zVm+xSziL/OzHrv7zXeegWkFF 2CDdOpis3f3CTWc73o2+mVXOGnza+6lqZP1dOVt4lelhTsoIqxCPeq1IixwmRTvqmEES 3JmNrhfeiQc1BhkoHVTk8cgV9OY8pLmf51GLH/JQeT2gjvTXeX2cexenivkv15ZZTOzQ b6nMPnslqMpj/2mZMAdSIud3MUyEKBhrAxMRqeUrfmjMeoSG18/oY56EF+EG6Zxb2YR+ FsAILsWwUTvkVSPUogpCo2YVjGM2ZQVTCmCHnAO5Ul1bkrgTy/Yh2ZQJ0O1cr4dkFb8Y yQSw== X-Forwarded-Encrypted: i=1; AFNElJ9DrMwVTgmgnqZD157LBZYZv6hPMcjGp14p53IlRKYeeDSxWvL6PW776zjwuPg3lI5KVN5HrRS8OTbHwlE=@vger.kernel.org X-Gm-Message-State: AOJu0YwvxPpP6bztwMsDvTNRhizdUJHI60K9ZwAWX0FwaOv4RoTqBH6y n93hNPhe3eUKGhF6Wtv2cL7QIBrRO1pXPvLITZy95OGfGVZ5pXON8521/+yporuRyw== X-Gm-Gg: AeBDiesu0BA0dGvOyFz/NkM42Hp0nawrDBEMbyPqB4Fr96ikwGLKwKWtjf6wSxGgO/W sZM0wbDY0rXxjazVWPOvFpoRwEJ4v2hEqi4cQxBDGq4RgcZ/7vKEWI6JPiTEY3ef+mBMFQCIs4u vKgZxpZOx13i3/xae30N9ZQrSHecU+PQ8R3N9NwIG9i0Qw2d07vOCtWq3StY4jBcp58ahclM3x4 WjcWI3XfQB9Yg7450x+GjMk+nwRt1BuNrPOi+q6AGBHwonEU0fRjxEre02d3RmVd0DU4hZYCtHJ 5yM8tyDI8YGWtN36QkcMGuhecA2vThHHRNvzVAIaHnGhOScZ5zfxDJ1lQwYNYTCJzRNkiGBm1lI IzmDxjy/7kdoR3EYvT9OgZKKosHDNQEn/MaLvKaRiauAfyPAnTfwdRiqcphiYaUCoOrXYBibdGZ mLagvzQX5sbmvpf6OjEkKg0IYnMruIWLS6ZjZNaxywaPvhO9/FR+r9JRyieyTMSb1lPVLBBy/+D mcGWN08RJJbQqP1RQ== X-Received: by 2002:a05:6512:3b0e:b0:5a2:c0b8:270 with SMTP id 2adb3069b0e04-5a85274573fmr2057007e87.22.1777635177764; Fri, 01 May 2026 04:32:57 -0700 (PDT) Received: from ribalda.c.googlers.com (52.163.228.35.bc.googleusercontent.com. [35.228.163.52]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c346c02sm429166e87.74.2026.05.01.04.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 04:32:55 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 01 May 2026 11:32:47 +0000 Subject: [PATCH v2 2/6] media: i2c: mt9p031: Rewrite a bitwise mask Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260501-smatch-7-1-v2-2-a2fcfb2531ac@chromium.org> References: <20260501-smatch-7-1-v2-0-a2fcfb2531ac@chromium.org> In-Reply-To: <20260501-smatch-7-1-v2-0-a2fcfb2531ac@chromium.org> To: Mauro Carvalho Chehab , Laurent Pinchart , Sakari Ailus , Hans Verkuil , Nas Chung , Jackson Lee , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Keke Li , Yong Zhi , Jacopo Mondi Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mauro Carvalho Chehab , Ricardo Ribalda X-Mailer: b4 0.14.3 The current code makes smatch a bit uncomfortable: drivers/media/i2c/mt9p031.c:799 mt9p031_s_ctrl() warn: assigning (-1952) to unsigned variable 'data' Probably because smatch is not clever enough (yet). Do a simple rewrite to make sure that smatch understands what we are doing here. Signed-off-by: Ricardo Ribalda --- drivers/media/i2c/mt9p031.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index ea5d43d925ff..5c9dff030b4d 100644 --- a/drivers/media/i2c/mt9p031.c +++ b/drivers/media/i2c/mt9p031.c @@ -795,7 +795,7 @@ static int mt9p031_s_ctrl(struct v4l2_ctrl *ctrl) ctrl->val &= ~1; data = (1 << 6) | (ctrl->val >> 1); } else { - ctrl->val &= ~7; + ctrl->val -= ctrl->val % 8; data = ((ctrl->val - 64) << 5) | (1 << 6) | 32; } -- 2.54.0.545.g6539524ca2-goog