From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAC84421EF3 for ; Fri, 1 May 2026 17:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777655206; cv=none; b=h4EDPifpNBbYQJIT2oQOUQDdBuCdNzKeu5Q05Js0T7OQK+gUIlZQh5NMNwNYRZFN7QXngurv/nFKQG9HOWt/ZuuWl1Fu9nm/7ezmiJbEwoPMEemmbytnSkij4+6vFTpEXMf8egWmkgY8Jveb0BGkQldsLDftwk4tcaTD0mQfi9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777655206; c=relaxed/simple; bh=doFJzNLDHQmlXc2pfwFDlVaTkV7lTXB8yqsy53flfY4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Q168UkjvmRaT167xE/nlsktcL1PLnxatijurRE+uW2Q+YfPNUqkx30dAQNa3b3ekBTsC17vO2nVX0xjWrAta2PxwoEWS0YriY3G/PXSXnzAGgbQLrTx04XsZN3upNbXxDmvqo8pbTG12vkGuFQL1+sNeuJBX33q0Gq6C0GSk9zM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bHWvmU+j; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WBJIreje; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bHWvmU+j"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WBJIreje" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 641GLk6D987850 for ; Fri, 1 May 2026 17:06:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=j0RJQKr0tEf FrH8IEW2efNQFcXBtQIOQlSiYqCKVrXw=; b=bHWvmU+jo6wB4u2LZnytLFvHm85 6RSn3bSkaFiQZrJL8EUpQKSOYW0nP/+za3Xyh1OjrX0GZ2+/3NWT1CBcgRiyaW3H IgksOJ9c7TU1Ej4fbxdlxHUbjPLA0jCi2eXX68DHOfsGpZ+WXwp9nGQK6DOZFlkB UxQEByIq+MiUl6H7Hc/4Kdia9rFzRleTXlAoz5OcUIVFo+MIHC0E5dUKjdkhBvdw hgRqCoG0GccDnab17rlWuf8ckfyY/93iDN/CWDdyzoPe0YcvodSkVrwzWZqJNPvk 4F0Vvj1j+m6WgoeLIl1pufG7drOnxQpNbb5+vlTeorOiKCKEl2H05LPRhRw== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dvjhst3mb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 01 May 2026 17:06:43 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2c0f6593ef5so3236667eec.1 for ; Fri, 01 May 2026 10:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777655202; x=1778260002; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j0RJQKr0tEfFrH8IEW2efNQFcXBtQIOQlSiYqCKVrXw=; b=WBJIrejealST25MRBMzniO6s7UXF5KfDfAEHF64EmXijJV37WawNlm6ac5xGIwegVH gYRRS1xk5hJV/TazjCT8T+wndvpn+byE27QSUMN/CzFL9zOS0W0awEndUkfoxPCrlrUn FwDVNCWU8Juyd7Sn/HNBT+MMFZcQfZ6wXbXBmFGC9nC05LlAEG0/5w9RE+ZDiYYXm4Rg YnGJgzFCl/i75v4HF7E2AIYHa8zzbEiqRb10yWbDyfPQK4N3fmkxjzF5vYBUrotkW4vL 0ndZxGci6UU/yjJne8+MzM4iBopcWq2sum4yk7IqhXV820MbviIXWXA8YAM4bVZkIaBt qT5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777655202; x=1778260002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=j0RJQKr0tEfFrH8IEW2efNQFcXBtQIOQlSiYqCKVrXw=; b=amQTtn6e6EL8sDUxI7lhtUQW6UpQqRgswb5MIm21MqB+POxYAij6ym3u9sXVDz6/F1 IeXxDRCM+lLZrsaL6h6zEWsJzhmrHXZzCwD9Sh91LJskQfznHfjwMxnPR7inS3h2wuIi dyHhNzso/tPCqY9KR0gHYValAzX+OGFRgx12RnaMwWxtZB6UHe4DYJfEmveMEmx+VI+z 1iS288HcU8H67W0k1gdtZ7qjEn5hAM//9W2homEO+3Hnz6SgHFhxuUt3uZjKI+ZEZf9a cGiUBDc+UtH/I4Vw9UCjEd2W/q39mRoCWVEa/qtaieetPP5M6AFDoZQCXfirPN+ptCVi 9Zpw== X-Forwarded-Encrypted: i=1; AFNElJ97YYgquUPvtWz6yMlHlONg+lamtEOAtcR5NPusy2ZZ/8DmEjcgU5vrUJQng2t5A8IKc2a9TY1G6wbXMvY=@vger.kernel.org X-Gm-Message-State: AOJu0YwLMtDdUonJ2OBE4XPTz9dYcbM+SdBd4INPbFASkZD/Gbomtb/k a3kwYcdpxmFou8rL43SBaZ/hVl8EecrcQZpkbN0YGmb8C+Noy4/xP1V0K8MHt5fTBbe+4WQLL83 mj1BKy3VPh7schYyn/BdfSVF2MoNxUMNot211SunJfG4tqZ7kHW1b7Ti6QYTAHoBELBZXF9ki9C s= X-Gm-Gg: AeBDies7hhiNd/hCn0fGKCdpskBDo2U1eonnnAT3e7XQXvhxvApIgXGqm9SWqhRLcAx Yi1NwTM3+Qrs8C+2vODFVhCK21wUJojTPek6M6AhL0IBQA3kekMmJQcJf7s38m+ZoMcUtMKLbUV u7SMh19bisEH6lp4E5NvkyUu1AxvzsB0FpN2o15Fn8q6udpfk0kU1iOQ1ZhUwnSMRjMjLDNmwjT +tw/swZKOiAthqeWzU37OJBpu68VQ5vevEfOdVbV/SM0MQgb72+Do0Ow1JMluXWatgbFbOgn/UE eABlJMJp6lGeE7ASLoLlJk3kxU//IQdXOk63YYaUdRWGtQkmw9PMlNMaTx/hjFrhN5siag6THVE Y3Gf8yMxAOH1HoTuF8qfEtGxP/LfSeyDKt56PxUvKv7v6WRTCTZWePqOvOd5a8DUPI/Qqbfce2x MGSeRDfdCJDA== X-Received: by 2002:a05:7300:a14b:b0:2dd:c066:c02 with SMTP id 5a478bee46e88-2efbaca2796mr85842eec.22.1777655202304; Fri, 01 May 2026 10:06:42 -0700 (PDT) X-Received: by 2002:a05:7300:a14b:b0:2dd:c066:c02 with SMTP id 5a478bee46e88-2efbaca2796mr85821eec.22.1777655201800; Fri, 01 May 2026 10:06:41 -0700 (PDT) Received: from hu-eserrao-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee3537d300sm6655978eec.0.2026.05.01.10.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 10:06:41 -0700 (PDT) From: Elson Serrao To: Bjorn Andersson , Dmitry Baryshkov , Greg Kroah-Hartman , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Souradeep Chowdhury Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio Subject: [PATCH v4 5/9] usb: misc: qcom_eud: improve enable_store API Date: Fri, 1 May 2026 10:06:31 -0700 Message-Id: <20260501170635.2641748-6-elson.serrao@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260501170635.2641748-1-elson.serrao@oss.qualcomm.com> References: <20260501170635.2641748-1-elson.serrao@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Br6tB4X5 c=1 sm=1 tr=0 ts=69f4dda3 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=iEam2xx7WbKG8qDqzoQA:9 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-ORIG-GUID: Z5b-X8angncAZrW7IZL6JfZ4yAor8jsO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTAxMDE2OCBTYWx0ZWRfXxLDJB3hqtxQG pSUwNoEW1D00DeNu0fFQQxzdSYJvLqrb2fCitud+Psbhj2kIyC7Ht6/M+hbhlKEgNDwkVf3Z9bt CGKBZ9yOip4gAM+j+VaS+1gEH3d7CmF/dYelX/q+c02wLFBazoeDu3bGqOxBZvr0xuUHkauvyMo bRql442tG94mxZzkU852EuWIRfUj/whPqOB7Wke7x3bukW37ZWodtoHGW3me96ERO0686iSyu5+ YGoubWjOfgRfoh7s/jC8j1/vws4eWAhhzfmQWzW7/imfXQMbL2mZPBN3iRDwbfDs9Z/DA6JW24e CgO8DtV3RPjQwIJcIkXpCGQz59BT40VP1Ectpnbrn0MOPIIDuspQ6DZHCenmOixz1f9KSlyxKP6 xy+B3+X37Ld7CNeb04ZLOAx64bQNA6qEx1e3oznM2yk3j7pN6jkOG+QMztoyzg3WVoe5F9vA2g2 wpUWmfjomUd9dPQk7mA== X-Proofpoint-GUID: Z5b-X8angncAZrW7IZL6JfZ4yAor8jsO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-01_04,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 bulkscore=0 phishscore=0 clxscore=1015 adultscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605010168 Currently enable_store() allows operations irrespective of the EUD state, which can result in redundant operations. Avoid this by adding duplicate state checks to skip requests when EUD is already in the desired state. Additionally, improve error handling with explicit logging to provide better feedback. Signed-off-by: Elson Serrao Reviewed-by: Konrad Dybcio --- drivers/usb/misc/qcom_eud.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c index 7fbb74bf1599..f656ffc8818a 100644 --- a/drivers/usb/misc/qcom_eud.c +++ b/drivers/usb/misc/qcom_eud.c @@ -162,18 +162,27 @@ static ssize_t enable_store(struct device *dev, if (kstrtobool(buf, &enable)) return -EINVAL; + /* Skip operation if already in desired state */ + if (chip->enabled == enable) + return count; + if (enable) { ret = enable_eud(chip); - if (!ret) - chip->enabled = enable; - else - disable_eud(chip); - + if (ret) { + dev_err(chip->dev, "failed to enable eud\n"); + return ret; + } } else { ret = disable_eud(chip); + if (ret) { + dev_err(chip->dev, "failed to disable eud\n"); + return ret; + } } - return ret < 0 ? ret : count; + chip->enabled = enable; + + return count; } static DEVICE_ATTR_RW(enable); -- 2.34.1