From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B1F5313543 for ; Mon, 4 May 2026 07:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777881351; cv=none; b=WfBzSaQVQehVbYDxnQ2i6e7QPvOHeeRssqRf/FOvxmpkxZYseXAh9pozB+sV83I3ZD11vGOvyTDOhR4SRJHrJuYVnG0DuKBGYxHDStpW02Iuhy7/+PzSlgG7eMN9cMi8A48yoTeVLaHrPDhBsj0IvJ9LpezUdA4ML5hXFONC2YI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777881351; c=relaxed/simple; bh=dCVQgRHFcTbGgiHoD6wqZ1Z8fhCxT95GCkwijb1fhMM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bdcMLOg0f2G90PF60k9CeWHjbcIjBYcdrYpWVuw3Dca9B4cL/0XeY1f2ibNdE/ZwJbub958fU7UCiwVEtAxjmUFr78LsDOESVXlpbyoSbaKLNXHY9cWR8HSTtVEPYj8ARN1SdfOuy3rfKyxjY4cm5CpHQKU8vJ56TgnNjbxXmF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E29aocr2; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E29aocr2" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2b458ca2296so21286665ad.0 for ; Mon, 04 May 2026 00:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777881348; x=1778486148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tOkfISWp3zKt6MhbV91AmgDxPSReCWlbub1B9xCSCNk=; b=E29aocr2ROCduS3yzEtABYNhf1szJET1LmVNrElFMyiz336vWfzDk5KsOwT5TgGby+ IWhk9xB1KjiS7JizjWvcfZQUbcymJsOGkouMa6iSEaWVeJfVo8a+N5+utleus3jDMj4p Nadd+U167aZoNzaBeXf3CopJYbvnDRmjOjkZvOsIBB3/6FstbCHB7uW9gBHW+ofOShms a0p4jqARrhcSeReAtn8pW9RrZga3pxnSb88g8ZZoojYYjtFZq1dXk4UIDh14EiNswMzc v5PiGUQ1zlG+QAKGWZwwiZXk9g08Pu0XzgGsLurqA62VyEqR8+sgHhnNOtE8QBumlD+X eLJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777881348; x=1778486148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tOkfISWp3zKt6MhbV91AmgDxPSReCWlbub1B9xCSCNk=; b=rx8qSyplFkBU295r0C86uXZCWP/dNOyvfMo/Me8RHc6Q/Lpc1BRwQXMp5a0X02vUiS xPFECWGA69LOjq8Uat8urM1drvd7LAP56EurQIkPK7oias5ozU74uphBVOcxDV+k+7kS Ym07VIE4RSiw3aogQPXerhZOIgpwEhvY/5Zoobfgie3YUr3adzkFLeTyKJRUYUZKve9Z 9jQUr1JyJMMG9Qc/65Gr47pfrOdlOmNmfyJEdHPGO/ILaND/rEK4kSs1xo56n1X1Eq0u phpyAX5msuBASDyNfbX5ADVeUXL4/6WsbQCnQ7hSqh1FImjyH9CTo8ZjXf3JhXQWPO8X 2rvA== X-Forwarded-Encrypted: i=1; AFNElJ9EZmBs3xYGKFRgND2quHXQuMDcQ6+MWbJ6YcT0Sroi0huxY7ffpdK35PcuooW4cZE4mg+TQrm1FGLJfAs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5I/ygyPRunkbTpZvbY36dYihn6qu6f7m5U/IkGZibmc+hsvjU o3aG/cLcM1TAXcoEYF6uZxAJL2rRYnpz5D9z3tioiPe9tflxopauEGWa X-Gm-Gg: AeBDiesRQDne0upDTv3wCN+Q87Yyv98TesyPV2ojkUejsLw87HoUw496wkksRIolrpL PDM3gevqxfjakfwf++fDiXr9P8MtRd4Ht97+D95QPIOUAIirqM7NzJ0tLBmsHPz8imIkQWrR9dO SYtU+k/XIhslDL+tfUnDSko6Duy4DbrZqdyGan0YHRTCfX8WE7AOCQP5mVy0A4KC+pbjgGQkmOh /Wr/HCluU87dbweUEqmFtJonrTFFDC9hyUyfGWlgUqsYjKuWTvQeJG9/pPMRqMI+vTTUprfMPKe To76HHNOzH+Y/+KMRY3EfhyTpgSh0adyTKnzZTm8v9aJVXfaPoJYp4TXHXI1aZEq0nxyhNVZUjd FAWkc/MoENizZhsJKD1ww9Xds51CNMPOw3ZbgPcwepVf1ptw+xE70v5PkQo3sodKLKh2+qyw3gr r/4bkvV3kU6mup0LrOYs7xooaJnA== X-Received: by 2002:a17:903:3887:b0:2b4:6022:bf8c with SMTP id d9443c01a7336-2b9f260b140mr83710155ad.22.1777881347662; Mon, 04 May 2026 00:55:47 -0700 (PDT) Received: from 007.. ([59.66.153.14]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae0f67esm99898255ad.51.2026.05.04.00.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 00:55:47 -0700 (PDT) From: Zhang Xiaolei To: linux-gpio@vger.kernel.org Cc: brgl@kernel.org, warthog618@gmail.com, linux-kernel@vger.kernel.org, Zhang Xiaolei Subject: [PATCH v2 2/3] tools: gpio: validate arguments in gpiotools_request_line Date: Mon, 4 May 2026 15:50:35 +0800 Message-Id: <20260504075036.12190-2-zxl434815272@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260504075036.12190-1-zxl434815272@gmail.com> References: <20260503190016.13439-1-zxl434815272@gmail.com> <20260504075036.12190-1-zxl434815272@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add validation for input pointers and number of lines. Signed-off-by: Zhang Xiaolei --- tools/gpio/gpio-utils.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c index 176bccfcccb0..930a38fe7911 100644 --- a/tools/gpio/gpio-utils.c +++ b/tools/gpio/gpio-utils.c @@ -65,6 +65,12 @@ int gpiotools_request_line(const char *device_name, unsigned int *lines, int i; int ret; + if (!device_name || !lines || !config || !consumer || !num_lines) + return -EINVAL; + + if (num_lines > GPIO_V2_LINES_MAX) + return -EINVAL; + ret = asprintf(&chrdev_name, "/dev/%s", device_name); if (ret < 0) return -ENOMEM; -- 2.34.1