From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53C7E34CFDD for ; Mon, 4 May 2026 17:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777915040; cv=none; b=dJ9PDzMgdzoYJlfcMyMa9PQxfEp1dN1Ja8DHoYzfLdCz2qr/tjEUKWQWsBxu0Vz1bDy2NHzWrMu8hUD/9yPJ1bgFQEoxPzZ+Bumjvu+fRiiYYmrMJSunFteQSA/wGNCm55tMf8qHlKkQZHnNkj4P3JEgo1OI75TpDFf1R712RqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777915040; c=relaxed/simple; bh=5rHDln5Du7UKyd6NUfaYe1P/1bzBY58whz2jgf0kGFU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ctbwd/Zj3jI7yaJb5XFiEdofPqIVb5+XbYIpUOKqOIpWzJMJY9uO/URTOr0zhoVOsnDTvfg5FM1QlH02zpfwBUo4GGimn9oI6/LhjmRZvXfCqhUtsMyjtjss4j/G5WE9/17dQQk9JcyLCFALUHkggJXevEAME9tf4SnwkXJzwrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gfVQdB2S; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OsYKnRh1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gfVQdB2S"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OsYKnRh1" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644FJ4tw3410684 for ; Mon, 4 May 2026 17:17:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=yBTfPe5yUoE GsgDSiMIe7M0rHkLENgYzLNl7AyqRuE8=; b=gfVQdB2S0kXcvC7hXFi28+Zbmmf JrSyxSNRjdOEwOR+ORye/m0A3fQjUmwBz7AHXsEIe/y2B2kFpJtgKOMvXcQH/p9P sl6GLVv/uOKnfD33wFQTV/V3BTPOvccMc8fX1VX84WaT1iHeYZiIlmKoYRv5kdEk ULXcBZmai3u8Qr+OQaBq3rfM5GnyRK2IyG0vXOlBJw9nFysKAwCpR+E0NwJO6hxu X0HnZRfLTV2yu2Szq2/puT2u17PfFTXbZOLhRBk/MJTAZGFI+VW0Yktaub0gagQj JL2u4JeDAxEckV3L0fM70PBfIOak+tjKB64O6YdF1wLEEHhuREQfwQZvbdQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxx00remy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 04 May 2026 17:17:16 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35842aa350fso8316061a91.0 for ; Mon, 04 May 2026 10:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777915035; x=1778519835; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yBTfPe5yUoEGsgDSiMIe7M0rHkLENgYzLNl7AyqRuE8=; b=OsYKnRh1c6CrZwkD1aMhFrPJgKgZ3rMw5iUpxTO7xiJK1RE1PUNB9y3DeF+3Qwo5Rr l3TDc857o2UGcad+cfMNf9Vsc3GXVJ7P/ajAKtRWh7hjLq1EoGBOf9VjEN6mva/DiwGG y3o67WGqWEk3Q9Nxku+4n8NVk/6DtQG+3n94Rq6rezq+Bfr6htK0UAIQUYVHeMiN/efc vXkOLJ1S4cPyWrOb2SHu1QhIh+ojIg92vXVImti5gwiur4DznC2F/99ZsygL7IToakfx FpuHUMfjzD9d0TSIS/Uxt2uB0Jx0xxISx+PO0jMxdWrrC4w22cvU8o9eorA0ZPQELhNU gZjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777915035; x=1778519835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yBTfPe5yUoEGsgDSiMIe7M0rHkLENgYzLNl7AyqRuE8=; b=C1T9lMBLx8PUtkvgPVWZeJIC3hZ0V0yJEqE7lGe1wg1qE43fzCFqLa6/h+hRCXRrfi LSt7Z0Xto4R/kDfjRrk3C4TQuiW47dkXFsjhR6yiWN5XMa2Say8R3UG1r9b5xHHy5z/f sZiWr9neSV7A7AhCdBSqOW7J9TxiBaFiY8V30vY+er9N+cIdQZvP5v8MriKDO27E1feC YJvlq6cBSn5o65WDjD+mkdwL9JrnZcdvABH4rAAUnl3OFGkTFMlEe61B1wSgLBT6S4Xf Lj9a2h7mjR7Z3bSm4lyUIbr4D45hvvUeGbI4f6/4ju+bvo249kzIJwNtCTg9sebT14ti 7lfg== X-Forwarded-Encrypted: i=1; AFNElJ8Yyb8hPgOKQjF74yPg0OXlNSZrIHL2fL+1ffgxMTE4/IscUmzF3Ub1tC//wVNcau/pu8DVRrfTrr9DV/Y=@vger.kernel.org X-Gm-Message-State: AOJu0YygRsnV9aSs9k1t+8jsM/bQ48JvsfgtewRk4/hRc8k770wQVosb wn0XRs8F9AZc6Y1oiVT+hur2qielHi3uWQMFpI7cGCTjNOcXvYTBVAqUntbdJLrm8KB1p3/x7Hs ZcnDmG9lYFNQngNmOjc9dDO+JtzSlYqK+fHDSGtKS8RwdiKOCJic2Mk7Q4F2IcW+UqfI= X-Gm-Gg: AeBDietFIJV3+RO8essEOsBDQnwuKfxeohAKgroNuh74EoVlk5QB+jgjak64qXOBTAB vxNrslEJNh7iXSakV6FwDuCnh/dRJaYqee53Z9Ntz45YYYPTeEQZAtSU6K4O9dtRu5CyGYDTZJ0 qTOYs/9orxQfvkFkbqlnoj1M1pQvNcmwk7YIroTpAsHTd2Gb/20nFBRy7UXntqq7TJBjTag69fa 4u6ITpOYmWG/SED6MchLR6QcEzuPnOkb7aX1vOhwxSAfnWqfdllQnbQbCWHe9GaL8zPUVRbHZ0+ OUH96wNjo1lhHkydOe2IXJ6a2MtEBQcFYbQtxmScVCu5/S7l3JqYkaoLD8ZfIDlN2tg2ZyLRPM1 2sIMHxWWWyc8lJJY258u7yOgWNIjXwWsjv/6aSUut7Fk4eNCPdNeR9fAMwc0= X-Received: by 2002:a05:6a20:1584:b0:3a2:d838:bfc6 with SMTP id adf61e73a8af0-3a7f1c392d9mr11544554637.29.1777915034904; Mon, 04 May 2026 10:17:14 -0700 (PDT) X-Received: by 2002:a05:6a20:1584:b0:3a2:d838:bfc6 with SMTP id adf61e73a8af0-3a7f1c392d9mr11544478637.29.1777915034013; Mon, 04 May 2026 10:17:14 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7ffbc6f063sm10398240a12.20.2026.05.04.10.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 10:17:13 -0700 (PDT) From: Mukesh Ojha To: Srinivas Kandagatla , Amol Maheshwari , Arnd Bergmann , Greg Kroah-Hartman , Thierry Escande Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Mukesh Ojha Subject: [PATCH v2 2/2] misc: fastrpc: Move prints outside spinlock in fastrpc_cb_probe Date: Mon, 4 May 2026 22:47:01 +0530 Message-ID: <20260504171701.18164-2-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260504171701.18164-1-mukesh.ojha@oss.qualcomm.com> References: <20260504171701.18164-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=APflyhIR c=1 sm=1 tr=0 ts=69f8d49c cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=6S_dsKRq4wc0odEj1ooA:9 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA0MDE1NyBTYWx0ZWRfXyfABjtcMNMMl AEtPI5UZ9iekkx6Z/2Hq2+7eKAYRCtw31vyuxfIGQ6YSkzr8lvJZ2eZifiHa5zNz+/Asi3VuPUA 6aF4pmbl/RogKSXSKKuT1wfke9fuqntQQ5DA9vgwFIQikJveVh3c1ZPq60giwkCSNqDsryhrKnW aOtWABLBkGKYibG5ZOj5R5FHc8x5xz0v43ZZlS6qM/9f/MflgPhnUupIoLerJDiimae29ok2qaR +QdO601Trrv9fag97bgr7ICETlgeqUApl+2XGPs7zPzvS/LwgFTVtDwVvZWI1dmqYBrKi2joaiN oFhb7C7EX8BH2HT+J8pvMeSkxtj3OnoleE2dQvyENyBCQfU0jXvs1nWMEsOpwQCviNf2su4q2lN MASSzYvvVWAPJotUk40LjY3XAqiNa5emRCGU1/gFmWlyOVCN0TMCfeFdyJkGF6d+RuaPAltwz4U jrCaOXTlVqXMuaV8PJw== X-Proofpoint-GUID: UeZ1eYKeL-mg7HrFKRGXZ0iTPCc0EkHZ X-Proofpoint-ORIG-GUID: UeZ1eYKeL-mg7HrFKRGXZ0iTPCc0EkHZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_05,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605040157 dev_err() and dev_info() were called while holding a spinlock with IRQs disabled, which is incorrect as printk can be slow and should not be called in atomic context. Move the dev_err() for the FASTRPC_MAX_SESSIONS check to after the spinlock is released, and save the return value of of_property_read_u32() to print dev_info() after the lock is dropped. Minor variable style correction in probe function. Signed-off-by: Mukesh Ojha --- Changes in v2: - New change. drivers/misc/fastrpc.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index a1a54453bb7e..d169dea961f0 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -2197,19 +2197,22 @@ static int fastrpc_cb_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; int i, sessions = 0; unsigned long flags; - int rc; u32 dma_bits; + u32 sid = 0; + int rc; cctx = dev_get_drvdata(dev->parent); if (!cctx) return -EINVAL; of_property_read_u32(dev->of_node, "qcom,nsessions", &sessions); + if (of_property_read_u32(dev->of_node, "reg", &sid)) + dev_info(dev, "FastRPC Session ID not specified in DT\n"); spin_lock_irqsave(&cctx->lock, flags); if (cctx->sesscount >= FASTRPC_MAX_SESSIONS) { - dev_err(&pdev->dev, "too many sessions\n"); spin_unlock_irqrestore(&cctx->lock, flags); + dev_err(&pdev->dev, "too many sessions\n"); return -ENOSPC; } dma_bits = cctx->soc_data->dma_addr_bits_default; @@ -2218,13 +2221,11 @@ static int fastrpc_cb_probe(struct platform_device *pdev) sess->valid = true; sess->dev = dev; dev_set_drvdata(dev, sess); + sess->sid = sid; if (cctx->domain_id == CDSP_DOMAIN_ID) dma_bits = cctx->soc_data->dma_addr_bits_cdsp; - if (of_property_read_u32(dev->of_node, "reg", &sess->sid)) - dev_info(dev, "FastRPC Session ID not specified in DT\n"); - if (sessions > 0) { struct fastrpc_session_ctx *dup_sess; -- 2.53.0