From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6034F3E51D9 for ; Mon, 4 May 2026 17:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777916661; cv=none; b=cC3lulHoXKIRbPkgU6vYjq9LG6ZqZ8yh1sEspIr6Cq+mJ1wtIM9BA+nSj/6ruc8IL5+oymsVRStfFKrYkaAg5nxBrwnzo52v9pUQvr6hVq9e1wvl+NXYcQnplEllG+cRL1GKyWGxDaYxsQZYXNxFjKYgM6zblCwNmBIXLS5xtqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777916661; c=relaxed/simple; bh=3O80B8Tg08neR6TboYq1DJB9Z8QdMxLgQcw+sTohlis=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=odRAovAOmFaWQ+U9rXdN5eUjTOGZ4BCk6i7B3qykKOehtdCtEO5wL30Gsym89gOPk58H/mfb1UFtwe4I242uIhJlllt5/Cs+Q9PmEqkIsbHVVpa0BVAzP/fTIB1oNQnoGasRQE1At3G7fjtQppfXdRE2HA8asI1UuXOEvlpH2GY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pi49gbkM; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pi49gbkM" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c6de5ea6879so88741a12.0 for ; Mon, 04 May 2026 10:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777916658; x=1778521458; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=krTIcQ2JQt6+k4WUKnvXQX31gKlIsDNsE0LIvDRf6ww=; b=pi49gbkMiH+9GH0Qi4riOMTa1639OBVAhNNjq8+qvqvzk7dftzL9AhOEY+76qj8uAJ bYIQ8o/b92dHCjTLd+mTbXNfO+xjr5DWh+Y6cs9hTqKkltOBgF2+teCuJ+PsD285tgP+ kJXQjrDmvUKsXBmqKv22g5d6tjIfB3FrNwFWWtKCrKO6bdTW9Hlu3z5M4biHBbuh5Xlh D9ykssIX3HuP+UwfDK8Wc7/W1LCExhfwiIxR9giCrISX9UN0kmsI4aIA228Jia0S6zt9 vGiA4v1G9iXU9s756EPQMZSGB25ASgNTMjZhXTo85CFOoOPsg4UA64tS8N2nuysZ1R2j bP4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777916658; x=1778521458; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=krTIcQ2JQt6+k4WUKnvXQX31gKlIsDNsE0LIvDRf6ww=; b=OgXDAf8iwJ2v1L8uO8D/wFZIAoJmv125IM1+oMXH77Zuqfor07WXEZbcKmwgvDYW8d dvWMX8GOuY0mQEl0YjnOWtw16E+4Ilq38Xznk5VCYu57WbyVdGWybx1BR9cD2GozkiM1 95H1ZB7pKYCgv3MlA6sA9vrTOhR1dGTlwa4D+BLH48XBKU4GG/mTL+bC9OcHab7Q4CY/ 8VwbUCMSDtQP6LQmlmpnmzsS0Neh4wrtIVSc+p6WcJrFWP4hX5MgAmxDw4rDh7pwt5Vq jNY8Er0nGWC47lShrSE9oC+Myl5iGOKBKG+c3RahJKkEXtEL7aHVjMW7PatMPtUAy9p8 KbdA== X-Forwarded-Encrypted: i=1; AFNElJ/YBLRSZ1rYRDQud8tQj1Sdi04xGKWsGP5uBrgPuIoOGpLGqknFzx2iiNky20gCrtthBTUx2Os3/DpNftA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyv8eTHjhngDS7K8Tsf6u8q4gWLUjnWYwVbEXrwRUdoR0G8ke3R 1eeu/yciPo+RghqRjyixB6zExdVlsE4PiY9oudkt3uS2PECUM/hXNy0V X-Gm-Gg: AeBDiesas9HeHhu1CYDGM+VVgC0Dlp4koLB5Q1WikCibf40gRnFXxYAk8kUSXWBHRdA ushQrEYXmoE9gis1X8ZhNjsMSVSeML6NagJqTkvFtSLQKVYF10gc8fdd36JgfZAiCKBlFvDROZ9 XP/7JXOaBWEJT4hrDngYbRclNEK0XaduPN4C82MFR1QdDIb5GQueIv8e4p7ZLZ1dyrQdnRcdP/A F7WNXfsh1n9exeOLYqLkXE4XwiRVA4PVTY4Zfb2jdASEFNd6hY8JMaS+mNlx1n2J0OJT/jyVKxo WEAr8Fa0n/Ej5dGPzNHh6LmW3PNp6skuObZ+SS7ZkibvVCdtu8N0pVn3wy1207cgA0688yPqsnu WeJZ2PYy/TxYLuoCY3rZwd5j42cyRDd4iaU9o4KL9PSvZwIaq9F8uOoCwtfSZ8vpIGEW26SfiOh /0npubsGC7C3ZXPOHR23z5PXgf/+jSiXwFStBii2CwhEjsJbf5twTpEOwRHLWwiqeyudFNIDQEC ubGKFIZ9NS7IdfNb6ra5O9OFqQ9WDYpS9mbFw== X-Received: by 2002:a05:6a21:600b:b0:39e:df5e:edc2 with SMTP id adf61e73a8af0-3a7f1a13ea9mr5741758637.2.1777916657653; Mon, 04 May 2026 10:44:17 -0700 (PDT) Received: from fedora ([2401:4900:a3fd:82cb:c080:4c49:655c:41ba]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83707fab756sm5923388b3a.44.2026.05.04.10.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 10:44:17 -0700 (PDT) From: Ayush Mukkanwar To: gregkh@linuxfoundation.org, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ayush Mukkanwar Subject: [PATCH v6 0/3] staging: octeon: replace pr_* with dev_* logging Date: Mon, 4 May 2026 23:11:43 +0530 Message-ID: <20260504174146.117026-1-ayushmukkanwar@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series replaces pr_warn(), pr_err(), and pr_info() calls with device-aware logging functions (dev_warn(), dev_err(), netdev_err(), and netdev_info()) throughout the Octeon ethernet driver. To support this, struct platform_device is passed through the memory allocation and receive call chains. Additionally, the receive group state (oct_rx_group) and the rx refill delayed work (rx_refill_work) are refactored from static globals into the per-device platform data structure (octeon_ethernet_platform). Changes in v6: - Squash the structural refactoring into the same patch that introduces the platform data, so each patch is a self-contained logical change with no inconsistent intermediate states (Greg) - Rename local platform device data variables from `plt` to `plat` to adhere to standard kernel naming conventions (Dan Carpenter) Changes in v5: - Pass struct platform_device instead of struct device through ethernet-mem and ethernet-rx call chains (Greg) - Move static oct_rx_group[16] array into the platform device private structure to eliminate file-scoped global state (Greg) - Update kdoc parameter names to match renamed parameters Changes in v4: - Broke the series into much smaller, focused patches to ease review - Removed the global cvm_oct_rx_refill_work by introducing a per-device struct octeon_ethernet_platform, allocated during probe - Retrieved the device pointer via platform_get_drvdata() and passed it down the call chain (NAPI poll -> rx refill -> mem free/fill) as the first argument to avoid global state - Note: Dropped the ethernet-spi.c IRQ handler conversions from this series for now, as those errors are SPI4 bus-level Changes in v3: - Use netdev_err() instead of dev_err() in ethernet-spi.c - Pass the netdev pointer directly to request_irq/free_irq instead of dev->dev.parent - Move the device pointer to be the first argument in helper functions - Fix checkpatch alignment and line-length warnings - Add missing @dev kernel-doc parameter descriptions - Wrap commit message body to 75 characters - Fix author name formatting Changes in v2: - Instead of adding pr_fmt() macros, replace pr_*() calls with proper dev_*() and netdev_*() calls - Thread device pointer through call chains via function parameters - Introduce struct octeon_ethernet_platform to pass device pointer through work queue callbacks via container_of - Store device pointer in oct_rx_group for NAPI poll functions - Use dev_id in interrupt handler to pass and retrieve device pointer Ayush Mukkanwar (3): staging: octeon: ethernet-mem: replace pr_warn with dev_warn in free functions staging: octeon: ethernet: replace pr_err and pr_info with dev_err and netdev_err staging: octeon: replace pr_warn with dev_warn in fill path and refactor rx group to per-device state drivers/staging/octeon/ethernet-mem.c | 43 +++++++++------- drivers/staging/octeon/ethernet-mem.h | 8 ++- drivers/staging/octeon/ethernet-rx.c | 49 +++++++++--------- drivers/staging/octeon/ethernet-rx.h | 11 ++-- drivers/staging/octeon/ethernet.c | 64 ++++++++++++++---------- drivers/staging/octeon/octeon-ethernet.h | 14 ++++++ 6 files changed, 114 insertions(+), 75 deletions(-) -- 2.53.0