From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466B63E6DC1 for ; Mon, 4 May 2026 17:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777916666; cv=none; b=iwqwY9Fb0Tgld9HNTonUl6WDCv3Zt79oLsgCQWHB0zUBXAHPa5P0cIbbp8kOUvY8Rl/uvSOoHPs/0i8hhIOnFYEgo6rnj6zmyL7rWty3NZXL/SXl/zA6qBq7B01ETSMAP4PimPP6Iff07ym2nH5X+E9ptjI9SUGx5TTYz/YHy+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777916666; c=relaxed/simple; bh=YYvpgqkGcESzblP9Rg0okEYFQUZWUrc2vIkh5JgCDog=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ceS/rS4AICRIRuYo+0mEJOR1HNXWW6V5thMxM2E3dyEvuwzkCgwpvN+yHmpbKQqKX9zxc2R3bSbQyV9bIp05b7vpvURVd+a/xG1wZNopFW5l9VwOIIoxtwB59JAOW0sy9+dcO4wYkUd52K/m8GUp6hP1hO3KI3POWMj4ly7saFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PRdfW5vI; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PRdfW5vI" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8385cbaab7bso137448b3a.1 for ; Mon, 04 May 2026 10:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777916665; x=1778521465; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S9NrbK7+XvJgPClZ1GqtV5IQNzES6CwjBK/rud9MZ0Q=; b=PRdfW5vI6OIRJHX/k7MdQyUXtWIsLulJGR0yXguJIZQglnxFhNmF/k/EZWc3JVo39W cMgxcpfCBE85558KEd2ZRbdC3E1mbGDP6Fp4siHqWpEHzkJZlYxYXMZ/BXIrTOsku0iD 0yQrxEKYvoly6TrzHSY26tUg/0sHkoPI4z4IA8tlUJx3m58b/FZWtacX8ew7AAnQQ5l9 OnOVb2AQt/2u5QgH4qdwgtuJcXpHYSDZQLnfOf+uSi08kHePlTcsawNgaP8Xbiy/Jcpi JNcJJeRTtv+dx7gZKaClNTGoMTYjg/TFPdGqjm+FghrTgL9jWBp2lqO9Ir5V2Yc7M+jR Jqqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777916665; x=1778521465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S9NrbK7+XvJgPClZ1GqtV5IQNzES6CwjBK/rud9MZ0Q=; b=K3MMxUcIBfwmOBxjtdumImv5POp4g0Xp9DMyWcmIWXiOaO5Krxvv5oHFI7daqyo2OH A/bc0opR2RZYg5gV5TA1rW504l/didL52CA5nE30LjGouJSdEUdKcK1OkIFb/PFNFziR 94w3Ebee104tfYKSFeNTuS8xXfwwSezdK389imOaU5UNhf5cwKjPBPjAsC3RzQo/gmh8 fYf6urcEn4z1N4WzJllHjYYrz9bJPQvIQ8VzUjUn9U46sqKtMUxq+k8Os2Ttl5RSxNW1 fJYY8Cw/5YsTBQrTBoG15l1elPz8xPIE4khOSjIYSuohjgj3INxm3So8pFuane8WGLj8 dyxQ== X-Forwarded-Encrypted: i=1; AFNElJ+Tvbr2lGQJwHvTpPAaKQ0i+WusOoTEwhfRje9/VS4+bAFLnLnf3UY1rsh8GPICyDFMPnK0Xojr0BkFEig=@vger.kernel.org X-Gm-Message-State: AOJu0YyE7r4EFBPIzgrfePF/8U9jZXB63ZuaFhUYOxxXxEIuTSOc9z/h NOfv4I6ZdariFi4oFAUrjmIZZtVYQr63GQLoWXLzl67lhayz87yNzbPx6Cr9AQ== X-Gm-Gg: AeBDiets6QLhLGNzqYbkgEaiA77AsNezodyNNAVzKU7tyCjGCW0f3YJfV+kXzPyLn2H bUFA7Mk2GYlBc55F/bBriNnw92vZ/pT/RoSa13tcJO9HBpVTMiNtr9ARK2fAyMe7UvuhalUuBBh Hdx/Y8/C+VYmpYERXwLqV+nNlV/WHcIAnQ08rZWgBrb7ynsy43QG9ljsNmWdOAXoeTw2BAQrU8B PKR9a+CibSmCM8H7H2rQhiP67bQQFBNNw5EPir4xpccLaK0pA61kFrIzG88dvOjcYqkqnaN2FSc +Ok7wE8YNFpOK/v3AzHJ9T0rgjGjq3FA7lklMiAADrS+9qJO4AJUvxK9lQ6ZsrCExuDOg6sFLQ5 HPRHj/ZZUTc7Dv6u1iRMihZDMN/WxmeHdMRjBoRU0m9cTpgJZ7rqULEh2m2XPTaIfiMZP4iISLR i75dNj3yJf1+tzgn8lGAWnwBbOa4T0a5KMb2Hmif5DzKim3rkPpUpMrSN/XkYYUb8Yy4lJfuLvI 6SWbFSfiwPfJS7/dceGaHyJeQA= X-Received: by 2002:a05:6a21:a510:b0:3a3:2819:5d41 with SMTP id adf61e73a8af0-3a7f1c8590amr6200524637.5.1777916664548; Mon, 04 May 2026 10:44:24 -0700 (PDT) Received: from fedora ([2401:4900:a3fd:82cb:c080:4c49:655c:41ba]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83707fab756sm5923388b3a.44.2026.05.04.10.44.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 10:44:24 -0700 (PDT) From: Ayush Mukkanwar To: gregkh@linuxfoundation.org, dan.carpenter@linaro.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ayush Mukkanwar Subject: [PATCH v6 2/3] staging: octeon: ethernet: replace pr_err and pr_info with dev_err and netdev_err Date: Mon, 4 May 2026 23:11:45 +0530 Message-ID: <20260504174146.117026-3-ayushmukkanwar@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260504174146.117026-1-ayushmukkanwar@gmail.com> References: <20260504174146.117026-1-ayushmukkanwar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace pr_err() and pr_info() calls in cvm_oct_probe() with dev_err(), netdev_err(), and netdev_info() to include device information in log messages. Use dev_err() where no net_device is available (allocation failures), and netdev_err()/netdev_info() where a net_device exists. Signed-off-by: Ayush Mukkanwar --- drivers/staging/octeon/ethernet.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index badf5ceaf5b4..27c282ef64dd 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -685,7 +685,7 @@ static int cvm_oct_probe(struct platform_device *pdev) pip = pdev->dev.of_node; if (!pip) { - pr_err("Error: No 'pip' in /aliases\n"); + dev_err(&pdev->dev, "No 'pip' in /aliases\n"); return -EINVAL; } @@ -783,16 +783,16 @@ static int cvm_oct_probe(struct platform_device *pdev) dev->max_mtu = OCTEON_MAX_MTU - mtu_overhead; if (register_netdev(dev) < 0) { - pr_err("Failed to register ethernet device for POW\n"); + netdev_err(dev, "Failed to register ethernet device for POW\n"); free_netdev(dev); } else { cvm_oct_device[CVMX_PIP_NUM_INPUT_PORTS] = dev; - pr_info("%s: POW send group %d, receive group %d\n", - dev->name, pow_send_group, - pow_receive_group); + netdev_info(dev, "POW send group %d, receive group %d\n", + pow_send_group, + pow_receive_group); } } else { - pr_err("Failed to allocate ethernet device for POW\n"); + dev_err(&pdev->dev, "Failed to allocate ethernet device for POW\n"); } } @@ -812,8 +812,8 @@ static int cvm_oct_probe(struct platform_device *pdev) struct net_device *dev = alloc_etherdev(sizeof(struct octeon_ethernet)); if (!dev) { - pr_err("Failed to allocate ethernet device for port %d\n", - port); + dev_err(&pdev->dev, "Failed to allocate ethernet device for port %d\n", + port); continue; } @@ -897,8 +897,8 @@ static int cvm_oct_probe(struct platform_device *pdev) if (!dev->netdev_ops) { free_netdev(dev); } else if (register_netdev(dev) < 0) { - pr_err("Failed to register ethernet device for interface %d, port %d\n", - interface, priv->port); + netdev_err(dev, "Failed to register ethernet device for interface %d, port %d\n", + interface, priv->port); free_netdev(dev); } else { cvm_oct_device[priv->port] = dev; -- 2.53.0