From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D16522A4E1 for ; Tue, 5 May 2026 00:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940716; cv=none; b=fBIvKss/yD2A3RImjFz2jfU1nXlIs7duDwlNuGORpmfYOWt2oBoDsS7jxQ8Nsg2vqf8spCMic144ydOsiEF0C+7Mi/pxq9oiWi7rWG3ZlvKWo7HN7h1uiL0VFf3QOES2CKl1I68znRU6gfrVAaKeAs7QOkA0KQXReYlEHOM+UME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940716; c=relaxed/simple; bh=dH38C2Kbg849nl4YLqXv/0VJPZa24rewDmxXYahkdsA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sCJgjywE01h47OWt1VkjjG9LyOAC49TJ3D+OuRbhOP1UV5Czzr/OQa4+r1IXsmvibuoBu4+Y9IJfXVfLEdl/qFZh+rHjYi8caCLcPBl+7FIX13qzoprtsF5BkiGal/cEFfRZpKwmc9tFSKJffblB665U6aQFzOvdjSMAm9h97xg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F+YeDfkZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VZ8Xu01z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F+YeDfkZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VZ8Xu01z" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644IpKuh1151167 for ; Tue, 5 May 2026 00:25:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lefrgJVtEuX0KnRNQkpJGxwI16qD4hB9JXPY0Y5ZgqA=; b=F+YeDfkZWHOFpsDG QKXjzg6cxfHFinv0XRe7h11p3xF+u7RekwweaodT6oPiCxc43o2E/JloWzGY7mWF lQSHr78s9pxYtfGvQqwL4R54mLHB5iWS3ZNXdKWDprfhazR77KFU5R+lE1Pu8sbI mNpoyH1wHenN8AFoV9z4b1vwIsQUOLfrx1JFNQvx4wExcnu42tqno7G/eeTofRml rk1cMxbPy4G13s8y9niO0JnYoYc08EG0YQ4meaILo9vG7S4REnk0osqvG0Htyi4G xndOs8uJYk6LBmvMmMmabl9xfWkvpMaRYJXzVWRLpscJG2QkJiInvxhzGUFQeIev fLxNrg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxscyasf1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:14 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50fb3403e99so132400641cf.2 for ; Mon, 04 May 2026 17:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940714; x=1778545514; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lefrgJVtEuX0KnRNQkpJGxwI16qD4hB9JXPY0Y5ZgqA=; b=VZ8Xu01zXbsP1jQ4QPx0/zUg/is1deUu80+++WAp9i0wZSa4TLjUq9uAf+2KlgfC08 rik5uuNaVlamYv++myZUJke53/qdsAjQzatWT8jbvAc18g1+tLuRH1Mb92o1jo8trfui cXACuFr1J+ro7vgw7d3CuKxaHQxWkD+e097idqpyTC/wsuRKlNLv2yjk/ZTVGV1Ok72D BhVrG4NxxtF33fDgOwPi20sZtA/RMVuKbq7RtLjQ4KPza1sz9S2e4CzMW/z++3n/dWuf DEeoIqSQTmIZeoeeydUtpUhziW3XlOgB4DLq+MZGOCmXwAEoVPUwS4KUnYKABtKDeo41 HRBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940714; x=1778545514; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lefrgJVtEuX0KnRNQkpJGxwI16qD4hB9JXPY0Y5ZgqA=; b=o4/3+K4MHRgnLR+ECRoV4f7efXlHsLk4RkQMc2IT8RDjgaVt2UVIFfluQH6MKAJ31R 7ZejyNL3gXjO5QdfB0uso3SVVr74VlhTdyz/iva5N7HZgaT8JSgu/OpHCYjla6KdgnF4 A406+mnG/pcya6QQHG/EDeimkHhuL5krGs8ARMNHdZ+wINKi8etPRZKuFECSsxL/s+Qc s9jPQVfRcSbkBTtJUSqWuv6XNmyPJBY+jO9tviRbzDOELmJrniEXJH0IZIpvT5NZgjpI 4qa9i6yA/RPKWQy4lKUJeGePoEwFBorNp80rE6mNMu0//QfMQa0tuNBOuG0ribHhAeBP jaEg== X-Forwarded-Encrypted: i=1; AFNElJ91d9Hb6qJJKDjQUDrW3V6dwv4FVbSHIORJ76ETdXF3SeB4enMnfr3JT5+9/tCPJA4R6scZ63vh+XxLDCM=@vger.kernel.org X-Gm-Message-State: AOJu0YwpDd6xoUWH2aK+p5bvbj3qCfSSo5BvxX8S5a9lzNtCLEUt1vay eIUIaHvSgj+HMul9U/ClSXdIrgqxG2MQDmU0sbh1zXUgUtexHMj7rRuWoJ5Qlie6gxAKvNkSSDa nebF2qTWPXO9i2L+ZhsUhLaikvyvDPlHsdI4JJj7sGc7N3VN0x1zaeqKHGV8/3zpYkog= X-Gm-Gg: AeBDiesEW491SNToY3WCQX1w4oUWx4lNMwWX3ikoqTz1pOIv3M9biENj7mIGHj5J+ot jpq6h9g3v/vB5a29s1HsDgkLeN13leHCw1er+cCLdc5uzYnM1H132LLHY87WRE/8wbO8mKjClqm 6HRtbZ1oe7I9COGCC6r3cCEzpU0Q5FS+wP5MJX4KTwv+/j4SV5kcCd6j1RF0sMK0ykr4kpQfQsK YENsezH4es7VaUGdKJhPMHoyFKwR5MZu08FF1Y16k3BHG18E9SfdR65ef/AXnP5QLtUuwb7wabt xBsdRoqGe6hcQWwdAtogCf5W6+yCe7pAUFKcchCGD77l/CA1pB5bqu7fjFYYNZqwG7ar3s69AYb zZsIpXMnZaZ0M8BzfDTkpF9Ckp1xgGXhGCKWRpZT7Hcpx/lY9tXn507+M5jJpmWq36jqUYx5JTX j8OX4QjpYsO/CZ4eBG7nuMOooHUa2fm6Lm0xLfRHzHZVRIcg== X-Received: by 2002:a05:622a:282:b0:50e:61c1:685f with SMTP id d75a77b69052e-51306b1844fmr14830771cf.50.1777940713699; Mon, 04 May 2026 17:25:13 -0700 (PDT) X-Received: by 2002:a05:622a:282:b0:50e:61c1:685f with SMTP id d75a77b69052e-51306b1844fmr14830191cf.50.1777940713228; Mon, 04 May 2026 17:25:13 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:09 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:24:58 +0300 Subject: [PATCH v5 1/8] drm/msm/dpu: don't mix devm and drmm functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260505-wb-drop-encoder-v5-1-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1528; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=dH38C2Kbg849nl4YLqXv/0VJPZa24rewDmxXYahkdsA=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+ZPi9unXUNNI00Krz7+VDWt6BKz8kdLKWkRphtrvT+tO F3yoFekk9GYhYGRi0FWTJHFp6Blasym5LAPO6bWwwxiZQKZwsDFKQAT8djP/t9rQ8Yu81/an5q3 rJSazL88v6Qg6rqfci+vw4F392J2OXhb6F+bXn7AUl1C48Ae0c1tbAcX+j+ZJflB8KL5/HkqJTN ye/T1bjRqM0+PfOD7Ivx9ZcRf9SRLa8/eeJmSyWEeQg7iocemipjYJE66WOLjYqdknH9QZIZhhc SFWQmania3X3p0u63XXMTwUzw04VhArOWiPNv3Gadi7q6sCPrJZ3z3Y8WlcrM0Cyev5stMi14q1 Ey0dW1ke2VoVigm05CXIVTAPu/wnl8LT7t5TSg3nf38A5NlKv/6Pe3mn+701XoFb52XvZ3V47Oz bMzx997pzGmPbn84VTR9Y1ffnBe27nwafrm3bhcXpxwDAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMSBTYWx0ZWRfX7CN85OsMdQd+ oTJ3OKjhNzxcaLC2/pzAYoK7DF194uCyJ0yLmecQr8Jtxk++gnWJSQgba/nLDU0CrAsdUxAz7/h pN1NndsR3QExm9FB4O+bh6JL7TO7oZCdmsQLC/YW+pwpzUwBZNpHBLUdw8vJQMtQvHXlN9VuCli WOClAPM4CRdrIkv26HWwxOHjk50fwkGa9KCMg2i00YwrAdxUNuVxe5qZtWOv6E82sENcwSRU9WM 8KWGfDrHsHYQErNNk2aAOhMtKw5YRMsa4r5v0aM1NA08lm9bOAouPP5paiZEBGu9FpqstfZMTpt gradT2qEKrjHEU6E2Qm1Ha6hvAxV3RPjd4hx9vYyasEoe8G6jJ69BfvV5jN72UNe1htVGe50xf9 SO2iCKbaFcnerw8zfPNlLu5F3H05N5BBZgZImqjDvSsxHT8FSo4Hb1C078gh/J/gnjvUxwmA5GF aN9+nR6d6JotI0TqrnQ== X-Proofpoint-ORIG-GUID: Jw5-4JccOjUOOzfy-cCdW6l4uTdn6q7e X-Proofpoint-GUID: Jw5-4JccOjUOOzfy-cCdW6l4uTdn6q7e X-Authority-Analysis: v=2.4 cv=C47ZDwP+ c=1 sm=1 tr=0 ts=69f938ea cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=x0dpNPXvP2gp0MABG64A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050001 Mixing devm and drmm functions will result in a use-after-free on msm driver teardown if userspace keeps a reference on the drm device: The WB connector data will be destroyed because of the use of devm_kzalloc()), while the usersoace still can try interacting with the WB connector (which uses drmm_ functions). Change dpu_writeback_init() to use drmm_. Fixes: 0b37ac63fc9d ("drm/msm/dpu: use drmm_writeback_connector_init()") Reported-by: Christophe JAILLET Closes: https://lore.kernel.org/r/78c764b8-44cf-4db5-88e7-807a85954518@wanadoo.fr Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c index 7545c0293efb..6f2370c9dd98 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -5,6 +5,7 @@ #include #include +#include #include "dpu_writeback.h" @@ -125,7 +126,7 @@ int dpu_writeback_init(struct drm_device *dev, struct drm_encoder *enc, struct dpu_wb_connector *dpu_wb_conn; int rc = 0; - dpu_wb_conn = devm_kzalloc(dev->dev, sizeof(*dpu_wb_conn), GFP_KERNEL); + dpu_wb_conn = drmm_kzalloc(dev, sizeof(*dpu_wb_conn), GFP_KERNEL); if (!dpu_wb_conn) return -ENOMEM; -- 2.47.3