From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EDDB279329 for ; Tue, 5 May 2026 00:25:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940729; cv=none; b=hYHQJO2h8V57uCHpG8QRrjx5TpnsnMPR+RDyGyb+Rp+EU0nodIR9ziCU+VUVzBFZqwDXEVA8zEJAjnGFyNEfAZ2dN2iWL+0Ngw5a4cfIwQaLifTtxMKOb8vsMqY2H6o3F/Vj8CKgCCKpxUt32N5QCEV8xLbLLyMJZ7C4o4Ku7Qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940729; c=relaxed/simple; bh=MhO3rZwygKwYvVhbAVjitmlBMP9oPZA7uZa37YA1WtY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HLkjY1IFjYz0oqDLQMJvlxSAVP9mJwsVmPGMBwcDdnfx8WTuJTcGJZ4VFw3genIZ0itURCdRxsZhzeYsnpD7W8X3unB7YbXbv1eHL5J4rUKe3SIeIJUsRvxj/qm2A1voR2Uy2gMQ8ijqfhcoRFVyVRdTt8lbyCHohienOCQHU4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=b1dGjabG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WIummX6L; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="b1dGjabG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WIummX6L" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644JUME5299982 for ; Tue, 5 May 2026 00:25:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rvUq8Kk9vuSdbxC2mnaQWgVoYwyqvsDFVMNCLtB92nE=; b=b1dGjabGKyCNTbxD yLDHiPiPeFvVWtTCkRJYDrg/dp/nU2DyCcAL/+dYSlOjmTsGeufe1sG3LJv4X6KI 6nFt9RHqTHrleZsnidTesSppQ/GDCRv8SSRtzGAmf4GtMS7jWQjAFAE5r+Cp1tUT sA9whihcJKSdWmkvHgm7/CV0GG1bEMNR0W1R7KsZIG1E2hOiz8dYEFob+dDInPzU kwVhb0roTk/XPiVKqgvrAkqFgLoZrFRwQEoIFX5MqdvevQ4CuAKOqaSTtSce1L/V cdVodcjRpMIBljUL2IuiNzYaYEuW+EcOSK67DMaakYd7jompYkuPW6Q7k+DEuZkQ 3UPZ8A== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxvnda6tc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:26 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50fb007bc36so119143941cf.3 for ; Mon, 04 May 2026 17:25:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940726; x=1778545526; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rvUq8Kk9vuSdbxC2mnaQWgVoYwyqvsDFVMNCLtB92nE=; b=WIummX6LxPwf1nP1vYUf2aPoa6Vg9vMyZ75ZVGpmwVDysD0KBVXPHTFMD3uZFN1tiX w3IdKN3Q834jtmy5981lErEiDrBXjC6evJGOenXkHACfhvUz+xU8uy3V09EKn+cvTbzW omsEZ7VysQbgy3CHxV2/7o35hh3HjTjG1A32uSlziEzfJATCCfs0VhDik8z6IvFRcq4T nNy2uzSEFwNwhbR/lVSJuPn+NmAlzeVfuO7RkJSHAyCVOnyZQhf2joRcfLzbwWiwFZR1 N5bxW1xVfoCh7RVKB1RStUq9+JTxxfjCuckloxQGi1rVolIygKP0wZq/L6DKTv6Xc7x1 dF1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940726; x=1778545526; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rvUq8Kk9vuSdbxC2mnaQWgVoYwyqvsDFVMNCLtB92nE=; b=Mt6AuoedmHaWRa77bFwaWpb8D7SW3G+SBBRjacVBqv/5DaZkuY6JEoCNcvIolsUO6e LWrKewjgWurxmTYcf5NVq2I6m9TyRgML3m2dseLyqMYSmJjuIV/Hq7Xd2+iKf9S/dyAy 5hE5wy9BMrrn86yh1OG6GUc9qTCQ0DaOzV5GdOIi/YYLRRoq/lZyDFoN7+3/U5KHDCj8 iUYh5HyO9iAMmV3ca4/R4lEP0JXhCX7Vxwm1/dls6DNkmv6BGlc+7D1tjtpqf47jqSFh xaV83u4BggK+bF3jYhwM07CWX1yU86K1yATIagIc7obm1PDxuePqBk0jyVKsXx2KYoGB nm8w== X-Forwarded-Encrypted: i=1; AFNElJ9AItkDtlNieGWdisAF3TlbWUgDnKGz6Mp34tm8S9CkvtHoDJWBnoUtWOUFv3HHlzV2ZCDxV4QXjyPJ/t0=@vger.kernel.org X-Gm-Message-State: AOJu0YxD/Br3KnmHxb7iIHYdsbY3IukccAJAJgOj2JbFBgDDtDiLwu7m Jt4iHRlWzp6DwS1fjmz1Zk7OtWxT5yNMnoQJA160bG4J6aqzvjma0u3SX2rClVhtWBbKhkyxfy4 Dit18dU5PmDUAXqfKUT4LsfjPxlJjACfdBbI0W8+q0PnEztofr++/jUam2JtlEo1/F30= X-Gm-Gg: AeBDies0eo+xFkXrEyanrhyObxOfwUzcwz4Sn0FW5JP9CWKJUCSmGSYmp8R8Ubo9USq Thu+JoP9KFB3SUugRaf/QXDb22fDpeDxQWl38mD4XblFek5+OM9duALUX7LwXGhgxGyETD4e6iE g/xyPh6vAjH02YqBK58/ZMwpH93R34HP6TCPOdrnfQHPIMP6jI8CLKq0hVPsaZ2S+FOhYFmqgh4 QtxPeIU7g4nDncH4FHOrGcPv0csLLVucSg/PYe9MWnKvgntVeBGEBICzghOenFzhtgUJzee/Vwu GRTBfirt3xftlrcIQCpio2dKA9sZsxnMSPd8bEPqt7vqmFRn4WVzdP04m9aqgzhF2epCZNieGfZ o2THtOKgroFujlqQwksdaDelcwzsrdm3cVfX0suOhzRpVaDuf49C9uRggCJudF9h+ExCj94+Zz+ /YH9QL8bHFsx4xuvBCkGU5aTI3zbc2X9VGU2CoCzoa0rTkaw== X-Received: by 2002:a05:622a:40d:b0:50e:defb:9dca with SMTP id d75a77b69052e-5104bfece5emr172357781cf.45.1777940726061; Mon, 04 May 2026 17:25:26 -0700 (PDT) X-Received: by 2002:a05:622a:40d:b0:50e:defb:9dca with SMTP id d75a77b69052e-5104bfece5emr172357201cf.45.1777940725522; Mon, 04 May 2026 17:25:25 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:21 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:25:00 +0300 Subject: [PATCH v5 3/8] drm/komeda: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260505-wb-drop-encoder-v5-3-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3249; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=MhO3rZwygKwYvVhbAVjitmlBMP9oPZA7uZa37YA1WtY=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+ZPizsaWSG++ua3XqdZxT4V8/nV/ol/R89c0bPvy9Qf3 lvLEfS6k9GIhYGRi0FWTJHFp6Blasym5LAPO6bWwwxiZQKZwsDFKQAT0eBi/7FXLqU1JluVYXnM ek7FCO7OM2kLzANuVBVN6F3g+c0rNvzj/w9/CroPP5Qxya3MiJO1j/S7mKAp8+HIUsWTyzh5PM7 Z+GdqSh1NLF8v4TN5Uju7/TrRv3eEJzyaeanu8Zdol8sGG03WbTixIs/oTOdK+6SX+iprN62Pm3 gtZBm3l1SMrpmi3GtBXU51M/M/+XP35866ZvohUE3PJoOtoCfgn0BvkfjByEtO1ct/vDxVsn+7N 7c7Z2eNjQGTfbv1303fVcMW9m28Vx/F0Pq43vgk14Rcy1MbGhLOKGl9DpNKqjh4YmnPF8l7Rgpf WgOr+IwL71fOPSEeeUTI6hmD0KGVmncjd6t53GyrDAEA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: eKqHbQ952lEBvBBM0d9exVqGhxqa16TI X-Authority-Analysis: v=2.4 cv=d9jFDxjE c=1 sm=1 tr=0 ts=69f938f7 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=gYs8AAvg_5cFonjPjrYA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: eKqHbQ952lEBvBBM0d9exVqGhxqa16TI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMSBTYWx0ZWRfX26pB2hVj+iPY QQ4YA5JzJ5c4i2ve47K35mtg2JgvmmbzLsCLXsUe1Vl24D3LH0eoBWcCZJeBAGpxIexwr8V5Z7R BtlILDVicIjAwu2Epixo6jzaKGwfDFYQ864dB70js51vecoHmqBvScEON9htYjIQPDZt96pwFTy LOHGWuBU8V2qvYngBRGaUmteNR3xOoLx5wbh8itIG6aFrMhJM+/IvcZFaZLZhI+2kr66ivbFMJ4 N4siM7sWWbKh3TQFAKya88jTFc42m4uECzC+PQWSDRjVGN8HhQ1D0C8h+ZxaFvAOD0Ld3CPLzCd vgzBar0FxNR5vhcz0XtYQrkUmGmUC6Sr3QxiOyeBcsDZ9YLn4hBzhAaXBiKO2YgOYwsFSF1HIbH Pv9kgQmIlp/QEXR2RCvnrCh8YYYewjEQHppSnu49PagyOq9jc7BlEW93vBftpIFhqmrU+yLpkIo dehLmOAlQ0oQwUOPsoA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050001 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../drm/arm/display/komeda/komeda_wb_connector.c | 30 ++++++++++++---------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 41cc3e080dc9..bcc53d4015f1 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -5,6 +5,7 @@ * */ #include +#include #include "komeda_dev.h" #include "komeda_kms.h" @@ -121,17 +122,10 @@ komeda_wb_connector_fill_modes(struct drm_connector *connector, return 0; } -static void komeda_wb_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); - kfree(to_kconn(to_wb_conn(connector))); -} - static const struct drm_connector_funcs komeda_wb_connector_funcs = { .reset = drm_atomic_helper_connector_reset, .detect = komeda_wb_connector_detect, .fill_modes = komeda_wb_connector_fill_modes, - .destroy = komeda_wb_connector_destroy, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, }; @@ -143,13 +137,15 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms, struct komeda_wb_connector *kwb_conn; struct drm_writeback_connector *wb_conn; struct drm_display_info *info; + struct drm_encoder *encoder; + u32 *formats, n_formats = 0; int err; if (!kcrtc->master->wb_layer) return 0; - kwb_conn = kzalloc_obj(*kwb_conn); + kwb_conn = drmm_kzalloc(&kms->base, sizeof(*kwb_conn), GFP_KERNEL); if (!kwb_conn) return -ENOMEM; @@ -165,11 +161,19 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms, return -ENOMEM; } - err = drm_writeback_connector_init(&kms->base, wb_conn, - &komeda_wb_connector_funcs, - &komeda_wb_encoder_helper_funcs, - formats, n_formats, - BIT(drm_crtc_index(&kcrtc->base))); + encoder = drmm_plain_encoder_alloc(&kms->base, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &komeda_wb_encoder_helper_funcs); + + encoder->possible_crtcs = drm_crtc_mask(&kcrtc->base); + + err = drmm_writeback_connector_init(&kms->base, wb_conn, + &komeda_wb_connector_funcs, + encoder, + formats, n_formats); komeda_put_fourcc_list(formats); if (err) { kfree(kwb_conn); -- 2.47.3