From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 993442773D3 for ; Tue, 5 May 2026 00:25:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940734; cv=none; b=qC6yhdvtzuq4ViXiDzB9mOqKe5lEMMuVKX9tQ+wc2D9rrfqenGD2bXMCUxSI5a+wkm04XMb2KiPbyVvwovmkWiJjBbEdUJ2Z9bIdrn/ueB6kOBG8BnFp4EYJS93WOI8cnzaUqHdedHmfJA6Xz0DB2NTXmTr7wOW+r0hcAkdWS20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940734; c=relaxed/simple; bh=FuBHZIwie1er5ktaJK0YV3oa/OgU1IZweJZeXfhYARA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IbjP2FII8DSNP/zBHGl9UUs/IWsub9CNPjjpjrc/lWxJF7XDSY4DDOIjmzzwjGyfMXeUTwL4ZTFbC2NqPL4aqXVkcvluzX1L5pQco4lQ7qBlsIj234Ujy17GzSmhxGXeVKG3LCE/dJw9VkYQVrZmUae+A5pQViCIotMducVnxgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JcLh5r+N; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IOgn8OD5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JcLh5r+N"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IOgn8OD5" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644LJLIO1960741 for ; Tue, 5 May 2026 00:25:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rWAgm8yZqkTEWO3E+Iv4QtTY54HVAbGewYLkSKrtuKw=; b=JcLh5r+NdnvDXCPH SiN8bTU7T2LYWQr3hx1QzJnaS3z5Sdwb8B+XSb0fjl/J8d9ptAouwR9lBJp6e9C8 Vhc7IGi/89P+wfGWADGvSvVAUu17Q3PyVmIf5CBtLNh4SF/tRC5eVYDcljP/5v2A L3WPQudZERv6PSruEpBQ/y8SuzyG5u5jj60ShrTOuY9fiSedc6w8lEWWCpXyGMaV vYDCG53sZ8fQzNJ7YxAfaS9qbc5pjbSvtmIk0iAKcjgUbo0ObdEekw9pq3hM/Kj7 akRnUcE6AArhWtGsTa7x/Slbpz1y/HezRXNADmQXDWvalNUTzaj/jkfwJZds1qRq 7+HpZw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxw5dt15f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:31 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50fb007bc36so119144911cf.3 for ; Mon, 04 May 2026 17:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940731; x=1778545531; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rWAgm8yZqkTEWO3E+Iv4QtTY54HVAbGewYLkSKrtuKw=; b=IOgn8OD5+vdGjV6GS2rrJcSke3Ry1176rZc65BY1+UgaZeG5PfboaI0Ddif5lPr4Az yUPKixpLywqehWHa0+bIJmZMKzstCPThvACACr+da0WqmpI5eAL2JoNVYPFM3xXQPPUh casCMjXbf2fJ6y8qs7y0BRfJ/WDg/wAoGIxh6avoDclmvZBRz7D9Myc3UwfdSkL5RF7L S972X23RhqFXtTTwIHuQeJfq4iLT7nmjYtW2z1tZegZFIv8AtV7yf+jyaBIUiyENhDzi I3uAUEYcSzlPZhzpKGx7kxzZlkNKTCVXP7bG43/74yz2+e9cCvpWkCO7Zdbbf5IjYQ48 vUPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940731; x=1778545531; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rWAgm8yZqkTEWO3E+Iv4QtTY54HVAbGewYLkSKrtuKw=; b=qm9m5Rrj37jfbUkx5MkLRURJhqpPvVt/gchx5tWIkSXUlzYW8dPP7P5P7+CiZ6P0Mg qxbxz7OZ4Cc4LV47PIZU5504dHvbRwyRtt2zS1Wid/mP/yXmI48KEpBF90s+hb4+cqjO ZdiI/6V8rnCcV+F4GaMI+9yhUJzKQHw4BeN5aieqw6XX05UFJkQLFhQ5MQfnn6j07lX/ C16+PjglSNZ1w7lVP72o6Yn3ajivTiSRRDkzTNOyfnSlMNz1JGxIQLRjCnedXuBmtjXt s7JCOIl+k8BIm3uRBmO8QhdSIucb5ifAgPavwvZAjKC21LvKnOfdyDUacOE+tlDQuq5z Y3mg== X-Forwarded-Encrypted: i=1; AFNElJ9MRykJAmbU73snE+GTdw9yDJh3XZHbhxyRHVnjY4Ef0Lhd+pJTCgbnq6QjXqpGWvqPJDbI91bLR/m1/zg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9Xp6DejyY1nNEk21YuN8+xXjzHMXDvfLv8YoqITD2BY849NUI OmUocEMqNrj9JVv/YgBBvmeINrdw47e7hpLTRf3Icv4bK0wTwoDj9cUm/UrAa1OfHSBe6efsOb6 vG+UaXf32S2Hcf0pa/wFPuNxfW7L07k47QRIpgsyuaOzdgMvfwYqYTekZw1sVTAOuH9k= X-Gm-Gg: AeBDiet0PTi1ef7nv9dHi3+iNeDct8ornbi/Uv9un3rK4CvbkPLjfshG28l6Lq7Bnpx P2Bls7sCuPd2E0jGRQdUvMsV4O7Q4hzFWmAWZtP72SmPQW/O/PcHOWeEP0JQf1OgbGVlZpuGnz1 fr94Rk/4Pjaj4zsNNrx8GkaqnBAFPophWBHJ6+9i5Dgf3NgfrBSmARITQTtBEcj0fhNIPZ4eySB GF41511eoKFJmQXCiNIp0M0755M1op+Yd/4P3nAYHxNuJWVSvJ+YOhmnKyqBCaGwtvyM3Njocgv DXB75A1KgYaIfIeqh48uSGryP5yTjKZWDknDcg8k8qx4alkSHD90d/2b8DvSFaqaiAYoSwjYkfO finSGKHLOoPbwXkeyhVBG/3sCMn/47Da+cjkJe0tkzBr2uATkdMNXzuHRCQq3SM8idJvX2nIHP9 q/2xsmL2rFzNnkvWLs4PqOm0/NrNj87RWHcJuiVAKmCdfPeg== X-Received: by 2002:a05:622a:90d:b0:50d:91e3:b668 with SMTP id d75a77b69052e-5104be76597mr167209221cf.20.1777940730801; Mon, 04 May 2026 17:25:30 -0700 (PDT) X-Received: by 2002:a05:622a:90d:b0:50d:91e3:b668 with SMTP id d75a77b69052e-5104be76597mr167208721cf.20.1777940730379; Mon, 04 May 2026 17:25:30 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:27 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:25:01 +0300 Subject: [PATCH v5 4/8] drm/mali: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260505-wb-drop-encoder-v5-4-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2873; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=FuBHZIwie1er5ktaJK0YV3oa/OgU1IZweJZeXfhYARA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp+TjcU1af0jhKXjV6ovGMeL570EFt5o7s8n1nn fsAtjt+HqWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafk43AAKCRCLPIo+Aiko 1U8pB/422R8VMg8H+IB6Dm5C7Nrxv1ibTNuhkwFXdQ7AaJY61xdh0vXl6otVYKN+1y0dwFJmSxW 3JKx++z5bAUk51vcm6jV3j/y8CHLhWXNVds+KLFlMo5N0VBbdGeLV4eWQdIP/NUpLTMBjSQDEp5 AYF1h8DxpdRxGVF7t3yZKqSbGHFMUKtjFJ6YKX5VY1K/0HJzKm2ZYCB0SIxKAem3ztMYcW+rFay 4F5x2Xvmt6HGtMBSA5Xwb31d/kzJNYih3pg1QGhM5mmXUt+lzRF7UIAz/Yc/XGGklPUKnxBmQzL cqMryMtUBc/TY7M6wUO1QpRFGIa0wJ+v+nQ+Dxr+y9LreE10 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMSBTYWx0ZWRfX+DsEXImKQyfO AX57PXZd9iRbOouC1RAsBMKWVoe7SfmfyvsQe1v+mwenoINsR7W+dkH7Kgjj1le9MlVwT6AUeN+ lMWwptJ3PgmBtqXtlbeKoMPodOtJrW5mtXqFK0x441BCyCtbvN/jo0WGdD1oW2UOB7YD6tilUiT rwY4xfnGAtmEeKG3mkoom+XybEoPW3K2emqDF+3Htm1hSJ7pnN3P80h7kA6UTcW6BronD6uUhGo BNwlXIyi24GEnWqMyHreHYDnhmyeW+FzlKvRQnxnesGvI8gvVwkpXAQ3vszxKkvXCV0wBS8pyP7 d9DWms1uF3fnrWDhdjVh74/8B10W2vJWjRfW0NTfPV+bht0T0q4Iw2JBi06Oj0H1G0k1Mto5W72 4+eFbRfVakQ6mSDGgv+2Ay/lpPEjZLknEUH8uZgCgB5cSV4cSWSAdIoecFrXzd3ooK/IXjElgb2 jNKGQBUG9iQrI3Tdfjg== X-Proofpoint-GUID: cjvhp_S_GN-y7KDXmNP7W3hErgmPhjhq X-Proofpoint-ORIG-GUID: cjvhp_S_GN-y7KDXmNP7W3hErgmPhjhq X-Authority-Analysis: v=2.4 cv=HpJG3UTS c=1 sm=1 tr=0 ts=69f938fb cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=rEXDA0v2x0ZtafRnR6sA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050001 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/arm/malidp_mw.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c index fad343842038..6e0c78e998aa 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -84,11 +84,6 @@ malidp_mw_connector_detect(struct drm_connector *connector, bool force) return connector_status_connected; } -static void malidp_mw_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); -} - static struct drm_connector_state * malidp_mw_connector_duplicate_state(struct drm_connector *connector) { @@ -114,7 +109,6 @@ static const struct drm_connector_funcs malidp_mw_connector_funcs = { .reset = malidp_mw_connector_reset, .detect = malidp_mw_connector_detect, .fill_modes = drm_helper_probe_single_connector_modes, - .destroy = malidp_mw_connector_destroy, .atomic_duplicate_state = malidp_mw_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, }; @@ -211,6 +205,7 @@ static u32 *get_writeback_formats(struct malidp_drm *malidp, int *n_formats) int malidp_mw_connector_init(struct drm_device *drm) { struct malidp_drm *malidp = drm_to_malidp(drm); + struct drm_encoder *encoder; u32 *formats; int ret, n_formats; @@ -224,11 +219,19 @@ int malidp_mw_connector_init(struct drm_device *drm) if (!formats) return -ENOMEM; - ret = drm_writeback_connector_init(drm, &malidp->mw_connector, - &malidp_mw_connector_funcs, - &malidp_mw_encoder_helper_funcs, - formats, n_formats, - 1 << drm_crtc_index(&malidp->crtc)); + encoder = drmm_plain_encoder_alloc(drm, NULL, DRM_MODE_ENCODER_VIRTUAL, + NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &malidp_mw_encoder_helper_funcs); + + encoder->possible_crtcs = drm_crtc_mask(&malidp->crtc); + + ret = drmm_writeback_connector_init(drm, &malidp->mw_connector, + &malidp_mw_connector_funcs, + encoder, + formats, n_formats); kfree(formats); if (ret) return ret; -- 2.47.3