From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6536D22A4E1 for ; Tue, 5 May 2026 00:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940740; cv=none; b=ToYYR9GKef6Sgi1RLxmsn6pZ5TMD4ZPes13AHGIo238z+AXQfEWd4BpwGhuZrpTyRPGQ0qBS+CYI+TYp09/AyxTrxz87NDgBhNUncQxb8mcZeBx8+MDMW7ZDDAKt6rumfslKZpx/vw8lag1ZLhFkFApXQkLU7evPY9jA43yGUk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940740; c=relaxed/simple; bh=4Vucpdbps+yQVez32oDVtzt/iw6YyMI2r6E/Wi913Hw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JKqXmH796ap5aMZXXMmYXeGfcWewow7uz8+9lleiVZzvSWIND7r2L7yejS+PKrGzvYeF03a3To+yvoboD/8kWFK5yJL8FMiWpTHrRRwGp5dZ5RuawqLRvjHz4y+KPGfPOWQ2PVTRMNcpnYch0+QL5uXFerjdspdhInSfc7LrvYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Csm5N2rF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=huU4+BGq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Csm5N2rF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="huU4+BGq" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644Lk0tC1960499 for ; Tue, 5 May 2026 00:25:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=Csm5N2rF2fRYIJOK b4r0Jj8d7YHdLch1vLDOsvt3jArD3z1S7R0u5KKFNK9Ny+pA56wNZL3wBuuTte4i WWDtzdH+xFsFmeXQI2IEO0vq0UmlmRN7tcnCq2f0xQ0HwqZfWJepRztKZLXK5ZP+ 1f6WnTShDociysdhStNfbv2vDV2LgQAiQAdCt1PVsjW4M79C/KWjfL8I+a8J8Qn3 uApVDlEtQ85XvIaeC9e3+RIVUzjy4S8qsdceUgbrQpgrSilaj6HUUBmv+xqAPwRQ OY7GGI0CKpC0ICYnqRIWTHn4jUt08IE8ALGTVF9kKF2LcYRofgeYRSI/qkIuCL9v h+Ikkg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxw5dt161-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:37 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50d6bf346adso79692481cf.1 for ; Mon, 04 May 2026 17:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940736; x=1778545536; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=huU4+BGqRNgmYRTxql/J1og+JlEqBnYz32nyDjfsp/RD3+MLNODxFNy653/hRafqyZ qdlv2HXRHrGDa4Y83vzja9rEg6nTFuob593R5FnKUf4sw0xnRrh0VUnlAmmLZ1SeOuQ/ z8WW43ZweVkW6Eo+MrIdDqow+0G1mVMnu4tf9Ecws2Inq37JlB0lZSwuSgB6GReLsjQh JtEsJrp7LxZK725kzjQOojTy8vrecRYAAMhHRRG8XsFkoEjp6ZhO9enXPY4F9MJd3EG2 aY10VLG02/3BV7KQDZe3gTB/BB5a8S7hbVUodFKb9rm4EFdAPKNus/VKPL2Bea6djkoZ Fgpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940736; x=1778545536; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=EPbVceknKmUSjqJqYqRFJD6GAe5SOp6W9YkQ9ZaIzubCfCbgKh2q4QZ4s9EbOeoEkB 7FTcmpUhvSiiCAjIDyxJP4EkpVvXOTZr5ElablprKn/zFZLuYrHyVrSQgioxgKM3mTtt l14v3S0gOqd0hHWQ8IkMzzs/1Be4JIxZlEZybhyveyZpcip98Bf6A71tq0FoQvetrGte qWwoLEmgxztn2W1no9IP5NqpUKGGas1ZrNMddjdJf1RC0BjRITuL0RX5ongB2sWBcq3R UmQfqzn/4oZUPGMUw/gzQd3aFuWSt38qT25AkisTyhX53EJK/mdHDeFvdxAyLnNs/lJX 6+0A== X-Forwarded-Encrypted: i=1; AFNElJ/s69XOjgsfx4onnc7GmSUYKlCVywAwAUYyBpEURFIbsbWrHVYMTedUy0JZywvHAiYBBOgPMu+kc4hgMPk=@vger.kernel.org X-Gm-Message-State: AOJu0YwNdnHxbstAK24dfTVlpM3Du7GQ6Vms0h672EDFCAbQCdwzIEzm iFxuDRVDK9ceEItkBWO1u+iqTwsZB9K3+XN4l0RGWSWnrUwtPHOXisyhJU5DVUiAfGh41lHNx6L iFwlx7fT3/U9gh0JLmVk3ScLK6b1u6RGhCeuBby76tp4913j6cxEUyBOEVQ0GMd2aMyg= X-Gm-Gg: AeBDievht8UWh9/T9vX3achgOQSBsUUcsZU/EFJGlcYEIOhmXRhHjywSaoeUhBKoLMj fH3bTm0j9wcCPxF7R8nnJFxUaTIFPZVBZuvHZnz264r+bJlp/iMwL+SDxEg/eF5UW4wXFpZ3geP M2RzWx16TJwiaSGpT/mfcZXt4MF58IMbNTRkADFZVrtCDsYlnbeUZREi3JOLq/aEYGCUylGWcPF /p6VOT7S8if8rUd0iz+QgKWa3zlDIAMolu+NCdaJl4NCl6CE4FLSEKhcYxXbL+maUtZsUtfEsSd s3qlig85L5fJBN5qP3BMoFMut7XlhSYcTh+PHtO5SSYA3UdY2nRj48krUFv77zAom1brJCmnRSH DRJRTnhLvvIwvtCDWHsfjQ8mZpDYKASPzEeNuI+qTN7TKQqI9gtTMmCZYASIDpIr1LqLkhfo9Mx 07LksDHI3By7mNEVuH8w8DByaJjCY+vqgCiy2ME3d6FQZaFA== X-Received: by 2002:a05:622a:4d49:b0:50e:a1ab:114c with SMTP id d75a77b69052e-5104bef1a95mr179779401cf.32.1777940736563; Mon, 04 May 2026 17:25:36 -0700 (PDT) X-Received: by 2002:a05:622a:4d49:b0:50e:a1ab:114c with SMTP id d75a77b69052e-5104bef1a95mr179778871cf.32.1777940736112; Mon, 04 May 2026 17:25:36 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:32 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:25:02 +0300 Subject: [PATCH v5 5/8] drm: renesas: rcar-du: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260505-wb-drop-encoder-v5-5-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2589; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=4Vucpdbps+yQVez32oDVtzt/iw6YyMI2r6E/Wi913Hw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp+TjcsYWHgFL7YdrLbWVw7Uldjtnf9eJreeqel uySv3eVNaGJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafk43AAKCRCLPIo+Aiko 1eTACACX9CkVnJY51k1n4kpTPLzSZQIBw8n72ppEnAr7Nx03zRbl3kWkZ2SLmNSxZmBWptrTJkk 2V34Y+p2v9crcEfzAHIMNeS8VirAvNf7W8vbsCnwcpwVM/tgWGvJ+2h5OUEU+aQf051uVIH3RwU Qo0u5M/OmEdDCf6HlPLdzCiX5rVxYfDY2itb9vjZyedZxwEPVVgSi9vdLWIYfQqCDrd6IMT4rwx +RoeL8xzHgeqYVMa4DoG+g09ieOLTEZS1A5GIPMSdTmPCbTOWLbecZb6QcJEtEM9EABMaVfMeRL 2xM6UMzh2Flot0Vun+McCHFK3C3Ydm1IoDmqYPZWr6V08vSn X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMiBTYWx0ZWRfX+F423iDawxTK GTGHacwN2UFc4lDZ7x018HjElzV4ZnLHNlf4fCew/KvgtqfK6feRKJr/oFdfY/9iq/aJ7NqMbeJ 8KBVsQmh034Wf6Sf6aABmmYqF2P8MsRsDk0pgC3IfnYpj5rhtduVakrSw36afUDN/g7lWxeJmc6 voNkm4zxWPcrnYBfIyXKe/aOfXo8FXC8WphJm1hiqpmxaQvX46P43P2CjUMHwIayMcSITDt6R0x Hxp3LH5WXJTecMXSJVF/gXSz2HfUNgEml8k1rRyo9nhhXtGWwz3y13ayeWY23Zwn2PaPq3LnCSh jLgRAyUNBZQ6xO+iXhW+mt3pAfQFIKNY+AC09IipuTZunTzbdP+5DutuMy+Jt9rprXkb/9ndnmp dqHiwSyNQqu54KNjyZqx652o3P88g6iK+eN/Ye1jwSdpKEZuIdcNpu3OoSax2GI15E2oKQlDnQm 731rT/0CpU/Ct80mmWg== X-Proofpoint-GUID: DYvS-R56wMArscaEnxfPeyGDMxPiQKGp X-Proofpoint-ORIG-GUID: DYvS-R56wMArscaEnxfPeyGDMxPiQKGp X-Authority-Analysis: v=2.4 cv=HpJG3UTS c=1 sm=1 tr=0 ts=69f93901 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=rEXDA0v2x0ZtafRnR6sA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050002 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c index e5e6e6a156aa..ecfd4fc1f210 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c @@ -134,7 +134,6 @@ static void rcar_du_wb_conn_reset(struct drm_connector *connector) static const struct drm_connector_funcs rcar_du_wb_conn_funcs = { .reset = rcar_du_wb_conn_reset, .fill_modes = drm_helper_probe_single_connector_modes, - .destroy = drm_connector_cleanup, .atomic_duplicate_state = rcar_du_wb_conn_duplicate_state, .atomic_destroy_state = rcar_du_wb_conn_destroy_state, }; @@ -201,16 +200,25 @@ int rcar_du_writeback_init(struct rcar_du_device *rcdu, struct rcar_du_crtc *rcrtc) { struct drm_writeback_connector *wb_conn = &rcrtc->writeback; + struct drm_encoder *encoder; + + encoder = drmm_plain_encoder_alloc(&rcdu->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &rcar_du_wb_enc_helper_funcs); + + encoder->possible_crtcs = drm_crtc_mask(&rcrtc->crtc); drm_connector_helper_add(&wb_conn->base, &rcar_du_wb_conn_helper_funcs); - return drm_writeback_connector_init(&rcdu->ddev, wb_conn, - &rcar_du_wb_conn_funcs, - &rcar_du_wb_enc_helper_funcs, - writeback_formats, - ARRAY_SIZE(writeback_formats), - 1 << drm_crtc_index(&rcrtc->crtc)); + return drmm_writeback_connector_init(&rcdu->ddev, wb_conn, + &rcar_du_wb_conn_funcs, + encoder, + writeback_formats, + ARRAY_SIZE(writeback_formats)); } void rcar_du_writeback_setup(struct rcar_du_crtc *rcrtc, -- 2.47.3