From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC5492773D3 for ; Tue, 5 May 2026 00:25:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940745; cv=none; b=upJ11kvi9uGcPcjZ5ngXwBRfHedZ3nJgMkdwpBk603J9cj0sRJNOZkvLF/DpdnbslrxtL2/kyFYwWokS9FaZdwR7qYREFXq5tYUU/4ZAoT4OfQCXpltAHon3ywMSPDhvgYJz3G/eYV4g4rpuZzUbXLanTVfqLWKK1UecGEZ2IFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940745; c=relaxed/simple; bh=behk6Tmd7pmo6mRIbuSh89UzpPSTMpSIp59mKcXVLLY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k9ZML0k4l4y/DJyGyurF/lWzVtnKHKwIDmRVES0ijzMLf33qMoSeal3Li2gFG6PQWGX5oQWTJAdvqVjA3VqxHXFK2n927H7yBmZ4z0dchjas8SH6PnlDtf3Wtx70XZtUyKM2d9o289dyox6eA98WPUWOAB9Iuix49rMNWroCDOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E+r1w5Fc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fH8WhMTz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E+r1w5Fc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fH8WhMTz" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644Kole83468117 for ; Tue, 5 May 2026 00:25:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IGPbsFRj9AcR1JhiLP6QveYjBGQn12/jz6nJ82TmXuY=; b=E+r1w5Fc2T0hs60s cNktpi4aZrq20ghx+ylb7uEN8/txOPRbTfbZeykzOQepXSe1dnnn71jCxqXKncyM bGyni6FW2vBRohz4rgQw4qIJOFm3F4KuyZ3KggFuWWefz6xIpTuqJcc3fZUpDLYf NJCQEXtW84cw1b3BwbseCxyIz8iU/DG0+oNjflW8+TFFZ0Cn8aesJvXR8nARQYHW Lo1YhQH3OllZipvbbz6vdQWGxt6KUtLmNDJS2A1rLpP1gYU4hdF4rZdLUsa3dvQj b8opRDVa5Uc6RP4Ftv3sEdktaPp8GTnywYb6qBl/8CnzJ17YaGA9bd9b2wu6wbHS YV3ZzA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxvtjt4nm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:44 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50f13da9684so58873821cf.3 for ; Mon, 04 May 2026 17:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940742; x=1778545542; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IGPbsFRj9AcR1JhiLP6QveYjBGQn12/jz6nJ82TmXuY=; b=fH8WhMTz3Hz1ILjDHEUPzttu2C5OYmCN86JSlT53Nie1iem23je9n28fUvw/JXVKcL 3s9QqDytHGYbbDuYCtdJTo7RN0cpr095f3hxzJLb+gMRi64/dV3APQTe00W0IoImQw8S letpXp3+1KPqEfbyKF8eobYF+lzjTItsnWeN/ychqq7JJ8M5goqssSligCArA/+Dj8Vz IomLBjJqEudVeLw2SNHh5Xz5Odgy2Vuhm0pu3fx20+CkygbpDno7IEiE0z09DRrNmstA TupkCL78GRBzxUKSZlHdf4Je4GZ+j5It5miCwgpXgClGCx2Qpb4LeV8yhzOYj3cZAXcD OKow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940742; x=1778545542; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IGPbsFRj9AcR1JhiLP6QveYjBGQn12/jz6nJ82TmXuY=; b=HyfT4gCW0MhAL5G2xruxqH8BEEmcWqCZXlXVaM7Uw+euKVG+zFJFcTVrOtVMLkD2h+ 5yFXiha+RqbxnBEw80uqjs8KFakEmLsd8lvXhdNMwrwQnGUy25g0cJteuAL4coMN0N+8 058rBX7gD9fVO5lVSfxA+loQumOR5/DbjvLwbdtJK/iI5I1yj5AGKfYI0gAQ5oujhEqA 1NKRMhcDfEPck3biTYi3ZEFvegCY5zEVgx/Mabueg9HrTlvMN+neZctQy95KFB/8IZXH kfKGCq7azDYmPzGnwCtlaK2guYq7MKzG5M4xD5d97x7rdHyL826oSb3V7figHBsF89vs n1ZQ== X-Forwarded-Encrypted: i=1; AFNElJ9A9TS1IwVURiCM9f8rTNNUH+UbA4IPebGekfpa95kximD7b9CZYwxuVNqZpkUm2pS9IOXzLUGhFpnrU40=@vger.kernel.org X-Gm-Message-State: AOJu0YzSJUG0jUA4TGYXLXAvoGAdcMB/6xmViSJ6MFP+sHf4pu/iqEx1 qKKllTwPaf5UanRhbEt5f0xraFf67KXsaHtl04X7yMLM2C3s2vRn/dlez5LWDPPQvDlgmw9EMFE vWUP/EQTgJ4wWPW3eN2BDGek8s7MGpUA2DILXRIg3n1jtdVR12OpDVwJgTHeKXvk+33Q= X-Gm-Gg: AeBDietRGeT+kryBWKdR+F2xGtSFCOz7HcYblMuWJTvncz4oeDJ8A4HiS8rczeAfjBo cAmGYPAbHuUyipykZXRMEp5PU0DuC+bVe7HomDoPCO2AcCmj/F7A3qWvmy5bYAuXz24XblZ8oCn K6g1UcxkbEGSsxNvSwBXW9zde/rJPgHT4XZ1SX904hqpedP3yydpNLHdquL/anvQbGPn6kd1V82 zVZgFs1lbUGBVV1UK2t4wOc18CkNVEtc7WPWpIjH+Jiz5PxeKh3/1BBmALRvNnUjJ3u0le+lvel 4NWcQ5KmR2S2sxNODS3POAMIODbHTr78a0ywHKQs1jfG42RjgaNvBGOXXdNMnvSeD4InOuy306l 4gqZyWLhTAqQ4/P9IW/WTCiWXmfUbE+OjRLuslWUmE1zBWxlYz453TexmHaJJiD83swt4n6Q8i0 WcR2e6xNEcEIeq5ioC5f4yzF0JxkSoBYc6ihMaDZouyrBAPA== X-Received: by 2002:a05:622a:4cc7:b0:50d:a56f:6085 with SMTP id d75a77b69052e-5104c000210mr174309711cf.43.1777940742368; Mon, 04 May 2026 17:25:42 -0700 (PDT) X-Received: by 2002:a05:622a:4cc7:b0:50d:a56f:6085 with SMTP id d75a77b69052e-5104c000210mr174309381cf.43.1777940741886; Mon, 04 May 2026 17:25:41 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:38 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:25:03 +0300 Subject: [PATCH v5 6/8] drm/vc4: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260505-wb-drop-encoder-v5-6-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1991; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=behk6Tmd7pmo6mRIbuSh89UzpPSTMpSIp59mKcXVLLY=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+ZPiztPJkmE97W+e+LKVL3eX/tHS8K9KXwCspM/Py2PD 3xwcff0TkZjFgZGLgZZMUUWn4KWqTGbksM+7JhaDzOIlQlkCgMXpwBMREOH/Teb8FaWgNg3Tkw7 RfgfGi1h272T4ff3+AoF322LXy7SEe7+Xr3paDRbyT32HIuj93W+Fp7ye6qwbFevRHjRkwM1mx+ sTY7iuXvpo0TSPdUpv+bUhn4WEVprKuEZoc6YUrCCKc6mn+G82yr39Yb7ipJeNSr8tD6xyVVxgl 7V1w3e6amXpe+84V162jB+8wvHSy17lHl4Lmz28ZUxt5uV5ykYfXadk+E9LWctrYoDX86+zY6Sr fm3/0SVX3wYs6+HgErvpvrcQK0t91QDn3Vc8z73XU3Hr2VXo2T7BR31zBvtOotmMct1OF233Npz besv8adfMtoT1KboFsTGZFpLl1p8Px+x/On9KGe/r+0vAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: 1CO6pE7MI79cqrY5fhVEKLgHk0eLtDkR X-Authority-Analysis: v=2.4 cv=KuN9H2WN c=1 sm=1 tr=0 ts=69f93908 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=YDDQE0DzCl7hcZedIR8A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMiBTYWx0ZWRfX58UNBgqGQYxc xTkuwPtu13CwGBnVUPiSSFURBvsvu/KweypyRcunxsB7sE4/VPqYgo2Gd6nfxV2GgVBfcB9jlqS Aigj15G3MkC8TrNDRohm+sR8HIVzeRfZ8cNqD51teqDaNjQTB1d72O//WOGz5Pd8p2W9G1oDHHl Cx11gBXzGYq/T/tocsM132ugxlKsJpFrbAGeElDhF6q2nHgK2qUq4GL+1OMKSRyFIn44GJxqNwk F44WMnKtOButoNtktQhBdpiguID+npYQCRUe0XBZw5q+w2hFd4Ak2KGaWPmmWBi17wdqZB3N8hP RBe/e4s87ZPq8GCAZ275wBJ7fPnvNTbph0VSakY3sKU4SFRjoMWMSECmkgLdkJVk6WYH8Nea0mc Y10l2wCjHrMohqfHQy3P5hF5uvN2A5ccAhcYIYAwIFohcwSh3ffsDqkkPuxq1Wa+yfPrHGtkebS 37AnKfi571tq2Cf3AYg== X-Proofpoint-ORIG-GUID: 1CO6pE7MI79cqrY5fhVEKLgHk0eLtDkR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 adultscore=0 impostorscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050002 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/vc4/vc4_txp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index 9082902100e4..befdb094c173 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -378,7 +378,6 @@ vc4_txp_connector_detect(struct drm_connector *connector, bool force) static const struct drm_connector_funcs vc4_txp_connector_funcs = { .detect = vc4_txp_connector_detect, .fill_modes = drm_helper_probe_single_connector_modes, - .destroy = drm_connector_cleanup, .reset = drm_atomic_helper_connector_reset, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, @@ -602,10 +601,10 @@ static int vc4_txp_bind(struct device *dev, struct device *master, void *data) drm_connector_helper_add(&txp->connector.base, &vc4_txp_connector_helper_funcs); - ret = drm_writeback_connector_init_with_encoder(drm, &txp->connector, - encoder, - &vc4_txp_connector_funcs, - drm_fmts, ARRAY_SIZE(drm_fmts)); + ret = drmm_writeback_connector_init(drm, &txp->connector, + &vc4_txp_connector_funcs, + encoder, + drm_fmts, ARRAY_SIZE(drm_fmts)); if (ret) return ret; -- 2.47.3