From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D21B3603D9 for ; Tue, 5 May 2026 11:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777980609; cv=none; b=tgb7KLk5eB5AAMunoWnQ8zLIcM9CgaCYkb/Dg0xrLOleUxV0TGhE9hCFO2wxc2kEUa85XuTPYXdeZuvr6yka0v8QTBsyoyO4rS37YyvR8IMCrGHRhsDc9IOjndcKOicwNFHBHASkZtWPDMxAjck+SsJixjs6RJ+/IuF8oZ1AYgA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777980609; c=relaxed/simple; bh=0xmAcfL0WM9BiF0IZwBIKZxccwrTn5jd95NyvFCKKZs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q6IfQeJ3cEQ//W6V7sF5SmZ3Td262pQ4dgXdgPiK/2h/eP9odZFXrDlvcSUz+OxSEGzcKrKzNMXoGF5U7RFVJMRA5sC3POzMyM0aOSIAcBUTn2sekotWLyiV446JRkib2S6o6pqXFU7mJ/NaUfZ5FtIwQZqSxwXe1thIckub6Lw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WyQUh+o3; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WyQUh+o3" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48910865133so6236645e9.2 for ; Tue, 05 May 2026 04:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777980605; x=1778585405; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4BjQdln3IkqcS/3mLg4+1yv+wub9lBUw+7ON58e1PtQ=; b=WyQUh+o3zTfFGQWv5md+2HFqSNJzIAqWfEQVeigL3zaTiFaUV5dnHwMiB2LNE+7Jqn TiMwVysJ3jFhMeZj2+z92Uoit3ebpnS/Oqtp4+0astDokQCmF8RBu6op5ZPSbU9IJ0pm Ni5Gmjb904hp3n+SASD4Hm0l1Tb1m/jwsh/hY8pnvx4x6W8ouets1nY+PKIdasJvfd2Y qXgjm9SbXXB65FfgNzYzbsUOfRoX1OZLeoGVdV7tywuDjEMEK+OcpAr+hj69YGDlwmp+ vD6kPzgi/mT4XJcZhc4gCPTPHAJtPfzfDXrO7i4asEkjt/iVL4bfeLFX06P1KSeysM9s V4yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777980605; x=1778585405; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4BjQdln3IkqcS/3mLg4+1yv+wub9lBUw+7ON58e1PtQ=; b=Xnka4OdPkied74/ZIIm7+t5264SSmxu5omYoO4jRkqfovwOcl+DHBSMl0g4EQiQy1Y /KlS37PfgTIfaxJQqqWdx52cq9s+kzUs/bSFln+sxkWsLzecqezRYmL9MMN92Panf2Ks 6TOmCXhlOQj9ahzrRTbDNGqzlGWT3PgQa9GTI3PgCoMy/hT4dqxs3ccIn6mSV/tYS9Ok SKY9rWpVmW2HbHbyIZBHzJPaYs9kwGbaqZPqXUlBA+G5oQYL70m6u7kwg6FeygqWvq7k W3v/f6GTehrsFKarQX1R6Qj6XjRVtvYSIRvDt5IMJYV18IPQ95NoxXXEkO2RLDy5Onvx 0LwQ== X-Forwarded-Encrypted: i=1; AFNElJ8HbcHX30w0ZfaVZlHmJbxjovAQ6tfwVNoGRO2gUmvjMz9dDmhweg/yTu2IBllfovC8ZawppwApR80ag7Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzhFALSJL177jvwaa3gT7pKfpQtip6mBR2KHA17u3WtGzRpAqzv aNZpnj0bZxx7x7oRcfcuQUaoU4vI6jGqNYhdURPC0yZDxODDE5dRC640 X-Gm-Gg: AeBDietrXbs52vFYfiaZDPTiW6iI4TytcuQbkKWj08Bn2B9L8v8T7Dx3C+GXvWZsv8X Vcv0J95j04/KixXAWMoYf+Gx89rzZnEm5aQDtQq9Y7k9pXCvmRiVUxJ2Eoo3ZNJYdn5M2SqKNMc Mjby22zRUhFqKtiEvBxuAuVvVGg4ZNLKnYm+ZmJqFoj9NO3osV8VQ8h4IdiNlnzAJeU1PfmXWGS HLIDkIue09zUZCgsEp6oIC/JW0yCtDTZgZRQY9Siq0ZMyOueY+BHTWlDoqAacEDNGdV45LRQK/J wp5u03rqVvQfuVGG9nIGGsdgd7vnB2G/7oro8/v4YopUOfruOQzvjUCEcNKfHSvogH6NHt98uYB cZ93nOJeySHaps47+iuwrju1LFaGDktccfHmnUwNSaDtsL6+340NzFZh6njpnI4t2YB9aTjXZ0n +v8QyAay+PhF+zJa+GmLbDdwROEQ== X-Received: by 2002:a05:600c:1e8b:b0:48a:6848:527 with SMTP id 5b1f17b1804b1-48a9866dcbcmr109557665e9.7.1777980604557; Tue, 05 May 2026 04:30:04 -0700 (PDT) Received: from skbuf ([2a02:2f04:d403:cf00:9b58:9830:baf1:5f76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eb3427fsm566232505e9.0.2026.05.05.04.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 04:30:03 -0700 (PDT) Date: Tue, 5 May 2026 14:30:01 +0300 From: Vladimir Oltean To: Rustam Adilov Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanley Chang , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zavertkin Subject: Re: [PATCH v5 5/6] phy: realtek: usb2: add support for RTL9607C USB2 PHY Message-ID: <20260505113001.idgj7ssikjgcypa2@skbuf> References: <20260420191941.81834-1-adilov@disroot.org> <20260420191941.81834-6-adilov@disroot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260420191941.81834-6-adilov@disroot.org> On Tue, Apr 21, 2026 at 12:19:40AM +0500, Rustam Adilov wrote: > Add support for the usb2 phy of RTL9607C series based SoCs. > Add the macros and phy config struct for rtl9607. > > RTL9607C requires to clear a "force host disconnect" bit in the > specific register (which is at an offset from reg_wrap_vstatus) > before proceeding with phy parameter writes. Since it belongs into > the vstatus register region, it doesn't need bytes swapping. > > Add the bool variable to the driver data struct and hide this whole > procedure under the if statement that checks this new variable. > > Add the appropriate little endian read and write functions for rtl9607 > and assign them to its phy config struct. > > As mentioned earlier, the readl/writel are native endian on MIPS arch > if SWAP_IO_SPACE is not enabled. Since enabling SWAP_IO_SPACE results > in boot hang on RTL9607C machine, wrapping le32 around readl/writel > should be a good compromise, but swab32 could be also work. > > Co-developed-by: Michael Zavertkin > Signed-off-by: Michael Zavertkin > Signed-off-by: Rustam Adilov > --- Have you considered ioread32() instead of wrapping le32 around readl()?