From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1AD6948AE20 for ; Tue, 5 May 2026 15:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777996677; cv=none; b=WJVtFokq0pWH0g2ASJ6xWJgUFQU2UDLGv20/TDictJUk5/CmC2vFRVHg+V6SDxjYHAubzL+/rZRQGWACX+wTpwJIc2eTuIHzg/ztJ+h9F0AU6wIJyr0ooAWwLJfPq7BzgdQZTlAEp0KbqllEqL2OaNVV+qCQb5aRoYa0AoQIINs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777996677; c=relaxed/simple; bh=3nA5fL+UTzjWp/OsVEAJB90IFKlLYYHAwmrk+vIu8WM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H3qk9ViHwsjhvP+/TjynQPConJoA1cBEzGas6vKt+L4+h7m6puDQXn3HRLgY1wC81WArU12vgJadZWyRzcWyAtYKA4x9R9/kOc2x6e5Bm1O/Do06pnj/NAft8ih0lZ5jhPLV4miF4KH+gf7AU4zGH9up8bOSs5ZqTkXL7Kg8eeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=LGL5RSLv; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="LGL5RSLv" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2F9903029; Tue, 5 May 2026 08:57:50 -0700 (PDT) Received: from e134344.cambridge.arm.com (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6098C3F836; Tue, 5 May 2026 08:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1777996675; bh=3nA5fL+UTzjWp/OsVEAJB90IFKlLYYHAwmrk+vIu8WM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LGL5RSLvZtn97Y6/a0epWnHnH3n0/j/PVOFhub25wrmC/P7AAUtiXkTU8olGjQNFR EAC58T3OmaiL1MdwWTuRgE892WSgsJrmTcvRfsQQPEzSQEBcBrBcaYgsZrF2gBlBQk ZswtZFwqVsIOf+qg9wUPmvKs59FsBifQmcXfd+IE= From: Ben Horgan To: linux-kernel@vger.kernel.org Cc: tony.luck@intel.com, reinette.chatre@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ben.horgan@arm.com, fenghuay@nvidia.com, tan.shaopeng@fujitsu.com Subject: [PATCH v6 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() Date: Tue, 5 May 2026 16:57:35 +0100 Message-ID: <20260505155741.3591201-2-ben.horgan@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260505155741.3591201-1-ben.horgan@arm.com> References: <20260505155741.3591201-1-ben.horgan@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error path in resctrl_mkdir_event_configs() is unnecessarily complicated. Simplify it to just return directly on error. Signed-off-by: Ben Horgan Reviewed-by: Reinette Chatre Changes since v5: Correct order of the tags --- fs/resctrl/rdtgroup.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c index 5dfdaa6f9d8f..fb6999178fe2 100644 --- a/fs/resctrl/rdtgroup.c +++ b/fs/resctrl/rdtgroup.c @@ -2333,20 +2333,19 @@ static int resctrl_mkdir_event_configs(struct rdt_resource *r, struct kernfs_nod kn_subdir2 = kernfs_create_dir(kn_subdir, mevt->name, kn_subdir->mode, mevt); if (IS_ERR(kn_subdir2)) { ret = PTR_ERR(kn_subdir2); - goto out; + return ret; } ret = rdtgroup_kn_set_ugid(kn_subdir2); if (ret) - goto out; + return ret; ret = rdtgroup_add_files(kn_subdir2, RFTYPE_ASSIGN_CONFIG); if (ret) - break; + return ret; } -out: - return ret; + return 0; } static int rdtgroup_mkdir_info_resdir(void *priv, char *name, -- 2.43.0