From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f226.google.com (mail-qk1-f226.google.com [209.85.222.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29CD93B7765 for ; Tue, 5 May 2026 18:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778005384; cv=none; b=XMQFYNaj9w42i064NLbnMPgAvhDCPT93mngiVJPp24TlSQbP5CSc+B6iZRjAWkfxxKkoUlhI75LbaqmHu0sucnyyhcs+09D6/QBWBUc2mBc7WZxVvPms2jqUX9deedF+Dd1eVqT8fuOj66uiHbsJ0FAFXVfp0N5w1AtDqKXFkyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778005384; c=relaxed/simple; bh=GgkkRdICe7DfLGShMiCKE1jBH4nLY83u4kIozlYXyIY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T6DQapErzyPi35oHiwaLJy4gDPwMllHiC/sTqE2wpeDmbPRPGxW5wjOLkId5GTJ9eWoW8FTTmfLI4lO5C8+mKn3lAkLu+SvpgqSklU8Eot5uE7n6h4FGS6K30JGi/P7ZvfDUxmhRi+encBIq5dheftl5ERnA1p/wZ4dLyxj8RuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=fOTiD8/g; arc=none smtp.client-ip=209.85.222.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="fOTiD8/g" Received: by mail-qk1-f226.google.com with SMTP id af79cd13be357-8eb4de77886so69677285a.1 for ; Tue, 05 May 2026 11:23:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778005382; x=1778610182; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0TctQ/QPTybZnX6Hj/EaRyQr5V49De/CNOWCLe2wy8Y=; b=YwaHUm9hdd8d8+7bzHtY9QtS0y0CR34ZkOghoCcZo0vjuXYzIGuKiyHAWiunfcmMWR tHyR1BIc9fIHDHG310ijUbH3RAucC9XKYnAbOwNXmsJiMYLA2RCDdpXQa3n//vRb4Obb 8tVucM5DWQwUPFs7SCJgwKv6Le0xPTI3gg0utPHhSmGpt0cqFXeWCNxENbHn46Le9s6I Xk3S8nk74BQ8LhpMi4FvwOoZELOdelpoZbkasoL0JGf7LFNM4Md9mwcqcj6cz3qhBR0q 8Pf07YgMPSd8KYenpEV0l5euksH5/jW/0N85KhpLJYywRkTLY5uaPbNW1AVhxrHZmOQo Io1A== X-Forwarded-Encrypted: i=1; AFNElJ+vOxZ0eMAiKIriCZd0DWeqljOdQDz6uTSwNB2slkyqntfLpu6QL3LFnUwMH5PQxw0I6fJT6tGL7IfMImk=@vger.kernel.org X-Gm-Message-State: AOJu0YzlYCvEpiOVxQ69Wkl9vxxTnjTe4teVkVkqyZlD++Gu8j3ydnrp DtwIKRdoBJQ4BIi++hhA9sMxfE8eWVikiSrGtCYHumHNSYqrSrn0lqO2+OPNy4sMOz4OwEKKlm3 ySD+M7Av2mzOllPtSaFIHaIq479OhCPJZOxSgAO9w6sKnoFPPJ1DK+lZm7ke9bxJmEAiROHrwee qSqJQvS9AOFXEJQo3fSTPMgM8sURA9VtB2mdjZY74vpxdANHM5Oj8myjEtKWjY/8cumk/ALEBW4 KWTJNDI/FK3kKBUkvZlGBQ= X-Gm-Gg: AeBDievPfz+2TdQXeKkxd9XgQ8Tj6WAJDg/0nChcA3Qy+340595HJIRXHWeDC1hXGJG XaEObe4WcmRdpWWqIQAql6+QKFwPoxuvdscK+YjbmJT5SCrIyN2azydmN+av6ZXhF8H/0mZTy6V Z3HfJjT/Gqs0leLlLXv14fnQpYY8PzFEGwXdR06wXZXcNvpqZfcBnGjDv+uo0ISYLpzYgT7li7f 6gq+cCMvW5FTRURBjZW+daqyR5hE8ewuAaSmc/c9G3M5nA1nLLtZQXhyv7AqBomdclbg6lbB1Ue pqT1aODsM0TFJi0X4KTcZSUnIZiGfwatogYYxrLC2pK1FgYC0Ha8cbbrhyC1N75TIv+y0f5leeJ f7deZ8XfPC2PGZo1SgeSzRtw+WesJxTQ9EeXoD+503on0HS0aQ6SezNfH3sns6j737a4Y7n1+GE pBkUJNp5PkYQElhN01 X-Received: by 2002:ac8:7d47:0:b0:509:e68:22cb with SMTP id d75a77b69052e-514628b1019mr148181cf.5.1778005381865; Tue, 05 May 2026 11:23:01 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com ([144.49.247.127]) by smtp-relay.gmail.com with ESMTPS id d75a77b69052e-51040868866sm8045341cf.6.2026.05.05.11.23.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 May 2026 11:23:01 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2f218ed8dc3so357651eec.0 for ; Tue, 05 May 2026 11:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1778005380; x=1778610180; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0TctQ/QPTybZnX6Hj/EaRyQr5V49De/CNOWCLe2wy8Y=; b=fOTiD8/gvF5VMRj3RaMOr3DSGhe+/YPS04HzkjdWckC0r4ooyvbURIIESLkKUinUKR CRplkPLEcfxFIClzK0KCCo78gOISbZ5IaK3VfmYTswYEvauEbJfhhmUO2KaVsmbh+S8V tIeIecMSasACPKMFtntha8o3p0Nh0CeCh9IbQ= X-Forwarded-Encrypted: i=1; AFNElJ+MDUkdq1Lg9VMYu0O7xA1MUvPYVHEkxMEgi4y6JXs+/TeqAXK5DbOBjoyRZBU3C3xFf90STb2WXOSR0RI=@vger.kernel.org X-Received: by 2002:a05:7022:68a6:b0:12b:f899:7178 with SMTP id a92af1059eb24-1318eb48053mr80662c88.7.1778005380617; Tue, 05 May 2026 11:23:00 -0700 (PDT) X-Received: by 2002:a05:7022:68a6:b0:12b:f899:7178 with SMTP id a92af1059eb24-1318eb48053mr80643c88.7.1778005379959; Tue, 05 May 2026 11:22:59 -0700 (PDT) Received: from photon-d7fac424c0d3 ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12df8424ef1sm27629462c88.9.2026.05.05.11.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 11:22:59 -0700 (PDT) From: Ankit Jain To: edumazet@google.com Cc: kuba@kernel.org, netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com, ncardwell@google.com, kuniyu@google.com, horms@kernel.org, shuah@kernel.org, quic_subashab@quicinc.com, quic_stranche@quicinc.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, karen.badiryan@broadcom.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com Subject: Re: [PATCH net v2 1/2] tcp: protect locked SO_RCVBUF from Silly Window Syndrome Date: Tue, 5 May 2026 18:19:19 +0000 Message-ID: <20260505181919.15308-1-ankit-aj.jain@broadcom.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Hi Eric, Thanks for the review and suggestion. > Testing tp->advmss is not doing what you want I think. > > A remote peer can send GRO packets with tiny segments, regardless of > tp->advmss > > If GRO is what you are looking for, why not testing (skb->len > len) ? I tested your suggested `skb->len > len` logic on our reproduction setup. It works perfectly and the 504 timeouts are completely resolved. Thanks, Ankit