From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F38F48B38A for ; Tue, 5 May 2026 21:13:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778015608; cv=none; b=AT1DVYEUqjAR+5elekWzFk2khTyYSAXHlfaTnMCYcCGU2+2pU9BpjnejeRTF/bfGREjUMm4oxG/ok+p3v0QG3j8/UvADW+W4gRhyUQ6oVZg2nz86cICpgARHs3E9iIgsPsqAeL1z5Cy+Zj3g/iAw5zB29u1auCW4DgppJHASD6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778015608; c=relaxed/simple; bh=23flgCKPmr/64LZQVG5CYe9gxCAybtMU8IEcjYVeovQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Quy6XGQVJ/Zm8cmqnlZKdakiZxBz5UqoD1ckLKioLLydTVUP/sPlQ0P8V2pQzgKlJmaSfUeVeou04+cknkChA82YoOtQnuDOJw0IJerRS7UOHU+iZlsSxV/cJU11hDn4m4VIl7YsZtSlJZXWnCb9P400TxXN2X0gV8tg64RkmYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IAZzVyZ1; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IAZzVyZ1" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4893940bb5eso31421835e9.3 for ; Tue, 05 May 2026 14:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778015605; x=1778620405; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MV8sC4ksQylO6CsH5rg4mb+3+8qM/80Gf6RZW/LIH2k=; b=IAZzVyZ1lkF1Nr1iel3VY+5X1gFUt7gFjDNwuxMMWeFZ6xgAZnu8q9LiFm+k+u3n0K sv2LzMwDyl5rDrrT5DYANlYotzeX+/DrDF7V5bkWGaO7Hip6T0usC/ODrYLykejgUo/G hitvfRW4XXKwBuTcB7Plkg118H9DyyjUvTib6T9T6xV+VtXbFowZM43rK8Zn2JFIVDQf 3H04mdC9aTq9Exu9daLrl0BNtbJ9SoTpdk1wucADkp+xflYVM6aSuX8dQgym5gM45AqZ BKGVu7GkIT7QZ//Nqjx6FmvbO8fHGKuqlWYuNlAlot7p2DyYQYcihHWqAP1oQX/EMTjc IOtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778015605; x=1778620405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MV8sC4ksQylO6CsH5rg4mb+3+8qM/80Gf6RZW/LIH2k=; b=QRhfsLD8l8aher2/XAwNPnrblKwlSTDPIBK1d5w1hoS0JxCVLjy+JFeZronUR8YHOi Srkia2l89IYhU6TIT4wBCxHiw5fa1E308xrJI4N0JfW1nCyCMzBuiHh5oyKN+w+cDPdS V/a4N5rc6LBdgTnPQGCBePJJdzZsvP92g8B9FmFxe/8T6rHt/SHCIkSn375IvsOhucz0 jBgTe5g8KoeS2SmsYf+k53CUm9bi35ygq7HlGvxlixctro8VBtbOBQziMu+8uMRfGyaR n17pWB1hanM8um5nCtjreEau8EOlnfZP+RfJQIIYUCHCaRh6cv8E220sJaBDG5EdYoaS 2zag== X-Forwarded-Encrypted: i=1; AFNElJ+9maY0W3yhh2ounC48+fq8A/HQAKwpNHQGPetEq+AySNjmigNUS2QtOpbIMkouq9ni2F+zATuAIxu08GY=@vger.kernel.org X-Gm-Message-State: AOJu0YxnSjpnyQmBOL+m2LmObOigHpKDBOXxSxbjCgjI/JRbTZ+tJjMt l3rcI87CV3Agibm01W6Py33F7jYOI8WwMyigN27HgxvYj7aTjXzNWES5eSXbuZkU X-Gm-Gg: AeBDies14NWtnkI1k9RSQdXlgdzqJIZDbaIKEhrHeHpdI6EwMuGa33nHMoqNgQ/Dph9 PgO9yIfOizPVQO5ULiwQaeE8FAlgXVfJzeDjo3C9pDz3vtrgm2RT6bedLjTRw6LJmcZgTpeopRs Zg4fJeQAfrnSv3Ql5t8pW5zgBJuvsLrD0aVzCTarzp3HNxOsAxDbRq9A1+d57iYkbdOzaCdYP3n pOWG0af5ApkSxnPlkHtskEpClahHhHk0GHNPcRSw3HT5lo7VSQhhsPdaWz8LwdMMevkoj0FhW0m e2c47v4X9wEJbAW1BvUcAD6s4xy02ORTuFX/dOUrcQt4K9FGR4e85VtMoXIVk9beVYr5JTxTtFV tzh5NlZ13CVJdEQ558NUW7mSAYeZFaa1pZ9UUwZUfkQkaW4CDI5evKesmluNZqKS9sHS7Q53Mr4 Wszm21Td/LHa6Ol6pVmxBulnpBzraqVOySlhoO6uKOdL1M76fM+fOL+rss04s6UjWA6VWLLwmp3 oME/BKgYtRXpHfZXYV5l7qwYbViv2EKoYvoi9FphgGd4/maJqJQvP4IdL/N07CqsubEK4Y= X-Received: by 2002:a05:600c:4f53:b0:48a:5565:ec3d with SMTP id 5b1f17b1804b1-48e51f44577mr13674245e9.22.1778015605001; Tue, 05 May 2026 14:13:25 -0700 (PDT) Received: from ahossu.localdomain ([82.78.232.184]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eb6fffcsm403400045e9.4.2026.05.05.14.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 14:13:24 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: error27@gmail.com, stable@vger.kernel.org, luka.gejak@linux.dev, hansg@kernel.org, Alexandru Hossu Subject: [PATCH v7 1/2] staging: rtl8723bs: fix Challenge Text IE length checks in OnAuthClient() and OnAuth() Date: Tue, 5 May 2026 23:13:15 +0200 Message-ID: <20260505211316.3837020-2-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260505211316.3837020-1-hossu.alexandru@gmail.com> References: <2026050453-scorer-rebate-3898@gregkh> <20260505211316.3837020-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Two functions process Challenge Text IEs without verifying that the IE length matches the 128-byte buffer: 1. OnAuthClient() shared key path (STA mode). rtw_get_ie() returns the raw IE length from the received frame, which can be up to 255. This length is used directly in memcpy() into chg_txt[128] with no bounds check, allowing a heap overflow of up to 127 bytes when a rogue AP sends an Auth seq=2 frame with a Challenge Text IE longer than 128 bytes. 2. OnAuth() sequence 3 path (AP mode). When a STA completes shared-key authentication, OnAuth() calls rtw_get_ie() to find the Challenge Text IE, checks only that the IE is present and has nonzero length, then calls memcmp((p + 2), pstat->chg_txt, 128). If a rogue STA sends a Challenge Text IE shorter than 128 bytes, memcmp reads past the end of the IE payload into adjacent packet data, causing an out-of-bounds read. IEEE 802.11 mandates the Challenge Text element carries exactly 128 bytes of challenge data. Add len != sizeof(pmlmeinfo->chg_txt) and ie_len != sizeof(pstat->chg_txt) guards to reject any element whose length field does not match. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Alexandru Hossu --- Changes in v7: - No code changes from v6; dropping Reviewed-by: Dan Carpenter because patch 2/2 changes code from the reviewed version. drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index 5f00fe282d1b..dd3c94d314d8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -802,7 +802,7 @@ unsigned int OnAuth(struct adapter *padapter, union recv_frame *precv_frame) p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + 4 + _AUTH_IE_OFFSET_, WLAN_EID_CHALLENGE, (int *)&ie_len, len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_ - 4); - if (!p || ie_len <= 0) { + if (!p || ie_len != sizeof(pstat->chg_txt)) { status = WLAN_STATUS_CHALLENGE_FAIL; goto auth_fail; } @@ -891,7 +891,7 @@ unsigned int OnAuthClient(struct adapter *padapter, union recv_frame *precv_fram p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_, WLAN_EID_CHALLENGE, (int *)&len, pkt_len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_); - if (!p) + if (!p || len != sizeof(pmlmeinfo->chg_txt)) goto authclnt_fail; memcpy(pmlmeinfo->chg_txt, p + 2, len); -- 2.53.0