From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9504E4B8DF1 for ; Wed, 6 May 2026 18:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091840; cv=none; b=Li5c9N3qvRHN5mh0tmfCvCAHYX3jKX8B7BU6RQFaHb6wo5y3Xj0rSu77M5SqLHvn5xDzGuhu8cPIHJCmw/ocODTBaQdlMu5BTKwgRMI4CjT09wwfwm8fCCEPSRBqiVW/mapvt/7/DFNOjYbxqWD9cpEuTaxbmEHnBDZqSLKZJ4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091840; c=relaxed/simple; bh=lYPMeTtJIh2seYp9KiFqg9l1hNCBdVMTsM9/3i6Rat8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E5AUMpUKZQ0bu1OlMSlSz/cBKPstDwaE8awcOctQP0MfIWABRkawWNaKQzk1ngK7q+n34UrFcdeWeTNgwxpuTto1SnQEcPa0HIFji2D465EmhBK+w1WYviNV2DCUyzKd7zzaPVirERT3djPK2HB4J/GnUmwHrvEWnIhpDmOKtmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com; spf=pass smtp.mailfrom=raspberrypi.com; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b=INGWob7r; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="INGWob7r" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso51609785e9.3 for ; Wed, 06 May 2026 11:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1778091837; x=1778696637; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VDZm8vEfumhsJUxXF2jDl4SATPQGfaZBNb3h0++AQlg=; b=INGWob7rc0LzhGywrtAwl6NgFt7XTl3bPbLDzHcq78gcqRSS4dlq8Hh9oTIujtOfRm Yh6zI2wBhaUqTKWI+TCnqqUOSUx4qnGWvDngr8ZYiuQdjgITAmSiYI55Qvd32IGdoAQd w9WieIWsTqz5GaVs5z0CxkasXf+Coa1Kl5dqginn+SqKWLufRK5CJT52ibR8csQXui8A AEHPcSPRW7MneAa9HPw4zdwkCyL36FVBlp8mjZZVOnHaGgRIxsUQnUR6ncJQt2EpIUKD ZErOWoaJ5ix5lreFQTQxYufqhUI1VI/fZ/Im+qV7n3EURMkwb4K8cDJQnPaZDBNjOWBq Hh9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778091837; x=1778696637; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VDZm8vEfumhsJUxXF2jDl4SATPQGfaZBNb3h0++AQlg=; b=YyvMrvB5FoZ/vJdvXjVOPajKJREhY/3d4PmuCY2E7cxrM4DqjLdB+cqvO89D/qJ7kb 77PmHRN2IfXrVQ+ljWYqAn4mkMv8d69S5aHywW6RubU4SEjqgHDcKOwbQR0xJ74yHqjI tGdzstl1ksd5/GnSLVF3LdjPkk2JaSWB6aFHL5iMLcEAZmOxdGEr0wjo+XxzjHhKwQPF lh+uGrRixbqy4ud9Rgz70npV0a8h6v8zfrsgy+LFIuaNel/p00WPJ6yPKo6HaBpz4uP0 uEAJsbeZN0cfIKNBHKA4BXEzf41da/n8aATcn0k8lAt1Ih2+81ejBYqCMBPcst+7HKl/ HJfw== X-Forwarded-Encrypted: i=1; AFNElJ/MdNCoG/VPUqAxUYIZNCq/cD+1m1PT9Ci5/hu+zX4KCGgWTgap0tNMvXGRKi1GPad5E6InDScXp6jNx4k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/PJ2ra4pLHDhDt8MjlZwlFVY6w+Jp1f9y/cIi1MGFHpT+34eN qy2eofu14ajxXemKJetUJzwPg7a1zJuXZAqYi+kGBa3pS3BCOjxNmCWlPoBjKpzMt7s= X-Gm-Gg: AeBDievbSrEsWmK4QdCl2vMlO+upZVqrKGE687b8x35yDWNoztCsrEFR6Mx6ToYYY4T A8YOGpBDrRVnJpOaDMOTDeNkC0Ca/wU/ZVogkcmQvI9AgHknB+YZGhnfpkaWDC8+YR3g9IYkI07 yViuSyto3xCDD/v5c6lz+eLCv7pt0wBnYF+zdxN0ik/0wWu4neb9PVlaUzZ0jeJDZJmKKhgEpo8 qKMkJsyC7XttobgZUmGu/FNDVL1hmqnupBQQkNjCJU6ayXdYyBe4QZIxPphOdPpWc/Yxn1NPzkr o2p9I4+toq8UhyFPjf2iGzDRbcYy531F8Lp83IQ4eXFGcbsTgN5XXZbbIwDfQh/zp3sxxTYdvzR /kK/5wDskW/0B4G09/Qrw5WgdsPhc6rL6tyfzmOuApEIY89te/HvqXabebnnFo9bQzTh4XWGT9/ U0oirKZeKaOjIidXgl+dg83CXZjul/dESJ7+Q= X-Received: by 2002:a05:600c:a111:b0:488:79a3:f04c with SMTP id 5b1f17b1804b1-48e51f46d1bmr59921395e9.27.1778091836977; Wed, 06 May 2026 11:23:56 -0700 (PDT) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-48e5313b023sm36165675e9.5.2026.05.06.11.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 11:23:56 -0700 (PDT) From: Dave Stevenson Date: Wed, 06 May 2026 19:23:40 +0100 Subject: [PATCH 02/13] media: imx355: Remove setting FRM_LENGTH_LINES in the mode regs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260506-media-imx355-v1-2-660685030455@raspberrypi.com> References: <20260506-media-imx355-v1-0-660685030455@raspberrypi.com> In-Reply-To: <20260506-media-imx355-v1-0-660685030455@raspberrypi.com> To: Tianshu Qiu , Sakari Ailus , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg , 20260414-imx355-24mhz-v1-1-9ae77bc6e7ec@ixit.cz, Dave Stevenson X-Mailer: b4 0.14.1 Registers 0x0340 and 0x0341 (FRM_LENGTH_LINES) are already written from the set_ctrl(V4L2_CID_VBLANK) handler, so don't write them from the mode register list. Signed-off-by: Dave Stevenson --- drivers/media/i2c/imx355.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c index a694d4d742ae..8ea510218c7c 100644 --- a/drivers/media/i2c/imx355.c +++ b/drivers/media/i2c/imx355.c @@ -256,8 +256,6 @@ static const struct imx355_reg_list imx355_global_setting = { static const struct imx355_reg mode_3268x2448_regs[] = { { 0x0342, 0x0e }, { 0x0343, 0x58 }, - { 0x0340, 0x0a }, - { 0x0341, 0x37 }, { 0x0344, 0x00 }, { 0x0345, 0x08 }, { 0x0346, 0x00 }, @@ -280,8 +278,6 @@ static const struct imx355_reg mode_3268x2448_regs[] = { static const struct imx355_reg mode_3264x2448_regs[] = { { 0x0342, 0x0e }, { 0x0343, 0x58 }, - { 0x0340, 0x0a }, - { 0x0341, 0x37 }, { 0x0344, 0x00 }, { 0x0345, 0x08 }, { 0x0346, 0x00 }, @@ -304,8 +300,6 @@ static const struct imx355_reg mode_3264x2448_regs[] = { static const struct imx355_reg mode_3280x2464_regs[] = { { 0x0342, 0x0e }, { 0x0343, 0x58 }, - { 0x0340, 0x0a }, - { 0x0341, 0x37 }, { 0x0344, 0x00 }, { 0x0345, 0x00 }, { 0x0346, 0x00 }, @@ -328,8 +322,6 @@ static const struct imx355_reg mode_3280x2464_regs[] = { static const struct imx355_reg mode_1940x1096_regs[] = { { 0x0342, 0x0e }, { 0x0343, 0x58 }, - { 0x0340, 0x05 }, - { 0x0341, 0x1a }, { 0x0344, 0x02 }, { 0x0345, 0xa0 }, { 0x0346, 0x02 }, @@ -352,8 +344,6 @@ static const struct imx355_reg mode_1940x1096_regs[] = { static const struct imx355_reg mode_1936x1096_regs[] = { { 0x0342, 0x0e }, { 0x0343, 0x58 }, - { 0x0340, 0x05 }, - { 0x0341, 0x1a }, { 0x0344, 0x02 }, { 0x0345, 0xa0 }, { 0x0346, 0x02 }, @@ -376,8 +366,6 @@ static const struct imx355_reg mode_1936x1096_regs[] = { static const struct imx355_reg mode_1924x1080_regs[] = { { 0x0342, 0x0e }, { 0x0343, 0x58 }, - { 0x0340, 0x05 }, - { 0x0341, 0x1a }, { 0x0344, 0x02 }, { 0x0345, 0xa8 }, { 0x0346, 0x02 }, @@ -400,8 +388,6 @@ static const struct imx355_reg mode_1924x1080_regs[] = { static const struct imx355_reg mode_1920x1080_regs[] = { { 0x0342, 0x0e }, { 0x0343, 0x58 }, - { 0x0340, 0x05 }, - { 0x0341, 0x1a }, { 0x0344, 0x02 }, { 0x0345, 0xa8 }, { 0x0346, 0x02 }, @@ -424,8 +410,6 @@ static const struct imx355_reg mode_1920x1080_regs[] = { static const struct imx355_reg mode_1640x1232_regs[] = { { 0x0342, 0x07 }, { 0x0343, 0x2c }, - { 0x0340, 0x05 }, - { 0x0341, 0x1a }, { 0x0344, 0x00 }, { 0x0345, 0x00 }, { 0x0346, 0x00 }, @@ -448,8 +432,6 @@ static const struct imx355_reg mode_1640x1232_regs[] = { static const struct imx355_reg mode_1640x922_regs[] = { { 0x0342, 0x07 }, { 0x0343, 0x2c }, - { 0x0340, 0x05 }, - { 0x0341, 0x1a }, { 0x0344, 0x00 }, { 0x0345, 0x00 }, { 0x0346, 0x01 }, @@ -472,8 +454,6 @@ static const struct imx355_reg mode_1640x922_regs[] = { static const struct imx355_reg mode_1300x736_regs[] = { { 0x0342, 0x07 }, { 0x0343, 0x2c }, - { 0x0340, 0x05 }, - { 0x0341, 0x1a }, { 0x0344, 0x01 }, { 0x0345, 0x58 }, { 0x0346, 0x01 }, @@ -496,8 +476,6 @@ static const struct imx355_reg mode_1300x736_regs[] = { static const struct imx355_reg mode_1296x736_regs[] = { { 0x0342, 0x07 }, { 0x0343, 0x2c }, - { 0x0340, 0x05 }, - { 0x0341, 0x1a }, { 0x0344, 0x01 }, { 0x0345, 0x58 }, { 0x0346, 0x01 }, @@ -520,8 +498,6 @@ static const struct imx355_reg mode_1296x736_regs[] = { static const struct imx355_reg mode_1284x720_regs[] = { { 0x0342, 0x07 }, { 0x0343, 0x2c }, - { 0x0340, 0x05 }, - { 0x0341, 0x1a }, { 0x0344, 0x01 }, { 0x0345, 0x68 }, { 0x0346, 0x02 }, @@ -544,8 +520,6 @@ static const struct imx355_reg mode_1284x720_regs[] = { static const struct imx355_reg mode_1280x720_regs[] = { { 0x0342, 0x07 }, { 0x0343, 0x2c }, - { 0x0340, 0x05 }, - { 0x0341, 0x1a }, { 0x0344, 0x01 }, { 0x0345, 0x68 }, { 0x0346, 0x02 }, @@ -568,8 +542,6 @@ static const struct imx355_reg mode_1280x720_regs[] = { static const struct imx355_reg mode_820x616_regs[] = { { 0x0342, 0x0e }, { 0x0343, 0x58 }, - { 0x0340, 0x02 }, - { 0x0341, 0x8c }, { 0x0344, 0x00 }, { 0x0345, 0x00 }, { 0x0346, 0x00 }, -- 2.34.1