From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EE403ECBE8 for ; Wed, 6 May 2026 10:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778063855; cv=none; b=RLGfQduqQ4W0yzrNxNTMze8T4/tXZZtpbkt49M7NPSJi2shRnJxkKjuK8HgJgPuGWyqtq8VNMCKaJkM6Rda4q0rD70QBM2q8U0xIo7Kt4W5Z/XuFTlTJxLDKsI2cnfXeIcJWc9HSmerpQ/VqOjlFaDjZ5xvii9srnIDTisuTSx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778063855; c=relaxed/simple; bh=gLihIN548vUTh9zMyZBigSL1qNZry4i9B6idag+UWv0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R4RW3CiI4qO9X6RLdcw+2J0dLn3WgOYSP0eAR0mjfhMNjztXYgZlYekocU+MhJIsVhYtvpOTjdV2ebmqSO2/UTFgw/RwNcN0+D8MMtrDycyaKDRC+y5mAi5XXoiBteprBJTWg1SYvW86kXmCTV55+YS8x4y9rV8I38nXl5HYWlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=So9I9tx0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S7LQqRJU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="So9I9tx0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S7LQqRJU" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6466aqEW248341 for ; Wed, 6 May 2026 10:37:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uVqCihSIdFZaOQNn3p5pIOaLLZKzNr7E0qMAQ7FyMg8=; b=So9I9tx06OxMz5tU 8OTnjTkjuBqJgDGOPGLsLdtMcrJNVjTIZT9TE9kl7l786AoAX9qb5Y6DsnhSWVRk vJwDJb+DR/UfcfswnC/5JKxZK4+T01oeHquYcHjfrISHLxSZzCtT7y/yQwiZv9lo Z7ysT9QFb+y/NI4HGlFEKVbuJAPmh/g0h87MpV3sNXoBj//ZjVk262R6bNha1uwi Grl3twZRIPj7YVjHQwVpbqE3pLvdeESa3+kL5CqVKVnGZfLiKfa+yU6Ju7G47QtQ EUjywVKZHDHZDC7cexBv/gjZ+zuCVjyhBMNcPN7unqk2S+d0GWqc2hJ8V7JwZO1l BxvRVg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dyjq442xc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 06 May 2026 10:37:32 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82f9f49e4beso3497354b3a.0 for ; Wed, 06 May 2026 03:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778063851; x=1778668651; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uVqCihSIdFZaOQNn3p5pIOaLLZKzNr7E0qMAQ7FyMg8=; b=S7LQqRJURMTzSzBIdJG8CK9C1McYYuDfD4fv/lKbsixvZYbg4+2LALNjqr4d3h6edY l5ryFJuKDiTACcaQgnIFuq0H5DevDJ6h/tREXwtG0RStSpggSRCyPMNgU/6blIKNiqiq 6sDiSYsCE5SEteIIpwxNGV2QQStiyI2ZC+ta4HZDvPSPujHLxBtNv7i2rgSjd962nNeZ YkG9RQ8Pgv8lXlKVnBaImSy+m1A5sjoqn8BVLpSkN67TmV00bbSawiOjKIs7FcXGqvP+ klJi6vEEr+lYLsxAmULQlzukAnh5vZsU41H2CBBTl0ShDE225+AJdEtTU7+NzPMAl6J7 7Ohw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778063851; x=1778668651; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uVqCihSIdFZaOQNn3p5pIOaLLZKzNr7E0qMAQ7FyMg8=; b=FY8Yp8sXVzmVrhgheqfe0ouu1/OY+XeMLwx99oAINQCoPmdfW//ZjN7H+1IkLSLjY2 sPnjq77HpSUmSxmr2b5+B2qsb5QBsSIBzefOVd2/6BIdk3fqnwSOUzwWRNyvI9G3RITj uz3KSb2WKnLTE7q3BNIi50DMalEMv3NgfctHRoiwwAQuRhBBfWl6Bl4OpAJaI/Uu7GER m6Y00HdHm1dsf1fzfLPc87FyewuBkC9EonREUi6Kgs69OIspgumcyoypqmoq0YE6hInq RlHq2Ggiw8ql5TGhQCr0CCifWQm1brcMpaTypU5hRDKTszI5fY18gQVWNin6/ivPbNuN DFrg== X-Forwarded-Encrypted: i=1; AFNElJ9AC0pQVckCz99lamYILFkqkMJgTvqtGqGcxjBD+kjLqOIMiDLCAZTamZn/OMUocUofBW+5xKjAvv7ezP4=@vger.kernel.org X-Gm-Message-State: AOJu0YwK8SnmST3vJlusdnHWprFq80/d2Vr0Vg7DdZmMqkwuR5Rq7wKJ 15JS3JjOUfrg9mzQbX0qXtafLU2EcXkI3gp9HVENb/SduntCsEKvJjnA8aaMb9MYSuXg5OYYlm0 8R6KKYlsHKtTFbS0rpwj3FRNlfgHwdW7eyCoJ+z/0Lv7zYZyvJpVvTlTjwy42PNmPnaM= X-Gm-Gg: AeBDieuppiR6M7NwmG9mAK5czY+gQs8QJjudpFkNDmp5KdOU15pOnG2G4wOsTr/N9co 3l6Aa6HS3uT8G85RXLCXP5Lb0mn0QYjYO1ksLhy511saXWuYV+V0wrPuOVV62sFJlspV7VL7mMx WU+UE5wmbhEgK8F9kcWdtoG6nqKKIPezB34nk2Uloi2ejewmw62a0pYPB1pTApsF5T8saqYHYnh 6jtwa/FlTkuot1sX6aX2zuB1VCuyci0fsVjUT6RuqQkMAg1YJ1kgLP8A2eiYjTz8oxKYG91RHew s+xKieTGmWG2+YLDjnwU1KHmrBwTeM7g/pZqvZE1vdp0UM9UdNoJa0KW0k1Bdhndn9VDeQ8OYKi Vem7PFK6e3YujpyFL/g7yt+HYJAUM1/CblaTQwr7751iQw7bBueP/uu5roo5RXqbhtSJW2Pk/mv 1p+ESmDoDdoj/XDpfAFKyp0Spm8QZPigdIvrOKaDSj5gimHvZ6rIRg/maTj3gPZA== X-Received: by 2002:a05:6a00:bd8a:b0:81e:b2ba:5b3a with SMTP id d2e1a72fcca58-83a5b6d0a61mr2806873b3a.8.1778063851427; Wed, 06 May 2026 03:37:31 -0700 (PDT) X-Received: by 2002:a05:6a00:bd8a:b0:81e:b2ba:5b3a with SMTP id d2e1a72fcca58-83a5b6d0a61mr2806846b3a.8.1778063850920; Wed, 06 May 2026 03:37:30 -0700 (PDT) Received: from hu-yrangana-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83965b333f2sm6167123b3a.20.2026.05.06.03.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 03:37:30 -0700 (PDT) From: Yuvaraj Ranganathan Date: Wed, 06 May 2026 16:07:13 +0530 Subject: [PATCH 1/2] firmware: qcom: scm: add trace events for the SMC call interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260506-scm-tracepoints-v1-1-4bc983264014@oss.qualcomm.com> References: <20260506-scm-tracepoints-v1-0-4bc983264014@oss.qualcomm.com> In-Reply-To: <20260506-scm-tracepoints-v1-0-4bc983264014@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio Cc: kernel@quicinc.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Yuvaraj Ranganathan X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778063845; l=5508; i=yuvaraj.ranganathan@oss.qualcomm.com; s=20260506; h=from:subject:message-id; bh=gLihIN548vUTh9zMyZBigSL1qNZry4i9B6idag+UWv0=; b=tFtPfq4FdIRkchDK02ytyi5W3UdogRtooGhMVIN11YMOP+89Mu8S9Ov/i8wb1I/3MpprUpMah drpA3wDJYkfACvQCuAfepbbTrTMZovlSH5f4SDSyng4yLyxE0olYNxW X-Developer-Key: i=yuvaraj.ranganathan@oss.qualcomm.com; a=ed25519; pk=ln7RObom4c2W8MEnQqwZbOi6X198/6toN51al5+6rKI= X-Authority-Analysis: v=2.4 cv=MYxcfZ/f c=1 sm=1 tr=0 ts=69fb19ec cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=9OSSLOKjDFKvovXBaDAA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA2MDEwMyBTYWx0ZWRfXzUvDw9DBxfBH 41bA6cPEvmGrflIk77I6cdCdWifoURgsmjGLBGtxMGgBdktgyZ34B7OvkmP6MCfyLcwkv+ly1UU VHZqueWJnIISJYj5uqSoNt5XshwCSWFH7eZbXdEIZVloXLiQfEIDNkA9CUw9PIkwWolhYntof8i 1QcKXLAgsilv11mDdy/yPy3RtOfKPq1E12jEu7mMY9xghU0N/fZ1yFbG8QSAqUCM18pS1XqCqET F7Lnc9mAodYVtkVS+lW1YIjY7oqTb+DrrOw+94KY4n4UGeR8LjCsTPaUq2d+ZH3lmqnBuezT18J 67rzvzeVUcLDodb9qDNvL0OIA3DxM1a1aU9fMyp1hoeSskqZggSykplaoLqySLhONqyHjKUNnND Nc+8tszG9aG5L3EgaoIaLxqp1rl9/31FtT1JLLH9wON8rP1qBwGgsOFyPZzMMzPMMDXZDYa3iuN 0sjG61cDWRZkQ7m+C1w== X-Proofpoint-GUID: 3x-vu3kR7ZEc8_7NDGYlrAbqBATXTTY7 X-Proofpoint-ORIG-GUID: 3x-vu3kR7ZEc8_7NDGYlrAbqBATXTTY7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-05_03,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 phishscore=0 clxscore=1011 priorityscore=1501 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605060103 The SCM SMC call path is opaque at runtime. Stalls caused by firmware congestion, QCOM_SCM_WAITQ_SLEEP/RESUME cycles, and EBUSY retry loops are invisible without recompiling the kernel with temporary printk statements or attaching a hardware debugger. Add five TRACE_EVENTs covering the complete lifecycle of an SCM call: scm_smc_request Emit before each arm_smccc_smc_quirk() invocation. Records the SMC function ID, decoded service and command identifiers, argument count, and up to six register arguments in hex and decimal. Because the caller loops on QCOM_SCM_INTERRUPTED, this event fires once per physical SMC instruction including inte scm_smc_done Emit after the outer __scm_smc_do() returns, pairing each request with its final outcome. Records the SMC function ID, the kernel error code returned to the caller, and the four firmware result registers a0-a3. scm_waitq_sleep Emit when the firmware returns QCOM_SCM_WAITQ_SLEEP. Records the wait-queue context and the SMC call context handles required to issue the matching WAITQ_RESUME. scm_waitq_resume Emit just before constructing and sending the WAITQ_RESUME follow-up call. Records the SMC call context handle being resumed. scm_waitq_get_wq_ctx Emit after a successful WAITQ_GET_WQ_CTX fast-call. Records the returned wait-queue context, flags, and more_pending indicator. These events let ftrace and perf reconstruct the full sequence of firmware interactions, measure per-call and end-to-end latency, and attribute waitqueue stalls to specific service/command pairs without modifying driver source. Signed-off-by: Yuvaraj Ranganathan --- drivers/firmware/qcom/qcom_scm_trace.h | 143 +++++++++++++++++++++++++++++++++ 1 file changed, 143 insertions(+) diff --git a/drivers/firmware/qcom/qcom_scm_trace.h b/drivers/firmware/qcom/qcom_scm_trace.h new file mode 100644 index 000000000000..ca8b120563ad --- /dev/null +++ b/drivers/firmware/qcom/qcom_scm_trace.h @@ -0,0 +1,143 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ + +#undef TRACE_SYSTEM +#define TRACE_SYSTEM qcom_scm + +#if !defined(_TRACE_SCM_SMC_INTERFACE_H) || defined(TRACE_HEADER_MULTI_READ) + +#define _TRACE_SCM_SMC_INTERFACE_H + +#include + +TRACE_EVENT(scm_smc_request, + + TP_PROTO(unsigned long a0, const struct arm_smccc_args *smc), + + TP_ARGS(a0, smc), + + TP_STRUCT__entry( + __field(u64, smc_id) + __field(u8, svc_id) + __field(u8, cmd_id) + __field(u8, args_cnt) + __dynamic_array(unsigned long, args, + min_t(u8, (smc->args[1] & 0xF), (u8)6)) + ), + + TP_fast_assign( + __entry->smc_id = a0; + __entry->svc_id = (smc->args[0] >> 8) & 0xFF; + __entry->cmd_id = smc->args[0] & 0xFF; + u8 n = min_t(u8, (smc->args[1] & 0xF), (u8)6); + + __entry->args_cnt = n; + + unsigned long *dst = __get_dynamic_array(args); + + for (int i = 0; i < n; i++) + dst[i] = smc->args[2 + i]; + ), + + TP_printk("smc_id:0x%08llx svc_id:0x%02x cmd_id:0x%02x args_cnt:%u args:%s", + __entry->smc_id, __entry->svc_id, __entry->cmd_id, __entry->args_cnt, + __print_dynamic_array(args, sizeof(unsigned long))) +); + +TRACE_EVENT(scm_waitq_sleep, + + TP_PROTO(u32 wq_ctx, u32 smc_ctx), + + TP_ARGS(wq_ctx, smc_ctx), + + TP_STRUCT__entry( + __field(u32, wq_ctx) + __field(u32, smc_call_ctx) + ), + + TP_fast_assign( + __entry->wq_ctx = wq_ctx; + __entry->smc_call_ctx = smc_ctx; + ), + + TP_printk("wq_ctx:%u, smc_call_ctx:%u", __entry->wq_ctx, __entry->smc_call_ctx) +); + +TRACE_EVENT(scm_waitq_resume, + + TP_PROTO(u32 smc_ctx), + + TP_ARGS(smc_ctx), + + TP_STRUCT__entry( + __field(u32, smc_call_ctx) + ), + + TP_fast_assign( + __entry->smc_call_ctx = smc_ctx; + ), + + TP_printk("smc_call_ctx:%u", __entry->smc_call_ctx) +); + +TRACE_EVENT(scm_waitq_get_wq_ctx, + + TP_PROTO(u32 wq_ctx, u32 flags, u32 pending), + + TP_ARGS(wq_ctx, flags, pending), + + TP_STRUCT__entry( + __field(u32, wq_ctx) + __field(u32, flags) + __field(u32, more_pending) + ), + + TP_fast_assign( + __entry->wq_ctx = wq_ctx; + __entry->flags = flags; + __entry->more_pending = pending; + ), + + TP_printk("wq_ctx:%u, flags:%u, more_pending:%u", + __entry->wq_ctx, __entry->flags, __entry->more_pending) +); + +TRACE_EVENT(scm_smc_done, + + TP_PROTO(int ret, u64 smc_id, struct arm_smccc_res *smc_res), + + TP_ARGS(ret, smc_id, smc_res), + + TP_STRUCT__entry( + __field(int, ret) + __field(u64, smc_id) + __field(unsigned long, res) + __field(unsigned long, res0) + __field(unsigned long, res1) + __field(unsigned long, res2) + ), + + TP_fast_assign( + __entry->ret = ret; + __entry->smc_id = smc_id; + __entry->res = smc_res->a0; + __entry->res0 = smc_res->a1; + __entry->res1 = smc_res->a2; + __entry->res2 = smc_res->a3; + ), + + TP_printk("smc_id:0x%08llx, ret:%d res_to_callee:0x%lx res0:0x%lx res1:0x%lx res2:0x%lx", + __entry->smc_id, __entry->ret, __entry->res, + __entry->res0, __entry->res1, __entry->res2) +); + +#endif /* _TRACE_SCM_SMC_INTERFACE_H */ + +#undef TRACE_INCLUDE_PATH +#define TRACE_INCLUDE_PATH . +#define TRACE_INCLUDE_FILE qcom_scm_trace + +#include + -- 2.34.1