From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 222193E3C59 for ; Wed, 6 May 2026 08:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778056149; cv=none; b=VGf5pHxJJFJPrLiFzA2WPOFXYKxQ9lM0WNS2ilTJcd7YdSGtq7q6eZJ1cwF4f/eperdtG1Zt2QAg+8bNC+IPn7SABHzrQfa1qTCuk3s+2gQZ64ZxdD8wwXus5xD5OFgQtZ4WGvYU1wI7VGPqcxbRi0Nz9FjIlIhOS86k91W/JIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778056149; c=relaxed/simple; bh=i3BWJm5Wc4DqV9P4dcBQDCZ3T6VnCrSYNeQlUGqTa2s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qb/TbTCjC0eZruVKZrgrLU2nYQ9rW+eDs1YTZ2QkuVdHV+q6sufxQDr5rQdoNI4pt34++W1k+L/X2VONGvQA1S+G67oP0h4+wYsEqWXcPS8FgpRzwvK1Nq2VTY3fm0O3iyMeCiWVZEaczqBilzPMQYj+NSmpx8Hif/HhvsNd4v4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=QTnKvD8U; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="QTnKvD8U" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2A4751AED; Wed, 6 May 2026 01:29:02 -0700 (PDT) Received: from e134344.cambridge.arm.com (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id AF9C63F836; Wed, 6 May 2026 01:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1778056147; bh=i3BWJm5Wc4DqV9P4dcBQDCZ3T6VnCrSYNeQlUGqTa2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QTnKvD8UfT0oOapPd70bqzSUHOkhdHMPidAaXs00zoq8KUOUbYiAf0x81MSO6G114 38TtLpiZcXSToQoSxEBjGh99Lj2698fCSsA18Gam/T1/jM+ld5onoQYdsLa4u7qnvT V2A+DspkYere+iur95P44qvi2fqAgVg9/zzudgTA= From: Ben Horgan To: linux-kernel@vger.kernel.org Cc: tony.luck@intel.com, reinette.chatre@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ben.horgan@arm.com, fenghuay@nvidia.com, tan.shaopeng@fujitsu.com Subject: [PATCH v7 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() Date: Wed, 6 May 2026 09:28:49 +0100 Message-ID: <20260506082855.3694761-2-ben.horgan@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260506082855.3694761-1-ben.horgan@arm.com> References: <20260506082855.3694761-1-ben.horgan@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error path in resctrl_mkdir_event_configs() is unnecessarily complicated. Simplify it to just return directly on error. Signed-off-by: Ben Horgan Reviewed-by: Reinette Chatre --- Changes since v5: Correct order of the tags Changes since v6: Add missing commit message separator,--- --- fs/resctrl/rdtgroup.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c index 5dfdaa6f9d8f..fb6999178fe2 100644 --- a/fs/resctrl/rdtgroup.c +++ b/fs/resctrl/rdtgroup.c @@ -2333,20 +2333,19 @@ static int resctrl_mkdir_event_configs(struct rdt_resource *r, struct kernfs_nod kn_subdir2 = kernfs_create_dir(kn_subdir, mevt->name, kn_subdir->mode, mevt); if (IS_ERR(kn_subdir2)) { ret = PTR_ERR(kn_subdir2); - goto out; + return ret; } ret = rdtgroup_kn_set_ugid(kn_subdir2); if (ret) - goto out; + return ret; ret = rdtgroup_add_files(kn_subdir2, RFTYPE_ASSIGN_CONFIG); if (ret) - break; + return ret; } -out: - return ret; + return 0; } static int rdtgroup_mkdir_info_resdir(void *priv, char *name, -- 2.43.0