From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F864492510 for ; Wed, 6 May 2026 15:43:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778082215; cv=none; b=OdcDp5Edk8qfktSQlNhIffiNTvSL+x+8ebXPepRvRg9XzSe3GLeQuZYGHuGwzNxkBvHEeDa5cl2/meu5CH1yyB8XQK6V+eXv5iz0FaDlZMO5dGuoYhP69HSzavNuyi1ILoyhGKYnL1qvkTIov2x66BlbGOrCvttAUiQoEm1kW34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778082215; c=relaxed/simple; bh=fc0UCfWAi93QxZVKMurRg9gBAkKxhWc0Wvdno1Zk6bQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WfE2rd2LFogCarO8ECZ/8kM9pUBSo8fKG47zDD5yWnpdG3VPKOs0qHBVhNcGuOiDqysLJEPsH3vKhjVed0wQQTa5XrLhfsnmenL9Uxrq+XhSzJIcj21wgbH95riVBamHur3x9M1Jn6GsP9GLNE7gR6D5CmnUWUccH/uka4N+3P0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sW2XE3mP; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sW2XE3mP" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5a87782588cso4691992e87.3 for ; Wed, 06 May 2026 08:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778082210; x=1778687010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fc0UCfWAi93QxZVKMurRg9gBAkKxhWc0Wvdno1Zk6bQ=; b=sW2XE3mPb4vHOvQGvESQ8wPufOM30UeFxVC/egDBG/ZNJLoKB9oQYGT+RXpoGOS8dr CS99HoEx6fWFZa48GHtUF/MTmhAEglIxTsBC2EglfdvIKQQQ0HKGJbgYkZ4cDh3KCgNk LJGcsSK0nWZf00FH+1to+MvsI09/RCUZJQWIIe5ZC7XMJjzYPaW8d1J5fW6+kW+qwkCj YzmYyN+pygGKSDYOAIKsGupLPpzdVpoG3jk9n3FCBxZ1f42WwCPLUBuxpG8+xQMCzvBM wx4xhE6vjNUL2QeaBu+Wa4m/JAKUukKyjYVmeAGgGJ1tDtbHQpIgc0SrHgozcgvKGYfv IRuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778082210; x=1778687010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fc0UCfWAi93QxZVKMurRg9gBAkKxhWc0Wvdno1Zk6bQ=; b=LiCrEfCF913qL3BuplIFh7LYgOiii5MaD3wyh4w2pmwWsi4XRCwus1Oweph6j/w1iq s1qAkUbpsHt8QnuYl3711ooAP/YHwmRNz1YfyM7sIfqVdIRiJjmiUizKIDj6hSWvG6rv kCnjyErd6UYgI+9uTmCwtmFTJKoUDT/0bKJoBzRrmhbHmMjmlN9ktqMjqRS+E2Nm3LdR U3R6pqKwhsdSDDligoxVRUOQOwSs/5kgx715X8WdHX9pE4u97fbVgyPpUbIFAyAvNZbe YssIZ7pMQFTy/ZK6Pi+oD1DjT5DAsOWNxzvrcr0y7+EqpIfSLBPuHUey6DPNqvbJh3Rb rX/Q== X-Forwarded-Encrypted: i=1; AFNElJ8eek8Olbd8JY8sAuzDUcYZAMQYallVy0QTNJ0oBsTwMb57uKoixbmpORu7kqkAStlmHKVexV2FxeKTWZw=@vger.kernel.org X-Gm-Message-State: AOJu0YzXKnUySE1DY4D2QDTtrueb/8Drt4H0BOVabWc46Hs+ZrFYB8Ai sfAAoh6wDzsQIt95eMTtbA7lTAWxynQ9KluiquMsW1DFzOvwdxlcFRXhDFxADSZIcPIZyJPNYiE = X-Gm-Gg: AeBDietT0J8gSHqa72VzIKt7ig9XKpUbLGLakSSITtpGLvYO4VMi66P2q1HxNGYa4iR Ux/xt1o6wgIzCIjqeXDMT7rg+szkUY6zQAG8v/bga/mi2rBh/FaglneLtT+PcKMkPsDR00nOhuJ hNCnSs0EB2jL1gaJgCYMUjQjkczaNEHSTAIbHV6tTV/cttJnW+1pFklZkyK1h/y6eYH7T9qii+F +gyZkZGQ2ygO72h/qqDEwnmLd94Wu0MxmTDMGRdtID+awbDU8oGOHH1NUq1bIkLchrmysTP5gPs 41XR40hS179R5vAovpiQP7+IMEg0BEAOZjGqUUGH1fc9R9eYAgqqxQjdNDFzqyvQ+61ZRErWn1i OK+s1EmE47qd+qaE8sjXbg0picWkPm3EHmZSmnQTsKfX78JhS0kpPcakOPfxwvRCDpiPAJoSFJG 85psz1BGXPLjiIQzjrQXxWdkhxS2s2nm5BET9yvJGbR8aQiUuZ61gW9vQ7bH9r4P4rnrvgEn0= X-Received: by 2002:a05:6512:685:b0:5a8:5b19:fd03 with SMTP id 2adb3069b0e04-5a887a9b5ccmr1445551e87.0.1778082209637; Wed, 06 May 2026 08:43:29 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([193.0.150.248]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393919f663dsm34884431fa.33.2026.05.06.08.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 08:43:29 -0700 (PDT) From: Valery Borovsky To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Valery Borovsky Subject: Re: [PATCH 3/5] mtd: maps: physmap-core: fix reference leak on failed device registration Date: Wed, 6 May 2026 18:43:27 +0300 Message-ID: <20260506154327.673283-1-vebohr@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Miquel, Thanks for the review. I need to withdraw this patch as well, for the same reason as the rest of the series. `physmap_flash` is a static `platform_device` without a `.dev.release` callback. Using `platform_device_put()` triggers a `WARN` in `device_release()` when the kref hits zero, which is a dealbreaker for systems with `panic_on_warn=1`. The kernel-doc NOTE refers to dynamically allocated devices; for static ones, the original code is actually correct. I've already sent a withdrawal notice for the whole series (1/5-4/5) to the cover letter thread. Sorry for the noise. Best, Valery Borovsky