From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8591D4A3405 for ; Wed, 6 May 2026 17:11:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778087518; cv=none; b=HUcXr+IYOoCI+nm2ePgGHlSmDZ/rvpr5ewKXz3Wask3a791AgTnoixBiQNq3C9mMR4K4InmiH8rMQVXq19yJWariDhPrUJvlXxd8LLMF0n8KIbR+K1DGBg51EsRcPTYPN4BOu9E7NnU/t5l1uCR+Ib+UdP51/5pUdSF0NF342h4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778087518; c=relaxed/simple; bh=/NsgYCf/YJOjQfBrxIduQkHUSM4dKNrQiRj00JRK8V0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PHOOAVyo2wgaAmhFbVxGiIlfQfR+/A7QCzO9hibEx6Y6B3TURm091G2Mwty7+aIoGiO4QdLijSNrDVx5d9PXji8R+Tb6+V/zeMSFss4YX/3jozErvmB4bt5POhHzpCIzc8SBeTMAfk5gNve/FqgBKlFLqpIfhl5bBBaTvxdnjME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OivMl99T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cxpTvBaf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OivMl99T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cxpTvBaf" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 646E6JS52427566 for ; Wed, 6 May 2026 17:11:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=QpEOCCW2frO 5RjDS7yw8Uzvvr6ebtp3PdlAzKWnUJ/s=; b=OivMl99TIdvd6nhFOLOP//OkGBR HsseTZsMnMJohRoaz6tMCR5J+QnNHTZlLGlZj3GuGU22pm6Dfr1qf6KqOTIXAqi8 o76Hecpwwvo6WA/p9P/afRpimk9sOm+nLP5gq+9LwHFdvue5jvwrfQ7CM9BiY62A F0oXbl4u8RX/Of9RemnVrrUB5uk2RUHNBp6bCNtQjHU1o4E42RbnpLyZF9niKpER lDu0D5eu9FC4MEVG0Y3L4Jbec3VavTRCrC5Fi3rkRhAHNx/++mNVupt5mS40BkMU uJyakgrxn3Vh+IGyQIX5NGecIzVWfUs40Tes39S7zjURdwgbweQGxyzJV4A== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e01ph25sc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 06 May 2026 17:11:45 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c70f19f0f37so626911a12.0 for ; Wed, 06 May 2026 10:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778087505; x=1778692305; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QpEOCCW2frO5RjDS7yw8Uzvvr6ebtp3PdlAzKWnUJ/s=; b=cxpTvBafGC+LlpIuR6x1GIYBQ3wOQW6jk5R10LQlALXdEIH8ly/VK4NmTbNn0ax4Km zfcv27B/srDVHzchJOycBrOxlEmaR8azoMPi356knOl9XGeD3JzZRsX1Xg9nD1jG1r1m 2keHFi+Bk/ReHvvklZetmB8l2My27L6W9FVLSowfIem+XBxWwKKxQ+deK5coi6t8PPfP yCAhAlRp05N/gThOzY8WtRReSprjbhDosIC3Urz9I7IljKEZEiubTxlTTsPnlGo7cB+0 9jPPMYvzyu0S27gHFZMshzmD0aGTpBcsef+nr5Nkg5OnvExAmWLqd/QAyeL1XYvxheWv Vvjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778087505; x=1778692305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QpEOCCW2frO5RjDS7yw8Uzvvr6ebtp3PdlAzKWnUJ/s=; b=Jxm43kkeK8R4CVhzrDm7oeBy+Cq2aaTG9UEkDeaCQp8gzmmqy8j5cecLSloFjqrLfU ySqGq3ykir9ZCbRXqV2m6rcI0G5mSuVeOFuY20npWWNsfIONa0zqVyBujHOBkG+Ldhww B7p9rMcESigzDHXbeUM/q/LRZaOxwe4A6LIwL1G5uRtBkbpy5Zdoy1XwSok83did6XHp 9qSbzVYkVYJoExEp2FT1+tRgaY9vhiGJf2sJNDBr6OT1T1KiJ4HTvC22Jh/caT5u4tfn WEVO0V1mi1bh5A3bgqgRSAjPShC4VBHn7izfvnPqIUy1CV0Iyr6KMSHXOEoM4LNbwB4I 43RA== X-Forwarded-Encrypted: i=1; AFNElJ97Z8X1PccF5zsvs7fix3VbOrfDy8zOT3YG9FdkbSlpfiDt3zik1eNGvPxRv1PzhHItEMnO617sSP8d5tk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxp2wAgE7qfNusTrJ/TA2cuDtH1cT8vCsAb0HpvDvpYGkKhra7m Q/x5TK4639vzGtdfG+m4vMHGF5FsHL7MFW50L9UFbeOL6k5b9PMGpUNGI5/dcRDxwCUeMtIvNSc o+L7KMh6wKT0iS1GtO50Q+rFbvtMdB8Fcue67kD6KnYMZ8N15pOPq3vXvd6kD0sEAnEY= X-Gm-Gg: AeBDietKDVHkB1bGgUw5VMYZPYUhMN8V49ARRjvJCtLE/A4WsEs7u6PwsQckEDieTol nmfHVFZ0BMzne14yzlqcpVH7y0BbQFjzbjqAul5jkQ/bT0ELpOOxr1gFJZzwZXflwqFmuF1cIEe U0DuNO6ZVxjuhUZZpdZCN7FSq5ATRo4eAIrprwBfEH1In7YvUjO4WrGuaRN1UUMZo/iQQ41L/Cn Bv5l86OANUjECPw+hM9QBwFsYGQ0FNZO+W3B3U96jAhOGQHpUpyjF1k/6W+QHTrJZBFXNVhOSXS jDbi74D8q8nkYObNHO5l1/oep/F9YyjX+V1r9vKixkrm876PCAqL0/SIqC8xYOedXtiECMyUnNZ 0Iff/HxZ7/5cotirhOChEIDnSLVZpNvi75abeAXYYi9Q= X-Received: by 2002:a05:6a00:4c9a:b0:82c:9c90:6ea0 with SMTP id d2e1a72fcca58-83a543f90e8mr3635785b3a.3.1778087504823; Wed, 06 May 2026 10:11:44 -0700 (PDT) X-Received: by 2002:a05:6a00:4c9a:b0:82c:9c90:6ea0 with SMTP id d2e1a72fcca58-83a543f90e8mr3635759b3a.3.1778087504254; Wed, 06 May 2026 10:11:44 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-839659498f1sm7685226b3a.17.2026.05.06.10.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 10:11:43 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Dmitry Baryshkov , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Date: Wed, 6 May 2026 10:10:26 -0700 Message-ID: <20260506171127.133572-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506171127.133572-1-robin.clark@oss.qualcomm.com> References: <20260506171127.133572-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA2MDE2OCBTYWx0ZWRfX31nOAajuiCUM 3WyKoUUtij5vto1wXUm+a4sK+LAAn+QT91EDlZRQodU41mnVAvIZeWcV654YWuZWytD78B8ypum KiT6wHJCCXqVPLtT1560stj0qrwsswnozcG4a2gcTbA1DQ0zWdAqw9iMmiQXqJ3VSXZ7wmUkPpE HW7+rokbQGB+7XRL519wEa9Y0L0KUUegpxFpfVhQIoeeqB8sxHPv6dvBCJY6rPyxC9OYykbSGfD cJVxvhNHVUQOfCgRMJrqyhJBXYBwVpTGZnOmH4WCQRwDgqH0BNtXUC1DeC3dTHXnQYgNWFW47y6 sCrpZ2Ou1YCUcDcv/0gofwJAcEoyxanXo3P0iUwc4Fl/LN2LYMHNPIA9aFMRp/+C9+D0e5j6Z+u XYZ7FaNxtAKV5M7JpnAqHNuTI2745Y8L6Z82hHcjghKE2As2ujafyMnGq/Jv8bcpQUNCxLeH/6H fNLXNnE4IWZUHYpHPuA== X-Proofpoint-GUID: N92gFswlXhLoG8XdYWKt0mmqNvrmQc64 X-Proofpoint-ORIG-GUID: N92gFswlXhLoG8XdYWKt0mmqNvrmQc64 X-Authority-Analysis: v=2.4 cv=MYhcfZ/f c=1 sm=1 tr=0 ts=69fb7651 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=ZRXlmS4ShPoOlOK7p90A:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 impostorscore=0 adultscore=0 spamscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605060168 Use perfmon_capable() which checks both CAP_SYS_ADMIN and CAP_PERFMON. This matches what i915 and xe do, and seems more appropriate. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 66f80f2d12f9..72b71e9e44f0 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -494,7 +494,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return 0; } case MSM_PARAM_SYSPROF: - if (!capable(CAP_SYS_ADMIN)) + if (!perfmon_capable()) return UERR(EPERM, drm, "invalid permissions"); return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: -- 2.54.0