From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F13262E7BD9 for ; Wed, 6 May 2026 19:09:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778094550; cv=none; b=mGPTtVJ35HdTYPFTcEyhQoXLMnw2Ug4Kv78ZHRZ8FdI0nHTc8dbIWOJmwFdGozzduhs8UO2Wq5OC2z963kK1KBUh3TDt8PbIhehix/q9ShNR4NqHH/0e3ls+PqfiZClgKV0bvY0Z6xBEUSNMN4BfR/B54GfZGZU0HVu0wqhdTrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778094550; c=relaxed/simple; bh=u0gO9itySAgqinXb+Yu2ZMW7pogwME51DV+OiYaa03E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qnt0lvI+EJ4njpcGlvb0dbpbjwwAAcNRwOah1c2iqsnR02rV+OirjSNLMwjkt8vbu/26/HOSEtzA0ANgfOAC2VXPOioy2p1YeA9PwUs8HH+XivMZRO01SruhiUBJyoJ9+ndZTUo0LFDX1b6n8/Pesw7e2hZVdLW3vkeXol8wmzc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G904GJ1n; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G904GJ1n" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-512f750d4b2so33932051cf.1 for ; Wed, 06 May 2026 12:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778094548; x=1778699348; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rr1dQq7NCJJ5aSAMedCihgXSO/FjJKmjQPu+yzQ2vbA=; b=G904GJ1nWTxUVrWMzsDd0GlDHM+4MG8ibaI/LeKNACM004oAdwRtlyDu3A6k+jQAdQ /xmqeUnkJe2Pq3NBN68um5p/sx+q8e+mixVrFCVsCQqBC1NtWFCqIGvcUbDOC3cBxKYI qJkzSNwdp6xkF9QkJkpXg4+BLQO6ZNSX1OHmpoEptXVAllkFQMG3qwESVNXVdCvj1Vgq kIWE+n4dtnjAeXrgkxxWB6a9/uacyFbrNv7nJxp7aatHRZWyAxLNcEt/R3WycWzAHt3L KXEnXaT8MEf4NpgqYuFRt3u0lNS24eUAOkWmiXqYeekZB80XP0wzh1ctNomZ9Sw0txCn XbzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778094548; x=1778699348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rr1dQq7NCJJ5aSAMedCihgXSO/FjJKmjQPu+yzQ2vbA=; b=X0m4F/GZ3bbplQgAykF60NNr4/tB+tV9wDpWBdshH+gnGpqG6+X7aIW6G+8bPdTGU1 VKvexH0AyIZTJOA9gUTOZgLGP9oQIncFy1y/1jXetBcifiMCXqJu+z0Zn5pfVN7KPjKi 5mJtNj20AXKzSWrOZ3dRunfhvNOBeYA47+jmKdsj+rBStAAh2JcZb6hwdTP4Ru0rlmAm puCJc4X/frk8T1hwbg0CW1ql704+5O/bG2qam1OXHw8cgM6mwLUCImZx+S9ADGLsVHkZ Woi8g4iDXYfHt5ygjCQF9ZECpU4bdhMke70qNWG0msYjAJSjjqKzqV5T4XwQc5c0KkJI zUgw== X-Forwarded-Encrypted: i=1; AFNElJ+t+AAa9GzrjWjTzSx0tzZnPgENI2KM6Wqa0tn01f8Sh+2T5h3LPP6qQlGtCkohm9cZ1CoBJcfRy1TgLPE=@vger.kernel.org X-Gm-Message-State: AOJu0YzKLwWxhCLM/cPDZMu3AIYIM2xq+ps3kcKNrAgI0umoH8QIoIn0 F0aOBh7fiLGFuIVXjg8QZoacMsJioxjcHXx3j/ggra2xS9VD9AIC+7CJ X-Gm-Gg: AeBDieun8q4/TqwKwLRhjCQO0X6c3qRyHeo2/9xhoLsWmPiSa2bXx9vxbwGGcyP4xbm gBpzBOzuogwKTcW+6YMla6JmtiDO8sgcqAkFrb9QkxDYD7jxLaSLzF62HQm8icnf3vOY4daHiIL qBFnrw5QbJEvnYUAEfqswHcDILl5yBLVJawiADWWaSIgSRFhxF8HuH+JwW3diRkcrBkIiZb2Rtv HmpIuveq3e8TdOn0odmWS0zbN3NcAWlHrMO5EQOmM9NECxyp4cYOaIG8PiQ7gI6zsqMbNWOQjsu HMIzobY9zxLZw0qiD8lQFTfuxmKIAdvOKspqQLB6mqvuCVrl3j6eZ6vzrz/J36OpbA7jTGV8CRM Tka+z8ZFR1CZYsZBf+MAfo2LoBiHwMO2M+PXjx11z3b2XerhcUnw8Banen93jozRDP+JyAreY06 wrlS/o9H2ZnEwv1sL/1cg9PFjqD4+Hq/NiWJZQ8HBdOC+lWb1B0aqXzaP9AJPa5LPT0AE= X-Received: by 2002:ac8:5a54:0:b0:50e:60d7:b286 with SMTP id d75a77b69052e-51461be059dmr66271391cf.1.1778094547763; Wed, 06 May 2026 12:09:07 -0700 (PDT) Received: from PF5YBGDS.localdomain ([163.114.130.1]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5104090bb03sm157489421cf.10.2026.05.06.12.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 12:09:07 -0700 (PDT) From: mike.marciniszyn@gmail.com To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Duyck , Kees Cook Cc: mike.marciniszyn@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/2] net: pcs: xpcs: Add hooks for xpcs configuration of rsfec Date: Wed, 6 May 2026 15:09:03 -0400 Message-ID: <20260506190904.4029-2-mike.marciniszyn@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260506190904.4029-1-mike.marciniszyn@gmail.com> References: <20260506190904.4029-1-mike.marciniszyn@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Mike Marciniszyn (Meta)" The DW PCS IP data sheet calls out the need to populate these vendor registers when operating at speeds above 10Gbps. This change enables the correct FEC settings to enable RS-FEC encoding on the link which is the standard used for most links at these higher speeds. Reviewed-by: Alexander Duyck Signed-off-by: Mike Marciniszyn (Meta) --- drivers/net/pcs/pcs-xpcs.c | 82 ++++++++++++++++++++++++++++++++++++++ drivers/net/pcs/pcs-xpcs.h | 6 +++ include/uapi/linux/mdio.h | 3 ++ 3 files changed, 91 insertions(+) diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c index e69fa2f0a0e8..0987621632a7 100644 --- a/drivers/net/pcs/pcs-xpcs.c +++ b/drivers/net/pcs/pcs-xpcs.c @@ -219,6 +219,12 @@ int xpcs_write(struct dw_xpcs *xpcs, int dev, u32 reg, u16 val) return mdiodev_c45_write(xpcs->mdiodev, dev, reg, val); } +static int +xpcs_bus_write(struct dw_xpcs *xpcs, int prtad, int dev, u32 reg, u16 val) +{ + return mdiobus_c45_write(xpcs->mdiodev->bus, prtad, dev, reg, val); +} + int xpcs_modify(struct dw_xpcs *xpcs, int dev, u32 reg, u16 mask, u16 set) { return mdiodev_c45_modify(xpcs->mdiodev, dev, reg, mask, set); @@ -1402,6 +1408,78 @@ static int xpcs_read_ids(struct dw_xpcs *xpcs) return 0; } +static int xpcs_get_pma_mmd(struct dw_xpcs *xpcs) +{ + int devs1, b; + + devs1 = xpcs_read(xpcs, MDIO_MMD_PMAPMD, MDIO_DEVS1); + if (devs1 < 0) + return devs1; + + /* Locate the PMA closest to the PCS as this should be the one provided + * with the DW IP. This is identified by being the PMA with the + * highest MMD device address. + */ + devs1 &= MDIO_DEVS_SEP_PMA1 | MDIO_DEVS_SEP_PMA2 | MDIO_DEVS_SEP_PMA3 | + MDIO_DEVS_SEP_PMA4 | MDIO_DEVS_PMAPMD; + b = fls(devs1); + if (b) + return b - 1; + + return -ENODEV; +} + +struct pma_pcs_values { + int lanes; + u16 rsfec_ctrl; +}; + +static int +xpcs_config_rsfec_pma(struct dw_xpcs *xpcs, const struct pma_pcs_values *v) +{ + int ret = 0, i, pma_mmd; + + pma_mmd = xpcs_get_pma_mmd(xpcs); + if (pma_mmd < 1) + return pma_mmd; + + for (i = 0; ret >= 0 && i < v->lanes; i++) { + ret = xpcs_bus_write(xpcs, i, pma_mmd, MDIO_PMA_RSFEC_CTRL, + v->rsfec_ctrl); + } + return ret; +} + +static int xpcs_25gbaser_pma_config(struct dw_xpcs *xpcs) +{ + const struct pma_pcs_values v = { + .rsfec_ctrl = 0, + .lanes = 1, + }; + + return xpcs_config_rsfec_pma(xpcs, &v); +} + +static int xpcs_50gbaser_pma_config(struct dw_xpcs *xpcs) +{ + const struct pma_pcs_values v = { + .rsfec_ctrl = DW_VR_RSFEC_CTRL_TC_PAD_ALTER, + .lanes = 2, + }; + + return xpcs_config_rsfec_pma(xpcs, &v); +} + +static int xpcs_100gbasep_pma_config(struct dw_xpcs *xpcs) +{ + const struct pma_pcs_values v = { + .rsfec_ctrl = MDIO_PMA_RSFEC_CTRL_4LANE_PMD, + .lanes = 2, + }; + + return xpcs_config_rsfec_pma(xpcs, &v); +} + static const struct dw_xpcs_compat synopsys_xpcs_compat[] = { { .interface = PHY_INTERFACE_MODE_USXGMII, @@ -1415,6 +1493,7 @@ static const struct dw_xpcs_compat synopsys_xpcs_compat[] = { .interface = PHY_INTERFACE_MODE_25GBASER, .supported = xpcs_25gbaser_features, .an_mode = DW_AN_C73, + .pma_config = xpcs_25gbaser_pma_config, }, { .interface = PHY_INTERFACE_MODE_XLGMII, .supported = xpcs_xlgmii_features, @@ -1423,14 +1502,17 @@ static const struct dw_xpcs_compat synopsys_xpcs_compat[] = { .interface = PHY_INTERFACE_MODE_50GBASER, .supported = xpcs_50gbaser_features, .an_mode = DW_AN_C73, + .pma_config = xpcs_50gbaser_pma_config, }, { .interface = PHY_INTERFACE_MODE_LAUI, .supported = xpcs_50gbaser2_features, .an_mode = DW_AN_C73, + .pma_config = xpcs_50gbaser_pma_config, }, { .interface = PHY_INTERFACE_MODE_100GBASEP, .supported = xpcs_100gbasep_features, .an_mode = DW_AN_C73, + .pma_config = xpcs_100gbasep_pma_config, }, { .interface = PHY_INTERFACE_MODE_10GBASER, .supported = xpcs_10gbaser_features, diff --git a/drivers/net/pcs/pcs-xpcs.h b/drivers/net/pcs/pcs-xpcs.h index 929fa238445e..187cdec30e70 100644 --- a/drivers/net/pcs/pcs-xpcs.h +++ b/drivers/net/pcs/pcs-xpcs.h @@ -94,6 +94,12 @@ #define DW_VR_MII_DIG_CTRL2_TX_POL_INV BIT(4) #define DW_VR_MII_DIG_CTRL2_RX_POL_INV BIT(0) +/* Clause 133 defines */ +/* RSFEC transcode pad alter + * DW vendor extension in RS-FEC control + */ +#define DW_VR_RSFEC_CTRL_TC_PAD_ALTER BIT(10) + #define DW_XPCS_INFO_DECLARE(_name, _pcs, _pma) \ static const struct dw_xpcs_info _name = { .pcs = _pcs, .pma = _pma } diff --git a/include/uapi/linux/mdio.h b/include/uapi/linux/mdio.h index b2541c948fc1..5219c877b2cf 100644 --- a/include/uapi/linux/mdio.h +++ b/include/uapi/linux/mdio.h @@ -317,6 +317,9 @@ #define MDIO_PMA_10GBR_FECABLE_ABLE 0x0001 /* FEC ability */ #define MDIO_PMA_10GBR_FECABLE_ERRABLE 0x0002 /* FEC error indic. ability */ +/* RSFEC PMA Control register */ +#define MDIO_PMA_RSFEC_CTRL_4LANE_PMD BIT(3) + /* PMA 10GBASE-R Fast Retrain status and control register. */ #define MDIO_PMA_10GBR_FSRT_ENABLE 0x0001 /* Fast retrain enable */ -- 2.43.0